Change 'DD_COMPUTE_' prefix for environment variables to 'MCP_' (#4).

Author: tintoy

CHANGES.md

@@ -0,0 +1,7 @@
+# Changes
+
+## v0.3
+
+Breaking changes:
+
+* All environment variables that previously used the prefix `DD_COMPUTE_` have been changed to use the prefix `MCP_`.

CONTRIBUTING.md

@@ -0,0 +1,69 @@
+# Contributing
+
+Contributions are welcome, and they are greatly appreciated! Every little bit helps, and credit will always be given.
+
+You can contribute in many ways:
+
+## Types of Contributions
+
+### Report Bugs
+
+Report bugs at https://github.com/DimensionDataResearch/docker-machine-driver-ddcloud/issues.
+
+If you are reporting a bug, please include:
+
+* Your operating system name and version.
+* Any details about your local setup that might be helpful in troubleshooting.
+* Detailed steps to reproduce the bug.
+
+### Fix Bugs
+
+Look through the GitHub issues for bugs. Anything tagged with "bug"
+and "help wanted" is open to whoever wants to implement it.
+
+### Implement Features
+
+Look through the GitHub issues for features. Anything tagged with "enhancement"
+and "help wanted" is open to whoever wants to implement it.
+
+### Write Documentation
+
+The Docker Machine driver for CloudControl could always use more documentation, whether as part of the
+official documentation, in GoDoc, or even on the web in blog posts, articles, and such.
+
+### Submit Feedback
+
+The best way to send feedback is to file an issue at https://github.com/DimensionDataResearch/docker-machine-driver-ddcloud/issues.
+
+If you are proposing a feature:
+
+* Explain in detail how it would work.
+* Keep the scope as narrow as possible, to make it easier to implement.
+* Remember that this is a volunteer-driven project, and that contributions are welcome :)
+
+## Get Started!
+
+Ready to contribute? Here's how to set up `docker-machine-driver-ddcloud` for local development.
+
+1. Set up your build environment:
+  * If you have Vagrant and VMWare / VirtualBox, you can run `vagrant up` to create a VM to work in.
+    * The resulting VM will have your repository folder mapped into the VM as a shared folder (so you can use your regular editor on your machine, but run build commands in the VM).
+    * Run `vagrant ssh` to connect to the VM.
+  * Otherwise:
+    1. Install Go version 1.6.x
+    2. Make sure your GOPATH environment variable has been set.
+    3. Run `go get -u github.com/DimensionDataResearch/docker-machine-driver-ddcloud`.
+    4. Go to $GOPATH/src/github.com/DimensionDataResearch/docker-machine-driver-ddcloud.
+2. Run `make dev` to build the provider, then `make install` to make it available to execute.
+
+## Pull Request Guidelines
+
+Before you submit a pull request, check that it meets these guidelines:
+
+1. Your pull request should target the [development/v1.0](https://github.com/DimensionDataResearch/docker-machine-driver-ddcloud/tree/development/v1.0) branch.
+2. The pull request should include tests (either unit or acceptance, as appropriate).
+3. If the pull request adds or changes functionality, the docs should be updated.
+
+## Tips
+
+To enable extended logging of CloudControl API request and responses, set the `MCP_EXTENDED_LOGGING` environment variable to "1".

CONTRIBUTORS.md

@@ -0,0 +1,5 @@
+# Contributors
+
+We'd like to thank the following people for their contributions to the CloudControl driver for Docker Machine:
+
+* Adam Friedman ([@tintoy](https://github.com/tintoy))

README.md

@@ -31,27 +31,27 @@ If you're running on Windows, just remove the backslashes so the whole command i
 The driver supports all Docker Machine commands, and can be configured using the following command-line arguments (or environment variables):
 
 * `ddcloud-user` - The user name used to authenticate to the CloudControl API.  
-Environment: `DD_COMPUTE_USER`
+Environment: `MCP_USER`
 * `ddcloud-password` - The password used to authenticate to the CloudControl API.  
-Environment: `DD_COMPUTE_PASSWORD`.
+Environment: `MCP_PASSWORD`.
 * `ddcloud-region` - The CloudControl region name (e.g. AU, NA, EU, etc).  
-Environment: `DD_COMPUTE_REGION`.
+Environment: `MCP_REGION`.
 * `ddcloud-networkdomain` - The name of the target CloudControl network domain.
 * `ddcloud-datacenter` - The name of the CloudControl datacenter (e.g. NA1, AU9) in which the network domain is located.
 * `ddcloud-vlan` - The name of the target CloudControl VLAN.
 * `ddcloud-image-name` - The name of the OS image used to create the target machine.  
 Note that only OS images are supported for now, not customer images. Additionally, the OS must be a Linux distribution supported by docker-machine.
 * `ddcloud-ssh-user` - The SSH username to use.  
 Default: "root".  
-Environment: `DD_COMPUTE_SSH_USER`
+Environment: `MCP_SSH_USER`
 * `ddcloud-ssh-key` - The SSH key file to use.  
-Environment: `DD_COMPUTE_SSH_KEY`
+Environment: `MCP_SSH_KEY`
 * `ddcloud-ssh-port` - The SSH port to use.  
 Default: 22.  
-Environment: `DD_COMPUTE_SSH_PORT`
+Environment: `MCP_SSH_PORT`
 * `ddcloud-ssh-bootstrap-password` - The initial SSH password used to bootstrap SSH key authentication.  
 This password is removed once the SSH key has been installed  
-Environment: `DD_COMPUTE_SSH_BOOTSTRAP_PASSWORD`
+Environment: `MCP_SSH_BOOTSTRAP_PASSWORD`
 * `ddcloud-create-ssh-firewall-rule` - Automatically create a firewall rule to enable inbound SSH to the target server?
 
 ## Installing the provider

Vagrantfile

@@ -0,0 +1,68 @@
+# -*- mode: ruby -*-
+# vi: set ft=ruby :
+
+# Vagrantfile API/syntax version. Don't touch unless you know what you're doing!
+VAGRANTFILE_API_VERSION = "2"
+
+$script = <<SCRIPT
+GOVERSION="1.7"
+SRCROOT="/opt/go"
+SRCPATH="/opt/gopath"
+# Get the ARCH
+ARCH=`uname -m | sed 's|i686|386|' | sed 's|x86_64|amd64|'`
+# Install Prereq Packages
+sudo apt-get update
+sudo apt-get upgrade -y
+sudo apt-get install -y build-essential curl git-core libpcre3-dev mercurial pkg-config zip
+# Install Go
+cd /tmp
+wget --quiet https://storage.googleapis.com/golang/go${GOVERSION}.linux-${ARCH}.tar.gz
+tar -xvf go${GOVERSION}.linux-${ARCH}.tar.gz
+sudo mv go $SRCROOT
+sudo chmod 775 $SRCROOT
+sudo chown vagrant:vagrant $SRCROOT
+# Setup the GOPATH; even though the shared folder spec gives the working
+# directory the right user/group, we need to set it properly on the
+# parent path to allow subsequent "go get" commands to work.
+sudo mkdir -p $SRCPATH
+sudo chown -R vagrant:vagrant $SRCPATH 2>/dev/null || true
+# ^^ silencing errors here because we expect this to fail for the shared folder
+cat <<EOF >/tmp/gopath.sh
+export GOPATH="$SRCPATH"
+export GOROOT="$SRCROOT"
+export PATH="$SRCROOT/bin:$SRCPATH/bin:\$PATH"
+EOF
+cat <<EOF >>~/.bashrc
+## Make sure we have the source for Docker Machine itself
+go get -u github.com/docker/machine
+## After login, change to docker-machine-driver-ddcloud directory
+cd /opt/gopath/src/github.com/DimensionDataResearch/docker-machine-driver-ddcloud
+EOF
+sudo mv /tmp/gopath.sh /etc/profile.d/gopath.sh
+sudo chmod 0755 /etc/profile.d/gopath.sh
+SCRIPT
+
+Vagrant.configure(VAGRANTFILE_API_VERSION) do |config|
+  config.vm.box = "bento/ubuntu-14.04"
+  config.vm.hostname = "docker-machine-driver-ddcloud"
+
+  config.vm.provision "shell", inline: $script, privileged: false
+  config.vm.synced_folder '.', '/opt/gopath/src/github.com/DimensionDataResearch/docker-machine-driver-ddcloud'
+
+  ["vmware_fusion", "vmware_workstation"].each do |p|
+    config.vm.provider p do |v|
+      v.vmx["memsize"] = "4096"
+      v.vmx["numvcpus"] = "2"
+    end
+  end
+
+  config.vm.provider "virtualbox" do |v|
+    v.memory = 4096
+    v.cpus = 2
+  end
+
+  config.vm.provider "parallels" do |prl|
+    prl.memory = 4096
+    prl.cpus = 2
+  end
+end

driver.go

@@ -84,19 +84,19 @@ type Driver struct {
 func (driver *Driver) GetCreateFlags() []mcnflag.Flag {
 	return []mcnflag.Flag{
 		mcnflag.StringFlag{
-			EnvVar: "DD_COMPUTE_USER",
+			EnvVar: "MCP_USER",
 			Name:   "ddcloud-user",
 			Usage:  "The CloudControl user name",
 			Value:  "",
 		},
 		mcnflag.StringFlag{
-			EnvVar: "DD_COMPUTE_PASSWORD",
+			EnvVar: "MCP_PASSWORD",
 			Name:   "ddcloud-password",
 			Usage:  "The CloudControl password",
 			Value:  "",
 		},
 		mcnflag.StringFlag{
-			EnvVar: "DD_COMPUTE_REGION",
+			EnvVar: "MCP_REGION",
 			Name:   "ddcloud-region",
 			Usage:  "The CloudControl region name",
 			Value:  "",
@@ -122,25 +122,25 @@ func (driver *Driver) GetCreateFlags() []mcnflag.Flag {
 			Value: DefaultImageName,
 		},
 		mcnflag.StringFlag{
-			EnvVar: "DD_COMPUTE_SSH_USER",
+			EnvVar: "MCP_SSH_USER",
 			Name:   "ddcloud-ssh-user",
 			Usage:  "The SSH username to use. Default: root",
 			Value:  "root",
 		},
 		mcnflag.StringFlag{
-			EnvVar: "DD_COMPUTE_SSH_KEY",
+			EnvVar: "MCP_SSH_KEY",
 			Name:   "ddcloud-ssh-key",
 			Usage:  "The SSH key file to use",
 			Value:  "",
 		},
 		mcnflag.IntFlag{
-			EnvVar: "DD_COMPUTE_SSH_PORT",
+			EnvVar: "MCP_SSH_PORT",
 			Name:   "ddcloud-ssh-port",
 			Usage:  "The SSH port. Default: 22",
 			Value:  22,
 		},
 		mcnflag.StringFlag{
-			EnvVar: "DD_COMPUTE_SSH_BOOTSTRAP_PASSWORD",
+			EnvVar: "MCP_SSH_BOOTSTRAP_PASSWORD",
 			Name:   "ddcloud-ssh-bootstrap-password",
 			Usage:  "The initial SSH password used to bootstrap SSH key authentication",
 			Value:  "",