Enable auto-create of firewall rule for SSH (if required).

Author: tintoy

README.md

@@ -6,7 +6,8 @@ You will need:
 
 * A network domain
 * A VLAN in that network domain (servers will be attached to this VLAN)
-* A firewall rule that permits SSH traffic from your (local) public IPv4 address to the VLAN's IPv4 network
+* A firewall rule that permits SSH traffic from your (local) public IPv4 address to the VLAN's IPv4 network  
+Alternatively, you can use the `--ddcloud-create-ssh-firewall-rule` flag when creating your machine
 
 The driver will allocate a public IP address and NAT rule for each machine that it creates.
 
@@ -49,6 +50,7 @@ Environment: `DD_COMPUTE_SSH_PORT`
 * `ddcloud-ssh-bootstrap-password` - The initial SSH password used to bootstrap SSH key authentication.  
 This password is removed once the SSH key has been installed  
 Environment: `DD_COMPUTE_SSH_BOOTSTRAP_PASSWORD`
+* `ddcloud-create-ssh-firewall-rule` - Automatically create a firewall rule to enable inbound SSH to the target server?
 
 ## Installing the provider
 

client.go

@@ -9,8 +9,6 @@ import (
 	"time"
 )
 
-var firewallRuleNameSanitizer = strings.NewReplacer("-", ".", "_", ".")
-
 // Get the CloudControl API client used by the driver.
 func (driver *Driver) getCloudControlClient() (client *compute.Client, err error) {
 	client = driver.client
@@ -461,7 +459,7 @@ func (driver *Driver) createSSHFirewallRule(clientPublicIPAddress string) error
 	)
 
 	ruleConfiguration := compute.FirewallRuleConfiguration{
-		Name: firewallRuleNameSanitizer.Replace(driver.MachineName),
+		Name: driver.buildFirewallRuleName("SSH"),
 	}
 	ruleConfiguration.Accept()
 	ruleConfiguration.Enable()
@@ -517,3 +515,13 @@ func (driver *Driver) deleteSSHFirewallRule() error {
 
 	return nil
 }
+
+// Name sanitiser for firewall rules.
+var firewallRuleNameSanitizer = strings.NewReplacer("-", ".", "_", ".")
+
+// Build an acceptable name for a firewall rule.
+func (driver *Driver) buildFirewallRuleName(suffix string) string {
+	return strings.ToLower(
+		firewallRuleNameSanitizer.Replace(driver.MachineName) + "." + suffix,
+	)
+}