resolve my own comments on #820 and Devsh-Graphics-Programming/Nabla-Examples-and-Tests#173

Author: devsh

examples_tests

@@ -1,34 +1,39 @@
 // Copyright (C) 2018-2025 - DevSH Graphics Programming Sp. z O.O.
 // This file is part of the "Nabla Engine".
 // For conditions of distribution and use, see copyright notice in nabla.h
-
-#ifndef _NBL_BUILTIN_GLSL_RANDOM_LCG_HLSL_INCLUDED_
-#define _NBL_BUILTIN_GLSL_RANDOM_LCG_HLSL_INCLUDED_
+#ifndef _NBL_BUILTIN_HLSL_RANDOM_LCG_HLSL_INCLUDED_
+#define _NBL_BUILTIN_HLSL_RANDOM_LCG_HLSL_INCLUDED_
 
 namespace nbl
 {
 namespace hlsl
 {
+namespace random
+{
 
 struct Lcg
 {
-    static Lcg construct(NBL_CONST_REF_ARG(uint32_t) state)
+    static Lcg create(const uint32_t _state)
 	{
-        return Lcg(state);
+        Lcg retval;
+        retval.state = _state;
+        return retval;
     }
 
-	uint32_t2 operator()()
+	uint32_t operator()()
 	{
         uint32_t LCG_A = 1664525u;
         uint32_t LCG_C = 1013904223u;
         state = (LCG_A * state + LCG_C);
+        // is this mask supposed to be here? because usually we turn random uints to float by dividing by UINT32_MAX
         state &= 0x00FFFFFF;
         return state;
     }
 
     uint32_t state;
 };
 
+}
 }
 }
 #endif

include/nbl/builtin/hlsl/random/lcg.hlsl

@@ -1,21 +1,23 @@
 // Copyright (C) 2018-2025 - DevSH Graphics Programming Sp. z O.O.
 // This file is part of the "Nabla Engine".
 // For conditions of distribution and use, see copyright notice in nabla.h
-
-#ifndef _NBL_BUILTIN_GLSL_RANDOM_PCG_HLSL_INCLUDED_
-#define _NBL_BUILTIN_GLSL_RANDOM_PCG_HLSL_INCLUDED_
+#ifndef _NBL_BUILTIN_HLSL_RANDOM_PCG_HLSL_INCLUDED_
+#define _NBL_BUILTIN_HLSL_RANDOM_PCG_HLSL_INCLUDED_
 
 namespace nbl
 {
 namespace hlsl
 {
+namespace random
+{
 
 struct Pcg
 {
-	static Pcg construct(NBL_CONST_REF_ARG(uint32_t) initialState)
+	static Pcg create(const uint32_t initialState)
 	{
-		uint32_t state = {initialState};
-		return Pcg(state);
+		Pcg retval;
+		retval.state = initialState;
+		return retval;
 	}
 
 	uint32_t operator()()
@@ -29,6 +31,7 @@ struct Pcg
 	uint32_t state;
 };
 
+}
 }
 }
 #endif

include/nbl/builtin/hlsl/random/pcg.hlsl

@@ -1,24 +1,25 @@
 // Copyright (C) 2018-2025 - DevSH Graphics Programming Sp. z O.O.
 // This file is part of the "Nabla Engine".
 // For conditions of distribution and use, see copyright notice in nabla.h
-
-#ifndef _NBL_BUILTIN_GLSL_RANDOM_TEA_HLSL_INCLUDED_
-#define _NBL_BUILTIN_GLSL_RANDOM_TEA_HLSL_INCLUDED_
+#ifndef _NBL_BUILTIN_HLSL_RANDOM_TEA_HLSL_INCLUDED_
+#define _NBL_BUILTIN_HLSL_RANDOM_TEA_HLSL_INCLUDED_
 
 namespace nbl
 {
 namespace hlsl
 {
+namespace random
+{
 
 struct Tea
 {
-    static Tea construct()
+    static Tea create()
 	{
-        Tea tea = {};
+        Tea tea;
         return tea;
     }
 
-    uint32_t2 operator()(uint32_t stream, uint32_t sequence, uint32_t roundCount)
+    static uint32_t2 __call(const uint32_t stream, const uint32_t sequence, const uint32_t roundCount)
 	{
         uint32_t sum = 0;
         uint32_t v0 = stream;
@@ -32,9 +33,14 @@ struct Tea
 
 		return uint32_t2(v0, v1);
     }
-
+	
+    uint32_t2 operator()(const uint32_t stream, const uint32_t sequence, const uint32_t roundCount) NBL_CONST_MEMBER_FUNC
+	{
+        return __call(stream,sequence,roundCount);
+    }
 };
 
+}
 }
 }
 #endif

include/nbl/builtin/hlsl/random/tea.hlsl

@@ -1,10 +1,8 @@
-
 // Copyright (C) 2018-2020 - DevSH Graphics Programming Sp. z O.O.
 // This file is part of the "Nabla Engine".
 // For conditions of distribution and use, see copyright notice in nabla.h
-
-#ifndef _NBL_BUILTIN_GLSL_RANDOM_XOROSHIRO_HLSL_INCLUDED_
-#define _NBL_BUILTIN_GLSL_RANDOM_XOROSHIRO_HLSL_INCLUDED_
+#ifndef _NBL_BUILTIN_HLSL_RANDOM_XOROSHIRO_HLSL_INCLUDED_
+#define _NBL_BUILTIN_HLSL_RANDOM_XOROSHIRO_HLSL_INCLUDED_
 
 #include <nbl/builtin/hlsl/cpp_compat/vector.hlsl>
 
@@ -14,6 +12,9 @@ namespace nbl
 {
 namespace hlsl
 {
+// TODO
+//namespace random
+//{
 
 struct Xoroshiro64StateHolder
 {
@@ -29,6 +30,7 @@ struct Xoroshiro64StateHolder
 
 struct Xoroshiro64Star
 {
+	// TODO: create
 	static Xoroshiro64Star construct(NBL_CONST_REF_ARG(uint32_t2) initialState)
 	{
 		Xoroshiro64StateHolder stateHolder = {initialState};
@@ -48,6 +50,7 @@ struct Xoroshiro64Star
 
 struct Xoroshiro64StarStar
 {
+	// TODO: create
 	static Xoroshiro64StarStar construct(NBL_CONST_REF_ARG(uint32_t2) initialState)
 	{
 		Xoroshiro64StateHolder stateHolder = {initialState};
@@ -65,6 +68,7 @@ struct Xoroshiro64StarStar
 	Xoroshiro64StateHolder stateHolder;
 };
 
+//}
 }
 }
 

include/nbl/builtin/hlsl/random/xoroshiro.hlsl

@@ -1899,9 +1899,10 @@ bool IGPUCommandBuffer::setRayTracingPipelineStackSize(uint32_t pipelineStackSiz
 {
     if (!checkStateBeforeRecording(queue_flags_t::COMPUTE_BIT,RENDERPASS_SCOPE::OUTSIDE))
         return false;
-    if (m_boundRayTracingPipeline != nullptr && m_boundRayTracingPipeline->getCachedCreationParams().dynamicStackSize)
+    if (!m_boundRayTracingPipeline || !m_boundRayTracingPipeline->getCachedCreationParams().dynamicStackSize)
     {
-      NBL_LOG_ERROR("Cannot set dynamic state when state is not mark as dynamic on bound pipeline!");
+        NBL_LOG_ERROR("Cannot set dynamic state when state is not mark as dynamic on bound pipeline!");
+        return false;
     }
     m_haveRtPipelineStackSize = true;
     return setRayTracingPipelineStackSize_impl(pipelineStackSize);