Use spans for reporting Physical Devices, then use set references for filtering

Author: devshgraphicsprogramming

examples_tests

@@ -57,7 +57,7 @@ class NBL_API2 IAPIConnection : public core::IReferenceCounted
 
         virtual IDebugCallback* getDebugCallback() const = 0;
 
-        core::SRange<IPhysicalDevice* const> getPhysicalDevices() const;
+        std::span<IPhysicalDevice* const> getPhysicalDevices() const;
 
         const SFeatures& getEnabledFeatures() const { return m_enabledFeatures; };
 

include/nbl/video/IAPIConnection.h

@@ -62,13 +62,10 @@ namespace nbl::video
 
 
         // sift through multiple devices
-        core::set<IPhysicalDevice*> operator()(const core::SRange<IPhysicalDevice* const>& physicalDevices) const
+        template<typename PhysicalDevice> requires std::is_same_v<std::remove_cv_t<PhysicalDevice>,video::IPhysicalDevice>
+        void operator()(core::set<PhysicalDevice*>& physicalDevices) const
         {
-		    core::set<IPhysicalDevice*> ret;
-		    for (auto& physDev : physicalDevices)
-			if (meetsRequirements(physDev))
-				ret.insert(physDev);
-            return ret;
+            std::erase_if(physicalDevices,[&](const video::IPhysicalDevice* device)->bool{return !meetsRequirements(device);});
         }
 
         // check one device

include/nbl/video/utilities/SPhysicalDeviceFilter.h

@@ -10,13 +10,12 @@
 namespace nbl::video
 {
 
-core::SRange<IPhysicalDevice* const> IAPIConnection::getPhysicalDevices() const
+std::span<IPhysicalDevice* const> IAPIConnection::getPhysicalDevices() const
 {
     static_assert(sizeof(std::unique_ptr<IPhysicalDevice>) == sizeof(void*));
 
-    return core::SRange<IPhysicalDevice* const>(
-        reinterpret_cast<IPhysicalDevice* const*>(m_physicalDevices.data()),
-        reinterpret_cast<IPhysicalDevice* const*>(m_physicalDevices.data()) + m_physicalDevices.size());
+    IPhysicalDevice* const* const begin = reinterpret_cast<IPhysicalDevice* const*>(m_physicalDevices.data());
+    return {begin,m_physicalDevices.size()};
 }
 
 IAPIConnection::IAPIConnection(const SFeatures& enabledFeatures)