revert changes to commonapi and fix

Erfan-Ahmadi · Erfan-Ahmadi · commit f1ab637e3a35 · 2023-11-28T17:38:04.000+04:00
diff --git a/examples_tests b/examples_tests
@@ -1 +1 @@
-Subproject commit 562619e4166e0752998f9819b15da6f70da3d99c
+Subproject commit 64adb801f2ae401acb85c99873b249744ddc2511
diff --git a/include/nbl/system/IApplicationFramework.h b/include/nbl/system/IApplicationFramework.h
@@ -19,7 +19,7 @@
 namespace nbl::system
 {
 
-class IApplicationFramework : public core::IReferenceCounted
+class IApplicationFramework : public virtual core::IReferenceCounted
 {
 	public:
         // this is safe to call multiple times
diff --git a/include/nbl/ui/IWindow.h b/include/nbl/ui/IWindow.h
@@ -42,7 +42,7 @@ class IWindow : public core::IReferenceCounted
             ECF_NONE = 0
         };
 
-        class IEventCallback : public core::IReferenceCounted
+        class IEventCallback : public virtual core::IReferenceCounted
         {
             public:
                 // TODO: rethink our boolean returns

Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,7 @@`
`19`	`19`	`namespace nbl::system`
`20`	`20`	`{`
`21`	`21`
`22`		`-class IApplicationFramework : public core::IReferenceCounted`
	`22`	`+class IApplicationFramework : public virtual core::IReferenceCounted`
`23`	`23`	`{`
`24`	`24`	`public:`
`25`	`25`	`// this is safe to call multiple times`
Original file line number	Diff line number	Diff line change
`@@ -42,7 +42,7 @@ class IWindow : public core::IReferenceCounted`
`42`	`42`	`ECF_NONE = 0`
`43`	`43`	`};`
`44`	`44`
`45`		`- class IEventCallback : public core::IReferenceCounted`
	`45`	`+ class IEventCallback : public virtual core::IReferenceCounted`
`46`	`46`	`{`
`47`	`47`	`public:`
`48`	`48`	`// TODO: rethink our boolean returns`