Improve some flags naming

Author: kevyuu

include/nbl/asset/IPipeline.h

@@ -71,8 +71,8 @@ class IPipeline
 					//CREATE_LIBRARY = 1<<11,
 
 					// Ray Tracing Pipelines only
-					SKIP_TRIANGLES_BIT = 1<<12,
-					SKIP_AABBS_BIT = 1<<13,
+					SKIP_TRIANGLES = 1<<12,
+					SKIP_AABBS = 1<<13,
 					//RAY_TRACING_NO_NULL_ANY_HIT_SHADERS_BIT_KHR = 1<<14,
 					//RAY_TRACING_NO_NULL_CLOSEST_HIT_SHADERS_BIT_KHR = 1<<15,
 					//RAY_TRACING_NO_NULL_MISS_SHADERS_BIT_KHR = 1<<16,

include/nbl/video/IGPURayTracingPipeline.h

@@ -37,12 +37,12 @@ class IGPURayTracingPipeline : public IBackendObject, public asset::IRayTracingP
                 EARLY_RETURN_ON_FAILURE = base_flag(EARLY_RETURN_ON_FAILURE),
                 LINK_TIME_OPTIMIZATION = base_flag(LINK_TIME_OPTIMIZATION),
                 RETAIN_LINK_TIME_OPTIMIZATION_INFO_BIT_EXT = base_flag(RETAIN_LINK_TIME_OPTIMIZATION_INFO),
-                SKIP_TRIANGLES_BIT_KHR = base_flag(SKIP_TRIANGLES_BIT),
-                SKIP_AABBS_BIT_KHR = base_flag(SKIP_AABBS_BIT),
-                NO_NULL_ANY_HIT_SHADERS_BIT_KHR = 1<<14,
-                NO_NULL_CLOSEST_HIT_SHADERS_BIT_KHR = 1<<15,
-                NO_NULL_MISS_SHADERS_BIT_KHR = 1<<16,
-                NO_NULL_INTERSECTION_SHADERS_BIT_KHR = 1<<17,
+                SKIP_TRIANGLES = base_flag(SKIP_TRIANGLES),
+                SKIP_AABBS = base_flag(SKIP_AABBS),
+                NO_NULL_ANY_HIT_SHADERS = 1<<14,
+                NO_NULL_CLOSEST_HIT_SHADERS = 1<<15,
+                NO_NULL_MISS_SHADERS = 1<<16,
+                NO_NULL_INTERSECTION_SHADERS = 1<<17,
                 ALLOW_MOTION_BIT_NV = 1<<20,
             };
             #undef base_flag

src/nbl/video/IGPUCommandBuffer.cpp

@@ -699,17 +699,17 @@ bool IGPUCommandBuffer::invalidShaderGroups(
     // https://registry.khronos.org/vulkan/specs/latest/man/html/vkCmdTraceRaysKHR.html#VUID-vkCmdTraceRaysKHR-flags-03697
     // https://registry.khronos.org/vulkan/specs/latest/man/html/vkCmdTraceRaysKHR.html#VUID-vkCmdTraceRaysKHR-flags-03512
     const auto shouldHaveHitGroup = flags & 
-      (PipelineFlags(PipelineFlag::RAY_TRACING_NO_NULL_ANY_HIT_SHADERS_BIT_KHR) | 
-        PipelineFlag::RAY_TRACING_NO_NULL_CLOSEST_HIT_SHADERS_BIT_KHR |
-        PipelineFlag::RAY_TRACING_NO_NULL_INTERSECTION_SHADERS_BIT_KHR);
+      (PipelineFlags(PipelineFlag::NO_NULL_ANY_HIT_SHADERS) | 
+        PipelineFlag::NO_NULL_CLOSEST_HIT_SHADERS |
+        PipelineFlag::NO_NULL_INTERSECTION_SHADERS);
     if (shouldHaveHitGroup && !hitGroupsRange.buffer)
     {
         NBL_LOG_ERROR("bound pipeline indicates that traceRays command should have hit group, but hitGroupsRange.buffer is null!");
         return true;
     }
 
     // https://registry.khronos.org/vulkan/specs/latest/man/html/vkCmdTraceRaysKHR.html#VUID-vkCmdTraceRaysKHR-flags-03511
-    const auto shouldHaveMissGroup = flags & PipelineFlag::RAY_TRACING_NO_NULL_MISS_SHADERS_BIT_KHR;
+    const auto shouldHaveMissGroup = flags & PipelineFlag::NO_NULL_MISS_SHADERS;
     if (shouldHaveMissGroup && !missGroupsRange.buffer)
     {
         NBL_LOG_ERROR("bound pipeline indicates that traceRays command should have hit group, but hitGroupsRange.buffer is null!");
@@ -1899,7 +1899,7 @@ bool IGPUCommandBuffer::setRayTracingPipelineStackSize(uint32_t pipelineStackSiz
 {
     if (!checkStateBeforeRecording(queue_flags_t::COMPUTE_BIT,RENDERPASS_SCOPE::OUTSIDE))
         return false;
-    if (m_boundRayTracingPipeline->getCachedCreationParams().dynamicStackSize)
+    if (m_boundRayTracingPipeline != nullptr && m_boundRayTracingPipeline->getCachedCreationParams().dynamicStackSize)
     {
       NBL_LOG_ERROR("Cannot set dynamic state when state is not mark as dynamic on bound pipeline!");
     }