Skip to content

Commit e2e3adc

Browse files
committed
update scripts for generating define.h header - add _DXC_DLL_NAME_
1 parent 1f95857 commit e2e3adc

File tree

4 files changed

+13
-1
lines changed

4 files changed

+13
-1
lines changed

3rdparty/dxc/CMakeLists.txt

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -121,4 +121,11 @@ CACHE INTERNAL "")
121121

122122
set(DXC_DLL
123123
$<IF:$<CONFIG:Debug>,${NBL_DXC_DEBUG_DLL},${NBL_DXC_RELEASE_DLL}>
124+
CACHE INTERNAL "")
125+
126+
cmake_path(GET NBL_DXC_DEBUG_DLL FILENAME _NBL_DXC_DEBUG_DLL_NAME_)
127+
cmake_path(GET NBL_DXC_RELEASE_DLL FILENAME _NBL_DXC_RELEASE_DLL_NAME_)
128+
129+
set(DXC_DLL_NAME
130+
$<IF:$<CONFIG:Debug>,${_NBL_DXC_DEBUG_DLL_NAME_},${_NBL_DXC_RELEASE_DLL_NAME_}>
124131
CACHE INTERNAL "")

cmake/install/nbl/sharedDefines.h.in

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,4 +4,5 @@
44
*/
55

66
#define _NABLA_DLL_NAME_ "@_NABLA_DLL_NAME_@"
7+
#define _DXC_DLL_NAME_ "@_DXC_DLL_NAME_@"
78
#define _NABLA_INSTALL_DIR_ @_NABLA_INSTALL_DIR_@

cmake/scripts/nbl/nablaDefines.cmake

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,10 @@ if(NOT DEFINED _NABLA_DLL_NAME_)
4242
message(FATAL_ERROR "_NABLA_DLL_NAME_ variable must be specified for this script!")
4343
endif()
4444

45+
if(NOT DEFINED _DXC_DLL_NAME_)
46+
message(FATAL_ERROR "_DXC_DLL_NAME_ variable must be specified for this script!")
47+
endif()
48+
4549
if(NOT DEFINED _NABLA_INSTALL_DIR_)
4650
message(FATAL_ERROR "_NABLA_INSTALL_DIR_ variable must be specified for this script!")
4751
endif()

src/nbl/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -633,7 +633,7 @@ propagate_changed_variables_to_parent_scope()
633633

634634
if(NOT NBL_STATIC_BUILD)
635635
add_custom_command(OUTPUT "${CMAKE_CURRENT_BINARY_DIR}/$<CONFIG>/generated/define.h"
636-
COMMAND "${CMAKE_COMMAND}" -DNBL_ROOT_PATH:PATH=${NBL_ROOT_PATH} -DNBL_WRAPPER_FILE:FILEPATH=${_NBL_DEFINE_FILE_WRAPPER_} -DNBL_GEN_DIRECTORY:PATH=${CMAKE_CURRENT_BINARY_DIR}/$<CONFIG>/generated -D_NABLA_DLL_NAME_:STRING=$<TARGET_FILE_NAME:Nabla> -D_NABLA_INSTALL_DIR_:PATH="${CMAKE_INSTALL_PREFIX}" -P ${NBL_ROOT_PATH}/cmake/scripts/nbl/nablaDefines.cmake
636+
COMMAND "${CMAKE_COMMAND}" -DNBL_ROOT_PATH:PATH=${NBL_ROOT_PATH} -DNBL_WRAPPER_FILE:FILEPATH=${_NBL_DEFINE_FILE_WRAPPER_} -DNBL_GEN_DIRECTORY:PATH=${CMAKE_CURRENT_BINARY_DIR}/$<CONFIG>/generated -D_NABLA_DLL_NAME_:STRING=$<TARGET_FILE_NAME:Nabla> -D_DXC_DLL_NAME_:STRING=${DXC_DLL_NAME} -D_NABLA_INSTALL_DIR_:PATH="${CMAKE_INSTALL_PREFIX}" -P ${NBL_ROOT_PATH}/cmake/scripts/nbl/nablaDefines.cmake
637637
COMMENT "Launching defines.h generation script!"
638638
VERBATIM
639639
)

0 commit comments

Comments
 (0)