Add PR comments

deprilula28 · deprilula28 · commit d608e780494b · 2024-02-28T14:40:30.000-03:00
diff --git a/include/nbl/video/alloc/SubAllocatedDescriptorSet.h b/include/nbl/video/alloc/SubAllocatedDescriptorSet.h
@@ -221,6 +221,7 @@ class SubAllocatedDescriptorSet : public core::IReferenceCounted
 			writes.push_back(write);
 		}
 
+		// TODO: this goes outside
 		m_logicalDevice->updateDescriptorSets(writes, {});
 		return unallocatedSize;
 	}
@@ -279,6 +280,11 @@ class SubAllocatedDescriptorSet : public core::IReferenceCounted
 
 			allocator->free_addr(addr[i],1);
 			// TODO: should also write something to the descriptor sets
+			// basically if nullDescriptor device feature is enabled, you would 
+			// indeed write to the DS, else you'd just drop the refcounted references
+			//
+			// this needs to be done as a IGPUDescriptorSet::nullify(const uint32_t binding, 
+			// std::span<uint32_t> indices) function + a virtual nullify_impl
 		}
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -221,6 +221,7 @@ class SubAllocatedDescriptorSet : public core::IReferenceCounted`
`221`	`221`	`writes.push_back(write);`
`222`	`222`	`}`
`223`	`223`
	`224`	`+ // TODO: this goes outside`
`224`	`225`	`m_logicalDevice->updateDescriptorSets(writes, {});`
`225`	`226`	`return unallocatedSize;`
`226`	`227`	`}`
`@@ -279,6 +280,11 @@ class SubAllocatedDescriptorSet : public core::IReferenceCounted`
`279`	`280`
`280`	`281`	`allocator->free_addr(addr[i],1);`
`281`	`282`	`// TODO: should also write something to the descriptor sets`
	`283`	`+ // basically if nullDescriptor device feature is enabled, you would`
	`284`	`+ // indeed write to the DS, else you'd just drop the refcounted references`
	`285`	`+ //`
	`286`	`+ // this needs to be done as a IGPUDescriptorSet::nullify(const uint32_t binding,`
	`287`	`+ // std::span<uint32_t> indices) function + a virtual nullify_impl`
`282`	`288`	`}`
`283`	`289`	`}`
`284`	`290`