Fixed example 28

Przemog1 · Przemog1 · commit cc03dc920325 · 2025-02-24T16:53:25.000+01:00
diff --git a/examples_tests b/examples_tests
@@ -1 +1 @@
-Subproject commit cfe94ab965d067315228fbc9d7c9ebc25169d0b4
+Subproject commit 1acd06e1a312a73790eb6877b181d8008332c5e7
diff --git a/include/nbl/builtin/hlsl/workgroup/fft.hlsl b/include/nbl/builtin/hlsl/workgroup/fft.hlsl
@@ -129,14 +129,14 @@ struct FFTIndexingUtils
     // This is because Cooley-Tukey + subgroup operations end up spewing out the outputs in a weird order
     static uint32_t getDFTIndex(uint32_t outputIdx)
     {
-        return impl::circularBitShiftRightHigher<FFTSizeLog2, FFTSizeLog2 - ElementsPerInvocationLog2 + 1>(hlsl::bitReverseAs<uint32_t, FFTSizeLog2>(outputIdx));
+        return impl::circularBitShiftRightHigher<FFTSizeLog2, FFTSizeLog2 - ElementsPerInvocationLog2 + 1>(hlsl::bitReverseAs<uint32_t>(outputIdx, FFTSizeLog2));
     }
 
     // This function maps the index `freqIdx` in the DFT to the index `idx` in the output array of a Nabla FFT such that `DFT[freqIdx] = NablaFFT[idx]`
     // It is essentially the inverse of `getDFTIndex`
     static uint32_t getNablaIndex(uint32_t freqIdx)
     {
-        return hlsl::bitReverseAs<uint32_t, FFTSizeLog2>(impl::circularBitShiftLeftHigher<FFTSizeLog2, FFTSizeLog2 - ElementsPerInvocationLog2 + 1>(freqIdx));
+        return hlsl::bitReverseAs<uint32_t>(impl::circularBitShiftLeftHigher<FFTSizeLog2, FFTSizeLog2 - ElementsPerInvocationLog2 + 1>(freqIdx), FFTSizeLog2);
     }
 
     // Mirrors an index about the Nyquist frequency in the DFT order

Original file line number	Diff line number	Diff line change
`@@ -129,14 +129,14 @@ struct FFTIndexingUtils`
`129`	`129`	`// This is because Cooley-Tukey + subgroup operations end up spewing out the outputs in a weird order`
`130`	`130`	`static uint32_t getDFTIndex(uint32_t outputIdx)`
`131`	`131`	`{`
`132`		`- return impl::circularBitShiftRightHigher<FFTSizeLog2, FFTSizeLog2 - ElementsPerInvocationLog2 + 1>(hlsl::bitReverseAs<uint32_t, FFTSizeLog2>(outputIdx));`
	`132`	`+ return impl::circularBitShiftRightHigher<FFTSizeLog2, FFTSizeLog2 - ElementsPerInvocationLog2 + 1>(hlsl::bitReverseAs<uint32_t>(outputIdx, FFTSizeLog2));`
`133`	`133`	`}`
`134`	`134`
`135`	`135`	// This function maps the index `freqIdx` in the DFT to the index `idx` in the output array of a Nabla FFT such that `DFT[freqIdx] = NablaFFT[idx]`
`136`	`136`	// It is essentially the inverse of `getDFTIndex`
`137`	`137`	`static uint32_t getNablaIndex(uint32_t freqIdx)`
`138`	`138`	`{`
`139`		`- return hlsl::bitReverseAs<uint32_t, FFTSizeLog2>(impl::circularBitShiftLeftHigher<FFTSizeLog2, FFTSizeLog2 - ElementsPerInvocationLog2 + 1>(freqIdx));`
	`139`	`+ return hlsl::bitReverseAs<uint32_t>(impl::circularBitShiftLeftHigher<FFTSizeLog2, FFTSizeLog2 - ElementsPerInvocationLog2 + 1>(freqIdx), FFTSizeLog2);`
`140`	`140`	`}`
`141`	`141`
`142`	`142`	`// Mirrors an index about the Nyquist frequency in the DFT order`