Skip to content

Commit c847d6d

Browse files
committed
save work, don't add every builtin resource as Nabla dependency, hardcode path in CArchive.h.in
1 parent 9daedfa commit c847d6d

File tree

3 files changed

+13
-13
lines changed

3 files changed

+13
-13
lines changed

src/nbl/CMakeLists.txt

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -369,10 +369,12 @@ source_group("Resources to embed" FILES ${NABLA_RESOURCES_TO_EMBED_PUBLIC})
369369

370370
set(NABLA_HEADERS "${NBL_ROOT_PATH}/include/nabla.h" ${NABLA_HEADERS_PUBLIC} ${NABLA_HEADERS_PIRV1} ${NABLA_HEADERS_PRIV2})
371371

372+
get_target_property(_BUILTIN_RESOURCES_HEADER_DIRECTORY_ nblBuiltinResourceData BUILTIN_RESOURCES_HEADER_DIRECTORY)
373+
372374
set(NBL_LIBRARY_CREATION_SOURCES
373375
${NABLA_SRCS_COMMON}
374376
${NABLA_HEADERS}
375-
${_NBL_BUILTIN_RESOURCES_ARCHIVE_APK_SOURCES_}
377+
${_BUILTIN_RESOURCES_HEADER_DIRECTORY_}
376378
$<TARGET_OBJECTS:aesGladman>
377379
$<TARGET_OBJECTS:bzip2>
378380
$<TARGET_OBJECTS:lz4>
@@ -421,15 +423,15 @@ if(NOT NBL_STATIC_BUILD)
421423
endif()
422424

423425
if(NBL_EMBED_BUILTIN_RESOURCES)
424-
add_dependencies(Nabla ${_NBL_BUILTIN_RESOURCES_LIBRARIES_})
426+
add_dependencies(Nabla nblBuiltinResourceData)
425427

426428
if(NBL_STATIC_BUILD)
427429
target_link_libraries(Nabla INTERFACE
428-
${_NBL_BUILTIN_RESOURCES_LIBRARIES_}
430+
nblBuiltinResourceData
429431
)
430432
else()
431433
target_link_libraries(Nabla PRIVATE
432-
${_NBL_BUILTIN_RESOURCES_LIBRARIES_}
434+
nblBuiltinResourceData
433435
)
434436
endif()
435437
endif()

src/nbl/builtin/template/CArchive.h.in

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66

77
namespace @_NAMESPACE_@
88
{
9+
constexpr std::string_view path = "@_NAMESPACE_@/@_PATH_PREFIX_@"
910
constexpr std::string_view pathPrefix = "@_PATH_PREFIX_@";
1011
constexpr bool hasPathPrefix(std::string_view str) { return str.find(pathPrefix) == 0ull; }
1112

@@ -14,8 +15,8 @@ namespace @_NAMESPACE_@
1415
class CArchive final : public nbl::system::CFileArchive
1516
{
1617
public:
17-
inline CArchive(nbl::system::path _path, nbl::system::logger_opt_smart_ptr&& logger)
18-
: nbl::system::CFileArchive(std::move(_path),std::move(logger), getItemList()) {}
18+
inline CArchive(nbl::system::logger_opt_smart_ptr&& logger)
19+
: nbl::system::CFileArchive(std::move(nbl::system::path(path.data())),std::move(logger), getItemList()) {}
1920

2021
protected:
2122
file_buffer_t getFileBuffer(const nbl::system::IFileArchive::SListEntry* item) override

src/nbl/builtin/utils.cmake

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,10 @@ function(ADD_CUSTOM_BUILTIN_RESOURCES _TARGET_NAME_ _BUNDLE_NAME_ _BUNDLE_SEARCH
100100
"${NBL_BUILTIN_RESOURCE_DATA_SOURCE}"
101101
)
102102

103-
target_include_directories(${_TARGET_NAME_} PUBLIC "${NBL_ROOT_PATH}/include")
103+
target_include_directories(${_TARGET_NAME_} PUBLIC
104+
"${NBL_ROOT_PATH}/include"
105+
"${_OUTPUT_HEADER_DIRECTORY_}"
106+
)
104107
set_target_properties(${_TARGET_NAME_} PROPERTIES CXX_STANDARD 20)
105108

106109
if(NBL_DYNAMIC_MSVC_RUNTIME)
@@ -115,12 +118,6 @@ function(ADD_CUSTOM_BUILTIN_RESOURCES _TARGET_NAME_ _BUNDLE_NAME_ _BUNDLE_SEARCH
115118
"${_OUTPUT_HEADER_DIRECTORY_}/CArchive.h"
116119
)
117120

118-
list(APPEND _NBL_BUILTIN_RESOURCES_ARCHIVE_APK_SOURCES_ "${_OUTPUT_HEADER_DIRECTORY_}/CArchive.h")
119-
set(_NBL_BUILTIN_RESOURCES_ARCHIVE_APK_SOURCES_ ${_NBL_BUILTIN_RESOURCES_ARCHIVE_APK_SOURCES_} PARENT_SCOPE)
120-
121-
list(APPEND _NBL_BUILTIN_RESOURCES_LIBRARIES_ ${_TARGET_NAME_})
122-
set(_NBL_BUILTIN_RESOURCES_LIBRARIES_ ${_NBL_BUILTIN_RESOURCES_LIBRARIES_} PARENT_SCOPE) # override
123-
124121
macro(_ADD_PROPERTY_ _BR_PROPERTY_ _BR_PROXY_VAR_)
125122
get_property(_BR_PROPERTY_DEFINED_
126123
TARGET ${_TARGET_NAME_}

0 commit comments

Comments
 (0)