Skip to content

Commit b7d83a6

Browse files
committed
execute configuration for DXC only once, passtrough CMAKE_BUILD_TYPE for single-configuration generators (makefile/ninja in single config mode) - it doesn't matter for multi-configuration generators
1 parent 6a2b253 commit b7d83a6

File tree

1 file changed

+14
-28
lines changed

1 file changed

+14
-28
lines changed

3rdparty/dxc/CMakeLists.txt

Lines changed: 14 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -62,37 +62,23 @@ endif()
6262
set(DXC_BUILD_DIR "${CMAKE_CURRENT_BINARY_DIR}/build" CACHE INTERNAL "")
6363

6464
if(WIN32)
65-
execute_process(COMMAND "${CMAKE_COMMAND}" -C "${CMAKE_CURRENT_SOURCE_DIR}/dxc/cmake/caches/PredefinedParams.cmake" -S "${CMAKE_CURRENT_SOURCE_DIR}/dxc" -B "${DXC_BUILD_DIR}" -G "${CMAKE_GENERATOR}" "-Ax64" -T "${CMAKE_GENERATOR_TOOLSET}" ${NBL_DXC_CMAKE_OPTIONS}
66-
RESULT_VARIABLE DXC_CMAKE_RESULT
67-
OUTPUT_VARIABLE DXC_CMAKE_STREAM_PIPE
68-
)
69-
65+
execute_process(COMMAND "${CMAKE_COMMAND}" -C "${CMAKE_CURRENT_SOURCE_DIR}/dxc/cmake/caches/PredefinedParams.cmake" -S "${CMAKE_CURRENT_SOURCE_DIR}/dxc" -B "${DXC_BUILD_DIR}" -G "${CMAKE_GENERATOR}" "-Ax64" -T "${CMAKE_GENERATOR_TOOLSET}" ${NBL_DXC_CMAKE_OPTIONS}
66+
RESULT_VARIABLE DXC_CMAKE_RESULT
67+
OUTPUT_VARIABLE DXC_CMAKE_STREAM_PIPE
68+
)
7069
else()
71-
72-
execute_process(COMMAND "${CMAKE_COMMAND}"
73-
-S "${CMAKE_CURRENT_SOURCE_DIR}/dxc"
74-
-C "${CMAKE_CURRENT_SOURCE_DIR}/dxc/cmake/caches/PredefinedParams.cmake"
75-
-G "${CMAKE_GENERATOR}"
76-
-T "${CMAKE_GENERATOR_TOOLSET}"
77-
-B "${DXC_BUILD_DIR}"
78-
-D "CMAKE_BUILD_TYPE:STRING=Debug"
79-
RESULT_VARIABLE DXC_CMAKE_RESULT
80-
OUTPUT_VARIABLE DXC_CMAKE_STREAM_PIPE
81-
)
82-
83-
execute_process(COMMAND "${CMAKE_COMMAND}"
84-
-S "${CMAKE_CURRENT_SOURCE_DIR}/dxc"
85-
-C "${CMAKE_CURRENT_SOURCE_DIR}/dxc/cmake/caches/PredefinedParams.cmake"
86-
-G "${CMAKE_GENERATOR}"
87-
-T "${CMAKE_GENERATOR_TOOLSET}"
88-
-B "${DXC_BUILD_DIR}"
89-
-D "CMAKE_BUILD_TYPE:STRING=Release"
90-
RESULT_VARIABLE DXC_CMAKE_RESULT
91-
OUTPUT_VARIABLE DXC_CMAKE_STREAM_PIPE
92-
)
70+
execute_process(COMMAND "${CMAKE_COMMAND}"
71+
-S "${CMAKE_CURRENT_SOURCE_DIR}/dxc"
72+
-C "${CMAKE_CURRENT_SOURCE_DIR}/dxc/cmake/caches/PredefinedParams.cmake"
73+
-G "${CMAKE_GENERATOR}"
74+
-T "${CMAKE_GENERATOR_TOOLSET}"
75+
-B "${DXC_BUILD_DIR}"
76+
-D "CMAKE_BUILD_TYPE:STRING=${CMAKE_BUILD_TYPE}"
77+
RESULT_VARIABLE DXC_CMAKE_RESULT
78+
OUTPUT_VARIABLE DXC_CMAKE_STREAM_PIPE
79+
)
9380
endif()
9481

95-
9682
if(NOT "${DXC_CMAKE_RESULT}" STREQUAL "0")
9783
message(FATAL_ERROR "${DXC_CMAKE_STREAM_PIPE}")
9884
endif()

0 commit comments

Comments
 (0)