Expose Synchronization Validation feature for APIConnection

Author: Erfan-Ahmadi

include/nbl/video/IAPIConnection.h

@@ -28,6 +28,17 @@ class NBL_API2 IAPIConnection : public core::IReferenceCounted
 
             // VK_LAYER_KHRONOS_validation (instance layer) 
             bool validations = false;
+                // VK_LAYER_KHRONOS_validation (instance extension) 
+                /* TODO: Possibly bring in all as Validation extensions enum
+                typedef enum VkValidationFeatureEnableEXT {
+                    VK_VALIDATION_FEATURE_ENABLE_GPU_ASSISTED_EXT = 0,
+                    VK_VALIDATION_FEATURE_ENABLE_GPU_ASSISTED_RESERVE_BINDING_SLOT_EXT = 1,
+                    VK_VALIDATION_FEATURE_ENABLE_BEST_PRACTICES_EXT = 2,
+                    VK_VALIDATION_FEATURE_ENABLE_DEBUG_PRINTF_EXT = 3,
+                    VK_VALIDATION_FEATURE_ENABLE_SYNCHRONIZATION_VALIDATION_EXT = 4,
+                } VkValidationFeatureEnableEXT;
+                */
+                bool synchronizationValidation = false;
 
             // VK_EXT_debug_utils
             // When combined with validation layers, even more detailed feedback on the application�s use of Vulkan will be provided.

src/nbl/video/CVulkanConnection.cpp

@@ -138,7 +138,11 @@ namespace nbl::video
         };
 
 
-        if(featuresToEnable.debugUtils)
+        if(featuresToEnable.synchronizationValidation /* || other flags taht require VK_EXT_VALIDATION_FEATURES_EXTENSION_NAME */)
+        {
+            insertToFeatureSetIfAvailable(VK_EXT_VALIDATION_FEATURES_EXTENSION_NAME, "synchronizationValidation");
+        }
+        if (featuresToEnable.debugUtils)
         {
             insertToFeatureSetIfAvailable(VK_EXT_DEBUG_UTILS_EXTENSION_NAME, "debugUtils");
         }
@@ -161,6 +165,31 @@ namespace nbl::video
         if(!allRequestedFeaturesSupported)
             return nullptr;
 
+
+        VkBaseInStructure* structsTail = nullptr;
+        VkBaseInStructure* structsHead = nullptr;
+        // Vulkan has problems with having features in the feature chain that have all values set to false.
+        // For example having an empty "RayTracingPipelineFeaturesKHR" in the chain will lead to validation errors for RayQueryONLY applications.
+        auto addStructToChain = [&structsHead, &structsTail](void* feature) -> void
+        {
+            VkBaseInStructure* toAdd = reinterpret_cast<VkBaseInStructure*>(feature);
+
+            // For protecting against duplication of feature structures that may be requested to add to chain twice due to extension requirements
+            const bool alreadyAdded = (toAdd->pNext != nullptr || toAdd == structsTail);
+
+            if (structsHead == nullptr)
+            {
+                structsHead = toAdd;
+                structsTail = toAdd;
+            }
+            else if (!alreadyAdded)
+            {
+                structsTail->pNext = toAdd;
+                structsTail = toAdd;
+            }
+        };
+
+
         std::unique_ptr<CVulkanDebugCallback> debugCallback = nullptr;
         VkDebugUtilsMessengerCreateInfoEXT debugMessengerCreateInfo = { VK_STRUCTURE_TYPE_DEBUG_UTILS_MESSENGER_CREATE_INFO_EXT };
         if (logger && enabledFeatures.debugUtils)
@@ -175,6 +204,21 @@ namespace nbl::video
             debugMessengerCreateInfo.messageType = debugCallbackFlags.second;
             debugMessengerCreateInfo.pfnUserCallback = CVulkanDebugCallback::defaultCallback;
             debugMessengerCreateInfo.pUserData = debugCallback.get();
+
+            addStructToChain(&debugMessengerCreateInfo);
+        }
+
+        VkValidationFeaturesEXT validationFeaturesEXT = { VK_STRUCTURE_TYPE_VALIDATION_FEATURES_EXT };
+        VkValidationFeatureEnableEXT validationsEnable[16u] = {};
+        VkValidationFeatureDisableEXT validationsDisable[16u] = {};
+        validationFeaturesEXT.pEnabledValidationFeatures = validationsEnable;
+
+        // TODO: Do the samefor other validation features as well(?)
+        if (enabledFeatures.synchronizationValidation)
+        {
+            validationsEnable[validationFeaturesEXT.enabledValidationFeatureCount] = VK_VALIDATION_FEATURE_ENABLE_SYNCHRONIZATION_VALIDATION_EXT;
+            validationFeaturesEXT.enabledValidationFeatureCount += 1u;
+            addStructToChain(&validationFeaturesEXT);
         }
 
         uint32_t instanceApiVersion = MinimumVulkanApiVersion;
@@ -196,7 +240,7 @@ namespace nbl::video
             applicationInfo.engineVersion = NABLA_VERSION_INTEGER;
 
             VkInstanceCreateInfo createInfo = { VK_STRUCTURE_TYPE_INSTANCE_CREATE_INFO };
-            createInfo.pNext = enabledFeatures.debugUtils ? (VkDebugUtilsMessengerCreateInfoEXT*)&debugMessengerCreateInfo : nullptr;
+            createInfo.pNext = structsHead;
             createInfo.flags = static_cast<VkInstanceCreateFlags>(0);
             createInfo.pApplicationInfo = &applicationInfo;
             createInfo.enabledLayerCount = requiredLayerNameCount;