You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: include/nbl/ext/ImGui/ImGui.h
+3Lines changed: 3 additions & 0 deletions
Original file line number
Diff line number
Diff line change
@@ -151,6 +151,9 @@ class UI final : public core::IReferenceCounted
151
151
//! creates default pipeline layout for the UI resources, "texturesCount" argument is textures descriptor binding's array size. Samplers are immutable and part of the created layout, SResourceParameters::DefaultSamplerIx::COUNT is the size of the samplers descriptor binding's array
auto archive = make_smart_refctd_ptr<nbl::ext::imgui::builtin::CArchive>(smart_refctd_ptr<system::ILogger>(creationParams.utilities->getLogger())); //! we should never assume user will mount our internal archive since its the extension and not user's job to do it, hence we mount only to compile our extension sources then unmount the archive
140
-
auto compiler = make_smart_refctd_ptr<CHLSLCompiler>(smart_refctd_ptr(system)); //! note we are out of default logical device's compiler set scope so also a few special steps are required to compile our extension shaders to SPIRV
152
+
//! note we are out of default logical device's compiler set scope so also a few special steps are required to compile our extension shaders to SPIRV
153
+
auto compiler = make_smart_refctd_ptr<CHLSLCompiler>(smart_refctd_ptr(system));
141
154
auto includeFinder = make_smart_refctd_ptr<IShaderCompiler::CIncludeFinder>(smart_refctd_ptr(system));
142
155
auto includeLoader = includeFinder->getDefaultFileSystemLoader();
//! we assume user has all Nabla builtins mounted - we don't check it at release
236
+
assert(system->areBuiltinsMounted());
237
+
238
+
//! but we should never assume user will mount our internal archive since its the extension and not user's job to do it, hence we mount ourselves temporary archive to compile our extension sources then unmount it
239
+
auto archive = mount(smart_refctd_ptr<system::ILogger>(creationParams.utilities->getLogger()), system.get(), NBL_ARCHIVE_ALIAS.data());
0 commit comments