Skip to content

Commit a10ab3d

Browse files
author
devsh
committed
Merge remote-tracking branch 'origin/asset-conversion-v3'
2 parents 3128217 + cca06a5 commit a10ab3d

File tree

3 files changed

+2
-43
lines changed

3 files changed

+2
-43
lines changed

include/nbl/video/IGPUDescriptorSet.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -169,6 +169,7 @@ class IGPUDescriptorSet : public asset::IDescriptorSet<const IGPUDescriptorSetLa
169169
return samplers + localOffset;
170170
}
171171

172+
friend class CAssetConverter; // need this for `convert` checking deps
172173
inline core::smart_refctd_ptr<asset::IDescriptor>* getAllDescriptors(const asset::IDescriptor::E_TYPE type) const
173174
{
174175
auto* baseAddress = m_pool->getDescriptorStorage(type);

include/nbl/video/utilities/IGPUObjectFromAssetConverter.h

Lines changed: 0 additions & 42 deletions
Original file line numberDiff line numberDiff line change
@@ -437,29 +437,6 @@ auto IGPUObjectFromAssetConverter::create(const asset::ICPUImage** const _begin,
437437

438438
return res;
439439
}
440-
441-
auto IGPUObjectFromAssetConverter::create(const asset::ICPUBufferView** const _begin, const asset::ICPUBufferView** const _end, SParams& _params) -> created_gpu_object_array<asset::ICPUBufferView>
442-
{
443-
const auto assetCount = std::distance(_begin, _end);
444-
auto res = core::make_refctd_dynamic_array<created_gpu_object_array<asset::ICPUBufferView> >(assetCount);
445-
446-
core::vector<const asset::ICPUBuffer*> cpuBufs(assetCount, nullptr);
447-
for (ptrdiff_t i = 0u; i < assetCount; ++i)
448-
cpuBufs[i] = _begin[i]->getUnderlyingBuffer();
449-
450-
core::vector<size_t> redirs = eliminateDuplicatesAndGenRedirs(cpuBufs);
451-
auto gpuBufs = getGPUObjectsFromAssets<asset::ICPUBuffer>(cpuBufs.data(), cpuBufs.data()+cpuBufs.size(), _params);
452-
453-
for (ptrdiff_t i = 0u; i < assetCount; ++i)
454-
{
455-
const asset::ICPUBufferView* cpubufview = _begin[i];
456-
IGPUOffsetBufferPair* gpubuf = (*gpuBufs)[redirs[i]].get();
457-
(*res)[i] = _params.device->createBufferView(gpubuf->getBuffer(), cpubufview->getFormat(), gpubuf->getOffset() + cpubufview->getOffsetInBuffer(), cpubufview->getByteSize());;
458-
}
459-
460-
return res;
461-
}
462-
463440
inline created_gpu_object_array<asset::ICPUImageView> IGPUObjectFromAssetConverter::create(const asset::ICPUImageView** const _begin, const asset::ICPUImageView** const _end, SParams& _params)
464441
{
465442
const auto assetCount = std::distance(_begin, _end);
@@ -531,25 +508,6 @@ inline created_gpu_object_array<asset::ICPUImageView> IGPUObjectFromAssetConvert
531508

532509
inline created_gpu_object_array<asset::ICPUDescriptorSet> IGPUObjectFromAssetConverter::create(const asset::ICPUDescriptorSet** const _begin, const asset::ICPUDescriptorSet** const _end, SParams& _params)
533510
{
534-
if (isBufferDesc(type))
535-
{
536-
auto cpuBuf = static_cast<asset::ICPUBuffer*>(descriptor);
537-
if (type == asset::IDescriptor::E_TYPE::ET_UNIFORM_BUFFER || type == asset::IDescriptor::E_TYPE::ET_UNIFORM_BUFFER_DYNAMIC)
538-
cpuBuf->addUsageFlags(asset::IBuffer::EUF_UNIFORM_BUFFER_BIT);
539-
else if (type == asset::IDescriptor::E_TYPE::ET_STORAGE_BUFFER || type == asset::IDescriptor::E_TYPE::ET_STORAGE_BUFFER_DYNAMIC)
540-
cpuBuf->addUsageFlags(asset::IBuffer::EUF_STORAGE_BUFFER_BIT);
541-
cpuBuffers.push_back(cpuBuf);
542-
}
543-
else if (isBufviewDesc(type))
544-
{
545-
auto cpuBufView = static_cast<asset::ICPUBufferView*>(descriptor);
546-
auto cpuBuf = cpuBufView->getUnderlyingBuffer();
547-
if (cpuBuf && type == asset::IDescriptor::E_TYPE::ET_UNIFORM_TEXEL_BUFFER)
548-
cpuBuf->addUsageFlags(asset::IBuffer::EUF_UNIFORM_TEXEL_BUFFER_BIT);
549-
else if (cpuBuf && type == asset::IDescriptor::E_TYPE::ET_STORAGE_TEXEL_BUFFER)
550-
cpuBuf->addUsageFlags(asset::IBuffer::EUF_STORAGE_TEXEL_BUFFER_BIT);
551-
cpuBufviews.push_back(cpuBufView);
552-
}
553511
else if (isSampledImgViewDesc(type))
554512
{
555513
auto cpuImgView = static_cast<asset::ICPUImageView*>(descriptor);

0 commit comments

Comments
 (0)