add span versions of setScissor and setViewport, and deprecate non-span versions

Also nice defaults for Framebuffer creation params

Author: devshgraphicsprogramming

include/nbl/asset/IFramebuffer.h

@@ -19,11 +19,11 @@ class IFramebuffer
             using attachment_ptr_t = std::conditional_t<Creation,ImageViewType*const *,core::smart_refctd_ptr<ImageViewType>*>;
 
             core::smart_refctd_ptr<renderpass_t> renderpass;
-            attachment_ptr_t depthStencilAttachments;
-            attachment_ptr_t colorAttachments;
+            attachment_ptr_t depthStencilAttachments = nullptr;
+            attachment_ptr_t colorAttachments = nullptr;
             uint32_t width;
             uint32_t height;
-            uint32_t layers;
+            uint32_t layers = 1;
         };
         struct SCreationParams : SCreationParamsBase<true>
         {

include/nbl/video/IGPUCommandBuffer.h

@@ -301,30 +301,39 @@ class NBL_API2 IGPUCommandBuffer : public IBackendObject
         bool bindIndexBuffer(const asset::SBufferBinding<const IGPUBuffer>& binding, const asset::E_INDEX_TYPE indexType);
 
         //! dynamic state
-        inline bool setScissor(const uint32_t first, const uint32_t count, const VkRect2D* const pScissors)
+        inline bool setScissor(const uint32_t first, const std::span<const VkRect2D> scissors)
         {
+            const uint32_t count = scissors.size();
             if(invalidDynamic(first,count))
                 return false;
 
-            for (auto i=0u; i<count; i++)
+            for (const auto& scissor : scissors)
             {
-                const auto& scissor = pScissors[i];
                 if (scissor.offset.x<0 || scissor.offset.y<0)
                     return false;
-                if (pScissors[i].extent.width>std::numeric_limits<int32_t>::max()-scissor.offset.x)
+                if (scissor.extent.width>std::numeric_limits<int32_t>::max()-scissor.offset.x)
                     return false;
-                if (pScissors[i].extent.height>std::numeric_limits<int32_t>::max()-scissor.offset.y)
+                if (scissor.extent.height>std::numeric_limits<int32_t>::max()-scissor.offset.y)
                     return false;
             }
 
-            return setScissor_impl(first,count,pScissors);
+            return setScissor_impl(first,count,scissors.data());
         }
-        inline bool setViewport(const uint32_t first, const uint32_t count, const asset::SViewport* const pViewports)
+        [[deprecated]] inline bool setScissor(const uint32_t first, const uint32_t count, const VkRect2D* const pScissors)
         {
+            return setScissor(first,{pScissors,count});
+        }
+        inline bool setViewport(const uint32_t first, const std::span<const asset::SViewport> viewports)
+        {
+            const uint32_t count = viewports.size();
             if (invalidDynamic(first,count))
                 return false;
 
-            return setViewport_impl(first,count,pViewports);
+            return setViewport_impl(first,count,viewports.data());
+        }
+        [[deprecated]] inline bool setViewport(const uint32_t first, const uint32_t count, const asset::SViewport* const pViewports)
+        {
+            return setViewport(first,{pViewports,count});
         }
         bool setLineWidth(const float width);
         inline bool setDepthBias(const float depthBiasConstantFactor, const float depthBiasClamp, const float depthBiasSlopeFactor)