in thre interest of thread safety we should not have default manipulator or geometry generator because of the quant cache non-thread-safety

Author: devsh

include/nbl/asset/IAssetManager.h

@@ -113,8 +113,6 @@ class NBL_API2 IAssetManager : public core::IReferenceCounted
         friend class IAssetLoader;
         friend class IAssetLoader::IAssetLoaderOverride; // for access to non-const findAssets
 
-        core::smart_refctd_ptr<CGeometryCreator> m_geometryCreator;
-        core::smart_refctd_ptr<CPolygonGeometryManipulator> m_meshManipulator;
         core::smart_refctd_ptr<CCompilerSet> m_compilerSet;
         // called as a part of constructor only
         void initializeMeshTools();

include/nbl/asset/utils/CDirQuantCacheBase.h

@@ -244,7 +244,7 @@ struct CDirQuantCacheBase::value_type<EF_R16G16B16A16_SNORM>
 
 
 template<typename Key, class Hash, E_FORMAT... Formats>
-class CDirQuantCacheBase : public impl::CDirQuantCacheBase
+class CDirQuantCacheBase : public virtual core::IReferenceCounted, public impl::CDirQuantCacheBase
 { 
 	public:
 		template<E_FORMAT CacheFormat>

include/nbl/asset/utils/CGeometryCreator.h

@@ -19,12 +19,14 @@ namespace nbl::asset
 /** You can get an instance of this class through ISceneManager::getGeometryCreator() */
 class CGeometryCreator final : public core::IReferenceCounted
 {
-		core::smart_refctd_ptr<CPolygonGeometryManipulator> m_defaultPolygonManipulator;
+		core::smart_refctd_ptr<CQuantNormalCache> m_normalCache;
+		core::smart_refctd_ptr<CQuantQuaternionCache> m_quaternionCache;
 
 	public:
-		inline CGeometryCreator(core::smart_refctd_ptr<CPolygonGeometryManipulator> _defaultPolygonManipulator) : m_defaultPolygonManipulator(std::move(_defaultPolygonManipulator))
+		inline CGeometryCreator(core::smart_refctd_ptr<CQuantNormalCache>&& _normalCache, core::smart_refctd_ptr<CQuantQuaternionCache>&& _quaternionCache)
+			: m_normalCache(std::move(_normalCache)), m_quaternionCache(std::move(_quaternionCache))
 		{
-			assert(m_defaultPolygonManipulator);
+			assert(m_normalCache && m_quaternionCache);
 		}
 
 		//! Creates a simple cube mesh.

include/nbl/asset/utils/CPolygonGeometryManipulator.h

@@ -560,11 +560,6 @@ class NBL_API2 CPolygonGeometryManipulator
 			}
 		}
 #endif
-
-
-		//!
-		virtual CQuantNormalCache* getQuantNormalCache() = 0;
-		virtual CQuantQuaternionCache* getQuantQuaternionCache() = 0;
 };
 
 #if 0

src/nbl/asset/IAssetManager.cpp

@@ -114,22 +114,10 @@ std::function<void(SAssetBundle&)> nbl::asset::makeAssetDisposeFunc(const IAsset
 
 void IAssetManager::initializeMeshTools()
 {
-	m_meshManipulator = core::make_smart_refctd_ptr<CMeshManipulator>();
-    m_geometryCreator = core::make_smart_refctd_ptr<CGeometryCreator>(m_meshManipulator.get());
     if (!m_compilerSet)
         m_compilerSet = core::make_smart_refctd_ptr<CCompilerSet>(core::smart_refctd_ptr(m_system));
 }
 
-const CGeometryCreator* IAssetManager::getGeometryCreator() const
-{
-	return m_geometryCreator.get();
-}
-
-CPolygonGeometryManipulator* IAssetManager::getMeshManipulator()
-{
-	return m_meshManipulator.get();
-}
-
 void IAssetManager::addLoadersAndWriters()
 {
 #ifdef _NBL_COMPILE_WITH_STL_LOADER_
@@ -200,8 +188,6 @@ void IAssetManager::addLoadersAndWriters()
 SAssetBundle IAssetManager::getAssetInHierarchy_impl(system::IFile* _file, const std::string& _supposedFilename, const IAssetLoader::SAssetLoadParams& _params, uint32_t _hierarchyLevel, IAssetLoader::IAssetLoaderOverride* _override)
 {
     IAssetLoader::SAssetLoadParams params(_params);
-    if (params.meshManipulatorOverride == nullptr)
-        params.meshManipulatorOverride = m_meshManipulator.get();
 
     IAssetLoader::SAssetLoadContext ctx{params,_file};