Skip to content

Commit 7c9ab31

Browse files
some TODOs, also correct the size of an array in ISwapchain
1 parent c146f33 commit 7c9ab31

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

include/nbl/asset/IImage.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ class IImage : public IDescriptor
8282
ECF_SPARSE_RESIDENCY_BIT = 0x1u << 1u,
8383
ECF_SPARSE_ALIASED_BIT = 0x1u << 2u,
8484
//! if you want to be able to create an ImageView with a different format later
85-
ECF_MUTABLE_FORMAT_BIT = 0x1u << 3u,
85+
ECF_MUTABLE_FORMAT_BIT = 0x1u << 3u, // TODO: deduce this anyway
8686
//! whether can fashion a cubemap out of the image
8787
ECF_CUBE_COMPATIBLE_BIT = 0x1u << 4u,
8888
//! whether can fashion a 2d array texture out of the image
@@ -91,9 +91,9 @@ class IImage : public IDescriptor
9191
ECF_SPLIT_INSTANCE_BIND_REGIONS_BIT = 0x1u << 6u,
9292
//! whether can view a block compressed texture as uncompressed
9393
// (1 block size must equal 1 uncompressed pixel size)
94-
ECF_BLOCK_TEXEL_VIEW_COMPATIBLE_BIT = 0x1u << 7u,
94+
ECF_BLOCK_TEXEL_VIEW_COMPATIBLE_BIT = 0x1u << 7u, // TODO: deduce this anyway
9595
//! can create with flags not supported by primary image but by a potential compatible view
96-
ECF_EXTENDED_USAGE_BIT = 0x1u << 8u,
96+
ECF_EXTENDED_USAGE_BIT = 0x1u << 8u, // TODO: deduce this anyway
9797
//! irrelevant now - no support for planar images
9898
ECF_DISJOINT_BIT = 0x1u << 9u,
9999
//! irrelevant now - two `IGPUImage`s backing memory can overlap

include/nbl/video/ISwapchain.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -558,7 +558,7 @@ class ISwapchain : public IBackendObject
558558
const uint8_t m_imageCount;
559559
uint64_t m_acquireCounter = 0;
560560
// Resources to hold onto until a frame is done rendering (between; just before presenting, and next acquire of the same image index)
561-
std::array<std::unique_ptr<MultiTimelineEventHandlerST<DeferredFrameResourceDrop>>,ILogicalDevice::MaxQueueFamilies> m_frameResources;
561+
std::array<std::unique_ptr<MultiTimelineEventHandlerST<DeferredFrameResourceDrop>>,MaxImages> m_frameResources;
562562
};
563563

564564
}

0 commit comments

Comments
 (0)