Skip to content

Commit 782b6ba

Browse files
committed
request only python interpreter and correct its variable name, add more validation and fix bugs, set builtin resources library target CXX_STANDARD to 20
1 parent c110ce0 commit 782b6ba

File tree

2 files changed

+11
-10
lines changed

2 files changed

+11
-10
lines changed

src/nbl/builtin/CMakeLists.txt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
find_package (Python3 COMPONENTS Interpreter REQUIRED)
2+
13
include("${CMAKE_CURRENT_SOURCE_DIR}/utils.cmake")
24

35
LIST_BUILTIN_RESOURCE(NBL_RESOURCES_TO_EMBED "nbl/builtin/glsl/utils/acceleration_structures.glsl")

src/nbl/builtin/utils.cmake

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
find_package(Python3 REQUIRED)
2-
31
macro(LIST_BUILTIN_RESOURCE _BUNDLE_NAME_ _LBR_PATH_)
42
set(_OPTIONAL_ALIAS_ "${ARGV2}")
53

@@ -11,6 +9,10 @@ macro(LIST_BUILTIN_RESOURCE _BUNDLE_NAME_ _LBR_PATH_)
119
endmacro()
1210

1311
function(ADD_CUSTOM_BUILTIN_RESOURCES _TARGET_NAME_ _BUNDLE_NAME_ _BUNDLE_SEARCH_DIRECTORY_ _NAMESPACE_ _OUTPUT_DIRECTORY_)
12+
if(NOT DEFINED Python3_EXECUTABLE)
13+
message(FATAL_ERROR "Python3_EXECUTABLE must be defined!")
14+
endif()
15+
1416
file(MAKE_DIRECTORY "${_OUTPUT_DIRECTORY_}")
1517

1618
set(NBL_TEMPLATE_APK_RESOURCES_ARCHIVE_HEADER "${CMAKE_CURRENT_FUNCTION_LIST_DIR}/template/CArchive.h.in")
@@ -57,26 +59,23 @@ function(ADD_CUSTOM_BUILTIN_RESOURCES _TARGET_NAME_ _BUNDLE_NAME_ _BUNDLE_SEARCH
5759

5860
set(NBL_BUILTIN_RESOURCES_HEADER "${_OUTPUT_DIRECTORY_}/${NBL_BS_HEADER_FILENAME}")
5961
set(NBL_BUILTIN_RESOURCE_DATA_SOURCE "${_OUTPUT_DIRECTORY_}/${NBL_BS_DATA_SOURCE_FILENAME}")
60-
61-
set(_NBL_SOURCES_
62-
"${NBL_BUILTIN_RESOURCES_HEADER}"
63-
"${NBL_BUILTIN_RESOURCE_DATA_SOURCE}"
64-
)
6562

6663
add_custom_command(
6764
OUTPUT "${NBL_BUILTIN_RESOURCES_HEADER}" "${NBL_BUILTIN_RESOURCE_DATA_SOURCE}"
68-
COMMAND "${PYTHON_EXECUTABLE}" "${NBL_BUILTIN_HEADER_GEN_PY}" "${NBL_BUILTIN_RESOURCES_HEADER}" "${_BUNDLE_SEARCH_DIRECTORY_}" "${NBL_RESOURCES_LIST_FILE}" "${_NAMESPACE_}" "${_GUARD_SUFFIX_}"
69-
COMMAND "${PYTHON_EXECUTABLE}" "${NBL_BUILTIN_DATA_GEN_PY}" "${NBL_BUILTIN_RESOURCE_DATA_SOURCE}" "${_BUNDLE_SEARCH_DIRECTORY_}" "${NBL_RESOURCES_LIST_FILE}" "${_NAMESPACE_}" "${NBL_BS_HEADER_FILENAME}"
65+
COMMAND "${Python3_EXECUTABLE}" "${NBL_BUILTIN_HEADER_GEN_PY}" "${NBL_BUILTIN_RESOURCES_HEADER}" "${_BUNDLE_SEARCH_DIRECTORY_}" "${NBL_RESOURCES_LIST_FILE}" "${_NAMESPACE_}" "${_GUARD_SUFFIX_}"
66+
COMMAND "${Python3_EXECUTABLE}" "${NBL_BUILTIN_DATA_GEN_PY}" "${NBL_BUILTIN_RESOURCE_DATA_SOURCE}" "${_BUNDLE_SEARCH_DIRECTORY_}" "${NBL_RESOURCES_LIST_FILE}" "${_NAMESPACE_}" "${NBL_BS_HEADER_FILENAME}"
7067
COMMENT "Generating built-in resources"
7168
DEPENDS ${NBL_DEPENDENCY_FILES}
7269
VERBATIM
7370
)
7471

7572
add_library(${_TARGET_NAME_} STATIC
76-
${_NBL_SOURCES_}
73+
"${NBL_BUILTIN_RESOURCES_HEADER}"
74+
"${NBL_BUILTIN_RESOURCE_DATA_SOURCE}"
7775
)
7876

7977
target_include_directories(${_TARGET_NAME_} PUBLIC "${NBL_ROOT_PATH}/include")
78+
set_target_properties(${_TARGET_NAME_} PROPERTIES CXX_STANDARD 20)
8079

8180
if(NBL_DYNAMIC_MSVC_RUNTIME)
8281
set_property(TARGET ${_TARGET_NAME_} PROPERTY MSVC_RUNTIME_LIBRARY "MultiThreaded$<$<CONFIG:Debug>:Debug>DLL")

0 commit comments

Comments
 (0)