Explicitly turn off PCH for builtin resources (could inherit a setup causing it to generate another 500 MB .pch), do not link Nabla nor add it as dependency to builtin resources if not internal (old code bug causing extra dependency chain, they only need single Nabla headers to build)

Author: AnastaZIuk

cmake/common.cmake

@@ -966,11 +966,11 @@ endfunction()
 # @_BS_TARGET_@ is a builtin resource target
 
 function(LINK_BUILTIN_RESOURCES_TO_TARGET _TARGET_ _BS_TARGET_)
-	add_dependencies(${EXECUTABLE_NAME} ${_BS_TARGET_})
-	target_link_libraries(${EXECUTABLE_NAME} PUBLIC ${_BS_TARGET_})
+	add_dependencies(${_TARGET_} ${_BS_TARGET_})
+	target_link_libraries(${_TARGET_} PUBLIC ${_BS_TARGET_})
 
 	get_target_property(_BUILTIN_RESOURCES_INCLUDE_SEARCH_DIRECTORY_ ${_BS_TARGET_} BUILTIN_RESOURCES_INCLUDE_SEARCH_DIRECTORY)
-	target_include_directories(${EXECUTABLE_NAME} PUBLIC "${_BUILTIN_RESOURCES_INCLUDE_SEARCH_DIRECTORY_}")
+	target_include_directories(${_TARGET_} PUBLIC "${_BUILTIN_RESOURCES_INCLUDE_SEARCH_DIRECTORY_}")
 endfunction()
 
 macro(nbl_android_create_apk _TARGET)

src/nbl/builtin/utils.cmake

@@ -156,6 +156,10 @@ function(ADD_CUSTOM_BUILTIN_RESOURCES _TARGET_NAME_ _BUNDLE_NAME_ _BUNDLE_SEARCH
 		"${_OUTPUT_HEADER_DIRECTORY_}/CArchive.h"
 	)
 
+	set_target_properties(${_TARGET_NAME_} PROPERTIES
+        DISABLE_PRECOMPILE_HEADERS ON
+    )
+	
 	if(_LIB_TYPE_ STREQUAL SHARED)
 		target_compile_definitions(${_TARGET_NAME_} 
 			PRIVATE __NBL_BUILDING_TARGET__
@@ -168,10 +172,6 @@ function(ADD_CUSTOM_BUILTIN_RESOURCES _TARGET_NAME_ _BUNDLE_NAME_ _BUNDLE_SEARCH
 		if(NBL_STATIC_BUILD AND _LIB_TYPE_ STREQUAL SHARED)
 			message(FATAL_ERROR "Nabla must be built as dynamic library in order to combine this tool with SHARED setup!")
 		endif()
-		
-		if(NOT _NBL_INTERNAL_BR_CREATION_)
-			target_link_libraries(${_TARGET_NAME_} Nabla) # be aware Nabla must be linked to the BRs
-		endif()
 	endif()
 
 	if(NOT DEFINED _NABLA_INCLUDE_DIRECTORIES_) # TODO, validate by populating generator expressions if any and checking whether a path to the BuildConfigOptions.h exists per config