fix bad (reverse) implementation of checking validity of SDataView

Also set content hashes on Geometry Creator made ICPUBuffers

Author: devsh

examples_tests

@@ -122,6 +122,7 @@ class NBL_API2 ICPUPolygonGeometry final : public IPolygonGeometry<ICPUBuffer>
         }
 
         //
+        inline const core::vector<SJointWeight>& getJointWeightViews() const {return base_t::getJointWeightViews();}
         inline core::vector<SJointWeight>* getJointWeightViews()
         {
             if (isMutable())

include/nbl/asset/ICPUPolygonGeometry.h

@@ -66,7 +66,7 @@ class IGeometryBase : public virtual core::IReferenceCounted
         struct SDataViewBase
         {
             // mostly checking validity of the format
-            inline operator bool() const {return format==EF_UNKNOWN || isBlockCompressionFormat(format) && isDepthOrStencilFormat(format);}
+            inline operator bool() const {return format==EF_UNKNOWN || !isBlockCompressionFormat(format) && !isDepthOrStencilFormat(format);}
 
             //
             inline bool isFormatted() const {return format!=EF_UNKNOWN && bool(*this);}

include/nbl/asset/IGeometry.h

@@ -13,10 +13,47 @@
 
 namespace nbl::asset
 {
+
+// TODO: move to its own header!
+class NBL_API2 CGeometryManipulator
+{
+	public:
+		static inline void recomputeContentHash(const IGeometry<ICPUBuffer>::SDataView& view)
+		{
+			if (!view)
+				return;
+			view.src.buffer->setContentHash(view.src.buffer->computeContentHash());
+		}
+
+		// TODO: static inline IGeometryBase::SDataViewBase::SAABBStorage computeRange(const IGeometry<ICPUBuffer>::SDataView& view)
+
+		// TODO: static inline void recomputeRange(IGeometry<ICPUBuffer>::SDataView& view)
+};
+
 //! An interface for easy manipulation of polygon geometries.
 class NBL_API2 CPolygonGeometryManipulator
 {
 	public:
+		static inline void recomputeContentHashes(ICPUPolygonGeometry* geo)
+		{
+			if (!geo)
+				return;
+			CGeometryManipulator::recomputeContentHash(geo->getPositionView());
+			CGeometryManipulator::recomputeContentHash(geo->getIndexView());
+			CGeometryManipulator::recomputeContentHash(geo->getNormalView());
+			for (const auto& view : *geo->getJointWeightViews())
+			{
+				CGeometryManipulator::recomputeContentHash(view.indices);
+				CGeometryManipulator::recomputeContentHash(view.weights);
+			}
+			if (auto pView=geo->getJointOBBView(); pView)
+				CGeometryManipulator::recomputeContentHash(*pView);
+			for (const auto& view : *geo->getAuxAttributeViews())
+				CGeometryManipulator::recomputeContentHash(view);
+		}
+
+		// TODO: recomputeRanges
+
 		//! Comparison methods
 		enum E_ERROR_METRIC
 		{

include/nbl/asset/utils/CPolygonGeometryManipulator.h

@@ -182,6 +182,7 @@ core::smart_refctd_ptr<ICPUPolygonGeometry> CGeometryCreator::createCube(const h
 		}
 	}
 
+	CPolygonGeometryManipulator::recomputeContentHashes(retval.get());
 	return retval;
 }
 
@@ -751,6 +752,7 @@ core::smart_refctd_ptr<ICPUPolygonGeometry> CGeometryCreator::createRectangle(co
 		}
 	}
 
+	CPolygonGeometryManipulator::recomputeContentHashes(retval.get());
 	return retval;
 }
 
@@ -847,6 +849,7 @@ core::smart_refctd_ptr<ICPUPolygonGeometry> CGeometryCreator::createDisk(const f
 	}
 	std::fill_n(normals,vertexCount,hlsl::vector<int8_t,4>(0,0,127,0));
 
+	CPolygonGeometryManipulator::recomputeContentHashes(retval.get());
 	return retval;
 }