Skip to content

Commit 64ad91a

Browse files
committed
Merge branch 'master' into ngfx-sdk-integration
2 parents f3c777e + c7bdd2a commit 64ad91a

File tree

79 files changed

+1113
-331
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

79 files changed

+1113
-331
lines changed

3rdparty/CMakeLists.txt

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -161,11 +161,6 @@ target_include_directories(SPIRV PUBLIC "${GLSLANG_GENERATED_INCLUDEDIR}")
161161
set(SHADERC_SKIP_TESTS ON CACHE INTERNAL "Skip shaderc tests?")
162162
set(SHADERC_SKIP_INSTALL ON CACHE INTERNAL "Install shaderc?")
163163

164-
# if it doesn't work without the `touch` on Linux, then fetch the latest submodule head of shaderc and try again
165-
# https://github.com/google/shaderc/issues/568
166-
if (UNIX)
167-
file(WRITE ${THIRD_PARTY_SOURCE_DIR}/shaderc/libshaderc/libshaderc_combined.a "")
168-
endif()
169164
add_subdirectory(shaderc shaderc EXCLUDE_FROM_ALL)
170165

171166
# libjpeg-turbo
@@ -474,7 +469,6 @@ set(NBL_3RDPARTY_TARGETS
474469
simdjson
475470
nlohmann_json
476471
glslang
477-
OGLCompiler
478472
OSDependent
479473
MachineIndependent
480474
GenericCodeGen
@@ -500,9 +494,6 @@ endif()
500494
if (NBL_BUILD_IMGUI)
501495
list(APPEND NBL_3RDPARTY_TARGETS imgui implot imtestsuite imtestengine imguizmo)
502496
endif()
503-
if(ENABLE_HLSL)
504-
list(APPEND NBL_3RDPARTY_TARGETS HLSL)
505-
endif()
506497

507498
foreach(trgt IN LISTS NBL_3RDPARTY_TARGETS)
508499
if(NBL_DYNAMIC_MSVC_RUNTIME)

3rdparty/Vulkan-Headers

Submodule Vulkan-Headers updated 84 files

3rdparty/glslang

3rdparty/shaderc

Submodule shaderc updated 76 files

cmake/adjust/template/windows/msvc.cmake

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,8 @@ if(NBL_REQUEST_SSE_AXV2)
1212
NBL_REQUEST_COMPILE_OPTION_SUPPORT("/arch:AVX2")
1313
endif()
1414

15+
NBL_REQUEST_COMPILE_OPTION_SUPPORT(/Zc:preprocessor)
16+
1517
# Debug
1618
set(NBL_C_DEBUG_COMPILE_OPTIONS
1719
/Ob0 /Od /MP${_NBL_JOBS_AMOUNT_} /fp:fast /Zc:wchar_t /INCREMENTAL

include/nbl/application_templates/MonoDeviceApplication.hpp

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -203,16 +203,11 @@ class MonoDeviceApplication : public virtual MonoSystemMonoLoggerApplication
203203
}
204204

205205
// These features are features you'll enable if present but won't interfere with your choice of device
206-
// There's no intersection operator (yet) on the features, so its not used yet!
207206
// virtual function so you can override as needed for some example father down the line
208207
virtual video::SPhysicalDeviceFeatures getPreferredDeviceFeatures() const
209208
{
210209
video::SPhysicalDeviceFeatures retval = {};
211210

212-
/*retval.shaderFloat64 = true;
213-
retval.shaderDrawParameters = true;
214-
retval.drawIndirectCount = true;*/
215-
216211
return retval;
217212
}
218213

include/nbl/asset/ICPUBuffer.h

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,10 +27,9 @@ class ICPUBuffer final : public asset::IBuffer, public IPreHashed
2727
public:
2828
struct SCreationParams : asset::IBuffer::SCreationParams
2929
{
30-
size_t size;
3130
void* data = nullptr;
32-
size_t alignment = _NBL_SIMD_ALIGNMENT;
3331
core::smart_refctd_ptr<core::refctd_memory_resource> memoryResource = nullptr;
32+
size_t alignment = _NBL_SIMD_ALIGNMENT;
3433

3534
SCreationParams& operator =(const asset::IBuffer::SCreationParams& rhs)
3635
{
@@ -67,7 +66,7 @@ class ICPUBuffer final : public asset::IBuffer, public IPreHashed
6766

6867
core::smart_refctd_ptr<IAsset> clone(uint32_t = ~0u) const override final
6968
{
70-
auto cp = create({ .size = m_creationParams.size, .data = m_data, .alignment = m_alignment });
69+
auto cp = create({ { m_creationParams.size }, m_data, nullptr, m_alignment });
7170
memcpy(cp->getPointer(), m_data, m_creationParams.size);
7271
cp->setContentHash(getContentHash());
7372
return cp;

include/nbl/asset/ICPUShader.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ class ICPUShader : public IAsset, public IShader
3333
: IShader(stage, std::move(filepathHint)), m_code(std::move(code)), m_contentType(contentType) {}
3434

3535
ICPUShader(const char* code, const E_SHADER_STAGE stage, const E_CONTENT_TYPE contentType, std::string&& filepathHint)
36-
: ICPUShader(ICPUBuffer::create({ .size = strlen(code) + 1u }), stage, contentType, std::move(filepathHint))
36+
: ICPUShader(ICPUBuffer::create({ strlen(code) + 1u }), stage, contentType, std::move(filepathHint))
3737
{
3838
assert(contentType != E_CONTENT_TYPE::ECT_SPIRV); // because using strlen needs `code` to be null-terminated
3939
memcpy(m_code->getPointer(), code, m_code->getSize());

0 commit comments

Comments
 (0)