Skip to content

Commit 41ffc50

Browse files
author
kevyuu
committed
Check for maxShaderGroupStride compliance
1 parent cc34962 commit 41ffc50

File tree

1 file changed

+8
-2
lines changed

1 file changed

+8
-2
lines changed

src/nbl/video/IGPUCommandBuffer.cpp

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -736,14 +736,20 @@ bool IGPUCommandBuffer::invalidShaderGroups(
736736
// https://registry.khronos.org/vulkan/specs/latest/man/html/vkCmdTraceRaysKHR.html#VUID-vkCmdTraceRaysKHR-pRayGenShaderBindingTable-03689
737737
if (range.offset % limits.shaderGroupBaseAlignment != 0)
738738
{
739-
NBL_LOG_ERROR("%s buffer offset must be multiple of %u!", limits.shaderGroupBaseAlignment);
739+
NBL_LOG_ERROR("%s buffer offset must be multiple of %u!", groupName, limits.shaderGroupBaseAlignment);
740740
return true;
741741
}
742742

743743
// https://registry.khronos.org/vulkan/specs/latest/man/html/vkCmdTraceRaysKHR.html#VUID-vkCmdTraceRaysKHR-pHitShaderBindingTable-03690
744744
if (stride % limits.shaderGroupHandleAlignment)
745745
{
746-
NBL_LOG_ERROR("%s buffer offset must be multiple of %u!", limits.shaderGroupHandleAlignment);
746+
NBL_LOG_ERROR("%s buffer offset must be multiple of %u!", groupName, limits.shaderGroupHandleAlignment);
747+
return true;
748+
}
749+
750+
if (stride > limits.maxShaderGroupStride)
751+
{
752+
NBL_LOG_ERROR("%s buffer stride must not exceed %u!", groupName, limits.shaderGroupHandleAlignment);
747753
return true;
748754
}
749755

0 commit comments

Comments
 (0)