Skip to content

Commit 3d753f5

Browse files
committed
correct all issues & compile errors regarding builtin resources targets, perform tests and make it works with aliases. Have default abs path for archive entry generated by CMake, rstrip each python string and have declaration of an explicit template specialization in bs header. Update examples_tests submodule
1 parent 78f8bfa commit 3d753f5

File tree

5 files changed

+21
-20
lines changed

5 files changed

+21
-20
lines changed

src/nbl/builtin/builtinDataGen.py

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,9 @@
1919
resourcesNamespace = sys.argv[4]
2020
correspondingHeaderFile = sys.argv[5]
2121

22-
with open(resourcesFile, "r") as f:
23-
resourcePaths = f.read().rstrip().readlines()
24-
22+
file = open(resourcesFile, 'r')
23+
resourcePaths = file.readlines()
24+
2525
#opening a file
2626
outp = open(outputFilename,"w+")
2727

@@ -34,7 +34,7 @@
3434
# writing binary data of all files in a loop
3535
for z in resourcePaths:
3636
itemData = z.split(',')
37-
x = itemData[0]
37+
x = itemData[0].rstrip()
3838

3939
outp.write('\n\ttemplate<> const std::pair<const uint8_t*, size_t> get_resource<NBL_CORE_UNIQUE_STRING_LITERAL_TYPE("%s")>()' % x)
4040
outp.write('\n\t{')
@@ -58,28 +58,28 @@
5858

5959
outp.write('\n\t\t};')
6060
outp.write('\n\t\treturn { data, sizeof(data) };')
61-
outp.write('\n\t}')
61+
outp.write('\n\t}\n')
6262

6363
if len(itemData) > 1:
64-
for alias in range(1, len(itemData)):
65-
outp.write('\n\ttemplate<> const std::pair<const uint8_t*, size_t> get_resource<NBL_CORE_UNIQUE_STRING_LITERAL_TYPE("%s")>()' % alias)
64+
for i in range(1, len(itemData)):
65+
outp.write('\n\ttemplate<> const std::pair<const uint8_t*, size_t> get_resource<NBL_CORE_UNIQUE_STRING_LITERAL_TYPE("%s")>()' % itemData[i].rstrip())
6666
outp.write('\n\t{')
6767
outp.write('\n\t\treturn get_resource<NBL_CORE_UNIQUE_STRING_LITERAL_TYPE("%s")>();' % x)
68-
outp.write('\n\t{')
68+
outp.write('\n\t}\n')
6969

7070
outp.write("\tstd::pair<const uint8_t*, size_t> get_resource_runtime(const std::string& filename) {\n")
7171
outp.write("\t\tstatic std::unordered_map<std::string, int> resourcesByFilename( {\n")
7272
counter = 1
7373

7474
for z in resourcePaths:
7575
itemData = z.split(',')
76-
x = itemData[0]
76+
x = itemData[0].rstrip()
7777

7878
outp.write("\t\t\t{\"%s\", %d},\n" % (x,counter))
7979

8080
if len(itemData) > 1:
81-
for alias in range(1, len(itemData)):
82-
outp.write("\t\t\t{\"%s\", %d},\n" % (alias,counter))
81+
for i in range(1, len(itemData)):
82+
outp.write("\t\t\t{\"%s\", %d},\n" % (itemData[i].rstrip(),counter))
8383

8484
counter+= 1
8585

@@ -91,7 +91,7 @@
9191

9292
for z in resourcePaths:
9393
itemData = z.split(',')
94-
x = itemData[0]
94+
x = itemData[0].rstrip()
9595

9696
outp.write("\t\t\tcase %d:\n\t\t\t\t\treturn get_resource<NBL_CORE_UNIQUE_STRING_LITERAL_TYPE(\"%s\")>();\n" % (counter,x))
9797
counter+= 1

src/nbl/builtin/builtinHeaderGen.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,8 @@
1919
resourcesNamespace = sys.argv[4]
2020
guardSuffix = sys.argv[5]
2121

22-
with open(resourcesFile, "r") as f:
23-
resourcePaths = f.read().rstrip().readlines()
22+
file = open(resourcesFile, 'r')
23+
resourcePaths = file.readlines()
2424

2525
#opening a file
2626
outp = open(outputFilename,"w+")
@@ -39,13 +39,13 @@
3939
#Iterating through input list
4040
for z in resourcePaths:
4141
itemData = z.split(',')
42-
x = itemData[0]
42+
x = itemData[0].rstrip()
4343

44-
outp.write('\n\t\textern template const std::pair<const uint8_t*, size_t> get_resource<NBL_CORE_UNIQUE_STRING_LITERAL_TYPE("%s")>();' % x)
44+
outp.write('\n\t\ttemplate<> const std::pair<const uint8_t*, size_t> get_resource<NBL_CORE_UNIQUE_STRING_LITERAL_TYPE("%s")>();' % x)
4545

4646
if len(itemData) > 1:
47-
for alias in range(1, len(itemData)):
48-
outp.write('\n\t\textern template const std::pair<const uint8_t*, size_t> get_resource<NBL_CORE_UNIQUE_STRING_LITERAL_TYPE("%s")>();' % alias)
47+
for i in range(1, len(itemData)):
48+
outp.write('\n\t\ttemplate<> const std::pair<const uint8_t*, size_t> get_resource<NBL_CORE_UNIQUE_STRING_LITERAL_TYPE("%s")>();' % itemData[i].rstrip())
4949

5050
outp.write("\n\t}")
5151
outp.write("\n#endif // _" + guardSuffix + "_BUILTINRESOURCEDATA_H_")

src/nbl/builtin/template/CArchive.h.in

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ namespace @_NAMESPACE_@
1515
{
1616
public:
1717
inline CArchive(nbl::system::logger_opt_smart_ptr&& logger)
18-
: nbl::system::CFileArchive(nbl::system::path(pathPrefix.data()),std::move(logger), getItemList()) {}
18+
: nbl::system::CFileArchive(nbl::system::path("@_DEFAULT_ABSOLUTE_BUNDLE_SEARCH_DIRECTORY_@"),std::move(logger), getItemList()) {}
1919

2020
protected:
2121
file_buffer_t getFileBuffer(const nbl::system::IFileArchive::SListEntry* item) override

src/nbl/builtin/utils.cmake

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,7 @@ function(ADD_CUSTOM_BUILTIN_RESOURCES _TARGET_NAME_ _BUNDLE_NAME_ _BUNDLE_SEARCH
6969
unset(_ITEM_ALIASES_)
7070
endif()
7171

72+
set(_DEFAULT_ABSOLUTE_BUNDLE_SEARCH_DIRECTORY_ "${_BUNDLE_SEARCH_DIRECTORY_}")
7273
set(NBL_BUILTIN_RESOURCE_ABS_PATH "${_BUNDLE_SEARCH_DIRECTORY_}/${_CURRENT_PATH_}") # an absolute path to a builtin resource
7374
list(APPEND NBL_BUILTIN_RESOURCES "${NBL_BUILTIN_RESOURCE_ABS_PATH}")
7475

0 commit comments

Comments
 (0)