Skip to content

Commit 2716eca

Browse files
author
kevyuu
committed
More comment on passes
1 parent 6ec73f7 commit 2716eca

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

src/nbl/asset/utils/ISPIRVEntryPointTrimmer.cpp

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,13 +17,15 @@ ISPIRVEntryPointTrimmer::ISPIRVEntryPointTrimmer()
1717
ISPIRVOptimizer::EOP_ELIM_DEAD_FUNCTIONS,
1818
ISPIRVOptimizer::EOP_ELIM_DEAD_VARIABLES,
1919

20-
// This will remove spec constant as well
20+
// This will remove spec constant as well based on this doc
21+
// https://github.com/KhronosGroup/SPIRV-Tools/blob/dec28643ed15f68a2bc95650de25e0a7486b564c/include/spirv-tools/optimizer.hpp#L349
2122
ISPIRVOptimizer::EOP_ELIM_DEAD_CONSTANTS,
2223

2324
ISPIRVOptimizer::EOP_ELIM_DEAD_MEMBERS,
2425

25-
// Aggresive DCE to remove unused type
26+
// Based on experimentation, Aggresive DCE will remove unused type
2627
ISPIRVOptimizer::EOP_AGGRESSIVE_DCE,
28+
2729
ISPIRVOptimizer::EOP_TRIM_CAPABILITIES,
2830
};
2931
m_optimizer = core::make_smart_refctd_ptr<ISPIRVOptimizer>(std::span(optimizationPasses));

0 commit comments

Comments
 (0)