spot and fix a huge problem in calling a virtual method from a destructor

NOTE: https://www.artima.com/articles/never-call-virtual-functions-during-construction-or-destruction

Author: devshgraphicsprogramming

examples_tests

@@ -126,15 +126,17 @@ class NBL_API2 IGPUCommandBuffer :
 
     IGPUCommandBuffer(core::smart_refctd_ptr<const ILogicalDevice>&& dev, E_LEVEL lvl, core::smart_refctd_ptr<IGPUCommandPool>&& _cmdpool, system::logger_opt_smart_ptr&& logger) : base_t(lvl), IBackendObject(std::move(dev)), m_cmdpool(_cmdpool), m_logger(std::move(logger))
     {
+        // prevent false positives on first `begin()`
+        m_resetCheckedStamp = m_cmdpool->getResetCounter();
     }
 
-    virtual ~IGPUCommandBuffer()
+    // meant to be invoked by most derived class
+    // TODO: idea make a macro for overriding all `delete` operators of a class to enforce a finalizer that runs in reverse order to destructors (to allow polymorphic cleanups)
+    inline void out_of_order_dtor()
     {
         // Only release the resources if the parent pool has not been reset because if it has been then the resources will already be released.
         if (!checkForParentPoolReset())
-        {
             releaseResourcesBackToPool();
-        }
     }
 
     system::logger_opt_smart_ptr m_logger;
@@ -252,9 +254,7 @@ class NBL_API2 IGPUCommandBuffer :
         m_commandList.head = nullptr;
         m_commandList.tail = nullptr;
 
-        // Example 05 crashes here, with assert in `ucrt` maybe vtable gets lost or something?
-        // For now commented out because we only have a Vulkan backend and function doesn't do anything.
-        //checkForParentPoolReset_impl();
+        checkForParentPoolReset_impl();
 
         return true;
     }
@@ -288,7 +288,7 @@ class NBL_API2 IGPUCommandBuffer :
         return true;
     }
 
-    uint64_t m_resetCheckedStamp = 0;
+    uint64_t m_resetCheckedStamp;
 
     // This bound descriptor set record doesn't include the descriptor sets whose layout has _any_ one of its bindings
     // created with IGPUDescriptorSetLayout::SBinding::E_CREATE_FLAGS::ECF_UPDATE_AFTER_BIND_BIT

include/nbl/video/IGPUCommandBuffer.h

@@ -401,6 +401,12 @@ class CVulkanCommandBuffer : public IGPUCommandBuffer
 
 	inline const void* getNativeHandle() const override {return &m_cmdbuf;}
     VkCommandBuffer getInternalObject() const {return m_cmdbuf;}
+    
+protected:
+    virtual ~CVulkanCommandBuffer() final
+    {
+        out_of_order_dtor();
+    }
 
 private:
     VkCommandBuffer m_cmdbuf;

src/nbl/video/CVulkanCommandBuffer.h

@@ -24,8 +24,7 @@ bool IGPUCommandBuffer::begin(core::bitflag<E_USAGE> flags, const SInheritanceIn
     }
 
     checkForParentPoolReset();
-    m_resetCheckedStamp = m_cmdpool->getResetCounter();
-
+    // still not initial and pool wasn't reset
     if (m_state != ES_INITIAL)
     {
         releaseResourcesBackToPool();
@@ -39,6 +38,8 @@ bool IGPUCommandBuffer::begin(core::bitflag<E_USAGE> flags, const SInheritanceIn
         m_state = ES_INITIAL;
     }
 
+    // still not initial (we're trying to single-reset a commandbuffer that cannot be individually reset)
+    // should have been caught out above
     assert(m_state == ES_INITIAL);
 
     if (inheritanceInfo != nullptr)