Change fft bitReverse name, update examples pointer submodule

Author: Fletterio

examples_tests

@@ -5,8 +5,7 @@
 #include <nbl/builtin/hlsl/complex.hlsl>
 #include <nbl/builtin/hlsl/concepts.hlsl>
 #include <nbl/builtin/hlsl/math/intutil.hlsl>
-#include "nbl/builtin/hlsl/numbers.hlsl"
-#include "nbl/builtin/hlsl/concepts.hlsl"
+#include <nbl/builtin/hlsl/numbers.hlsl>
 
 namespace nbl
 {
@@ -96,33 +95,15 @@ void unpack(NBL_REF_ARG(complex_t<Scalar>) lo, NBL_REF_ARG(complex_t<Scalar>) hi
     lo = x;
 }
 
-
-}
-}
-}
-
-#ifdef __HLSL_VERSION
-
-namespace nbl 
-{
-namespace hlsl
-{
-namespace fft 
-{
-
-// ------------------------------------------------- Utils ---------------------------------------------------------
-
 // Bit-reverses T as a binary string of length given by Bits
 template<typename T, uint16_t Bits NBL_FUNC_REQUIRES(is_integral_v<T> && Bits <= sizeof(T) * 8)
-T bitReverse(T value)
+T bitReverseAs(T value)
 {
-    return spirv::bitReverse<uint32_t>(value) >> (sizeof(T) * 8 - Bits);
+    return hlsl::bitReverse<uint32_t>(value) >> (sizeof(T) * 8 - Bits);
 }
 
 }
 }
 }
 
-#endif
-
 #endif

include/nbl/builtin/hlsl/fft/common.hlsl

@@ -163,14 +163,14 @@ struct FFTIndexingUtils
     // This is because Cooley-Tukey + subgroup operations end up spewing out the outputs in a weird order
     static uint32_t getDFTIndex(uint32_t outputIdx)
     {
-        return impl::circularBitShiftRightHigher<FFTSizeLog2, FFTSizeLog2 - ElementsPerInvocationLog2 + 1>(hlsl::fft::bitReverse<uint32_t, FFTSizeLog2>(outputIdx));
+        return impl::circularBitShiftRightHigher<FFTSizeLog2, FFTSizeLog2 - ElementsPerInvocationLog2 + 1>(hlsl::fft::bitReverseAs<uint32_t, FFTSizeLog2>(outputIdx));
     }
 
     // This function maps the index `freqIdx` in the DFT to the index `idx` in the output array of a Nabla FFT such that `DFT[freqIdx] = NablaFFT[idx]`
     // It is essentially the inverse of `getDFTIndex`
     static uint32_t getNablaIndex(uint32_t freqIdx)
     {
-        return hlsl::fft::bitReverse<uint32_t, FFTSizeLog2>(impl::circularBitShiftLeftHigher<FFTSizeLog2, FFTSizeLog2 - ElementsPerInvocationLog2 + 1>(freqIdx));
+        return hlsl::fft::bitReverseAs<uint32_t, FFTSizeLog2>(impl::circularBitShiftLeftHigher<FFTSizeLog2, FFTSizeLog2 - ElementsPerInvocationLog2 + 1>(freqIdx));
     }
 
     // Mirrors an index about the Nyquist frequency in the DFT order