Skip to content

Commit 0e5b7de

Browse files
committed
correct python script, fix and correct CArchive.h.in and update src/nbl/builtin/CMakeLists.txt. Update examples_tests submodule
1 parent d667624 commit 0e5b7de

File tree

4 files changed

+25
-17
lines changed

4 files changed

+25
-17
lines changed

src/nbl/builtin/CMakeLists.txt

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -250,8 +250,14 @@ function(ADD_CUSTOM_BUILTIN_RESOURCES _TARGET_NAME_ _BUNDLE_NAME_ _BUNDLE_SEARCH
250250
set(NBL_TEMPLATE_APK_RESOURCES_ARCHIVE_HEADER "${CMAKE_CURRENT_FUNCTION_LIST_DIR}/template/CArchive.h.in")
251251
set(NBL_BUILTIN_HEADER_GEN_PY "${CMAKE_CURRENT_FUNCTION_LIST_DIR}/builtinHeaderGen.py")
252252
set(NBL_BUILTIN_DATA_GEN_PY "${CMAKE_CURRENT_FUNCTION_LIST_DIR}/builtinDataGen.py")
253+
set(NBL_BS_HEADER_FILENAME "builtinResources.h")
254+
set(NBL_BS_DATA_SOURCE_FILENAME "builtinResourceData.cpp")
253255

254256
string(REPLACE "::" "/" _PATH_PREFIX_ "${_NAMESPACE_}")
257+
string(REPLACE "::" "_" _GUARD_SUFFIX_ "${_NAMESPACE_}")
258+
string(REGEX REPLACE "^[0-9]+\." "" _GUARD_SUFFIX_ ${_GUARD_SUFFIX_})
259+
string(TOUPPER ${_GUARD_SUFFIX_} _GUARD_SUFFIX_)
260+
string(MAKE_C_IDENTIFIER ${_GUARD_SUFFIX_} _GUARD_SUFFIX_)
255261

256262
set(_ITR_ 0)
257263
foreach(X IN LISTS _LBR_${_BUNDLE_NAME_}_)
@@ -284,8 +290,6 @@ function(ADD_CUSTOM_BUILTIN_RESOURCES _TARGET_NAME_ _BUNDLE_NAME_ _BUNDLE_SEARCH
284290
file(MAKE_DIRECTORY "${NBL_ROOT_PATH_BINARY}/include/nbl/builtin")
285291
file(WRITE "${NBL_RESOURCES_LIST_FILE}" "${RESOURCES_ARGS}")
286292

287-
set(NBL_BS_HEADER_FILENAME "builtinResources.h")
288-
set(NBL_BS_DATA_SOURCE_FILENAME "builtinResourceData.cpp")
289293
set(NBL_BUILTIN_RESOURCES_HEADER "${_OUTPUT_DIRECTORY_}/${NBL_BS_HEADER_FILENAME}")
290294
set(NBL_BUILTIN_RESOURCE_DATA_SOURCE "${_OUTPUT_DIRECTORY_}/${NBL_BS_DATA_SOURCE_FILENAME}")
291295

@@ -296,8 +300,8 @@ function(ADD_CUSTOM_BUILTIN_RESOURCES _TARGET_NAME_ _BUNDLE_NAME_ _BUNDLE_SEARCH
296300

297301
add_custom_command(
298302
OUTPUT "${NBL_BUILTIN_RESOURCES_HEADER}" "${NBL_BUILTIN_RESOURCE_DATA_SOURCE}"
299-
COMMAND "${PYTHON_EXECUTABLE}" "${NBL_BUILTIN_HEADER_GEN_PY}" "${NBL_BUILTIN_RESOURCES_HEADER}" "${NBL_ROOT_PATH}/include" "${NBL_RESOURCES_LIST_FILE}" "${_NAMESPACE_}"
300-
COMMAND "${PYTHON_EXECUTABLE}" "${NBL_BUILTIN_DATA_GEN_PY}" "${NBL_BUILTIN_RESOURCE_DATA_SOURCE}" "${NBL_ROOT_PATH}/include" "${NBL_RESOURCES_LIST_FILE}" "${_NAMESPACE_}" "${NBL_BS_HEADER_FILENAME}"
303+
COMMAND "${PYTHON_EXECUTABLE}" "${NBL_BUILTIN_HEADER_GEN_PY}" "${NBL_BUILTIN_RESOURCES_HEADER}" "${_BUNDLE_SEARCH_DIRECTORY_}" "${NBL_RESOURCES_LIST_FILE}" "${_NAMESPACE_}" "${_GUARD_SUFFIX_}"
304+
COMMAND "${PYTHON_EXECUTABLE}" "${NBL_BUILTIN_DATA_GEN_PY}" "${NBL_BUILTIN_RESOURCE_DATA_SOURCE}" "${_BUNDLE_SEARCH_DIRECTORY_}" "${NBL_RESOURCES_LIST_FILE}" "${_NAMESPACE_}" "${NBL_BS_HEADER_FILENAME}"
301305
COMMENT "Generating built-in resources"
302306
DEPENDS ${NBL_DEPENDENCY_FILES}
303307
VERBATIM

src/nbl/builtin/builtinHeaderGen.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,15 +17,16 @@
1717
cmakeSourceDir = sys.argv[2]
1818
resourcesFile = sys.argv[3]
1919
resourcesNamespace = sys.argv[4]
20+
guardSuffix = sys.argv[5]
2021

2122
with open(resourcesFile, "r") as f:
2223
resourcePaths = f.read().rstrip().split(',')
2324

2425
#opening a file
2526
outp = open(outputFilename,"w+")
2627

27-
outp.write("#ifndef BUILTINRESOURCEDATA_H\n")
28-
outp.write("#define BUILTINRESOURCEDATA_H\n")
28+
outp.write("#ifndef _" + guardSuffix + "_BUILTINRESOURCEDATA_H_\n")
29+
outp.write("#define _" + guardSuffix + "_BUILTINRESOURCEDATA_H\n")
2930
outp.write("#include <stdlib.h>\n")
3031
outp.write("#include <cstdint>\n")
3132
outp.write("#include <string>\n")
@@ -40,6 +41,6 @@
4041
outp.write('\n\t\textern template const std::pair<const uint8_t*, size_t> get_resource<typename NBL_CORE_UNIQUE_STRING_LITERAL_TYPE("%s")>();' % x)
4142

4243
outp.write("\n\t}")
43-
outp.write("\n#endif")
44+
outp.write("\n#endif // _" + guardSuffix + "_BUILTINRESOURCEDATA_H_")
4445

4546
outp.close()
Lines changed: 12 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,29 +1,32 @@
1-
#ifndef _NBL_C_ARCHIVE_H_
2-
#define _NBL_C_ARCHIVE_H_
1+
#ifndef _@_GUARD_SUFFIX_@_C_ARCHIVE_H_
2+
#define _@_GUARD_SUFFIX_@_C_ARCHIVE_H_
33

44
#include <nbl/system/CFileArchive.h>
5+
#include "@NBL_BS_HEADER_FILENAME@"
56

67
namespace @_NAMESPACE_@
78
{
89
constexpr std::string_view pathPrefix = "@_PATH_PREFIX_@";
910
constexpr bool hasPathPrefix(std::string_view str) { return str.find(pathPrefix) == 0ull; }
11+
12+
std::pair<const uint8_t*, size_t> get_resource_runtime(const std::string& filename);
1013

11-
class CArchive final : public system::CFileArchive
14+
class CArchive final : public nbl::system::CFileArchive
1215
{
1316
public:
14-
inline CArchive(system::path _path, system::logger_opt_smart_ptr&& logger)
15-
: system::CFileArchive(std::move(_path),std::move(logger), getItemList()) {}
17+
inline CArchive(nbl::system::path _path, nbl::system::logger_opt_smart_ptr&& logger)
18+
: nbl::system::CFileArchive(std::move(_path),std::move(logger), getItemList()) {}
1619

1720
protected:
18-
file_buffer_t getFileBuffer(const system::IFileArchive::SListEntry* item) override
21+
file_buffer_t getFileBuffer(const nbl::system::IFileArchive::SListEntry* item) override
1922
{
2023
auto found = get_resource_runtime(item->pathRelativeToArchive.string());
2124
return { const_cast<uint8_t*>(found.first), found.second, nullptr };
2225
}
2326

24-
core::vector<system::IFileArchive::SListEntry> getItemList()
27+
nbl::core::vector<nbl::system::IFileArchive::SListEntry> getItemList()
2528
{
26-
static core::vector<system::IFileArchive::SListEntry> resources
29+
static nbl::core::vector<nbl::system::IFileArchive::SListEntry> resources
2730
{
2831
@_RESOURCES_INIT_LIST_@
2932
};
@@ -33,6 +36,6 @@ namespace @_NAMESPACE_@
3336
};
3437
}
3538

36-
#endif // _NBL_C_ARCHIVE_H_
39+
#endif // _@_GUARD_SUFFIX_@_C_ARCHIVE_H_
3740

3841

0 commit comments

Comments
 (0)