fix C++ side hlsl::tranpose

devsh · devsh · commit 0d123f537d6c · 2025-07-02T15:53:25.000+02:00
diff --git a/include/nbl/builtin/hlsl/cpp_compat/impl/intrinsics_impl.hlsl b/include/nbl/builtin/hlsl/cpp_compat/impl/intrinsics_impl.hlsl
@@ -319,7 +319,8 @@ struct transpose_helper<Matrix>
 	static transposed_t __call(NBL_CONST_REF_ARG(Matrix) m)
 	{
 		using traits = matrix_traits<Matrix>;
-		return reinterpret_cast<transposed_t&>(glm::transpose<traits::ColumnCount, traits::RowCount, traits::scalar_type, glm::qualifier::highp>(reinterpret_cast<typename Matrix::Base const&>(m)));
+		// GLM's transpose function signature specializes in terms of the input argument
+		return reinterpret_cast<transposed_t&>(glm::transpose<traits::RowCount,traits::ColumnCount,traits::scalar_type,glm::qualifier::highp>(reinterpret_cast<typename Matrix::Base const&>(m)));
 	}
 };
 template<typename Vector>

Original file line number	Diff line number	Diff line change
`@@ -319,7 +319,8 @@ struct transpose_helper<Matrix>`
`319`	`319`	`static transposed_t __call(NBL_CONST_REF_ARG(Matrix) m)`
`320`	`320`	`{`
`321`	`321`	`using traits = matrix_traits<Matrix>;`
`322`		`- return reinterpret_cast<transposed_t&>(glm::transpose<traits::ColumnCount, traits::RowCount, traits::scalar_type, glm::qualifier::highp>(reinterpret_cast<typename Matrix::Base const&>(m)));`
	`322`	`+ // GLM's transpose function signature specializes in terms of the input argument`
	`323`	`+ return reinterpret_cast<transposed_t&>(glm::transpose<traits::RowCount,traits::ColumnCount,traits::scalar_type,glm::qualifier::highp>(reinterpret_cast<typename Matrix::Base const&>(m)));`
`323`	`324`	`}`
`324`	`325`	`};`
`325`	`326`	`template<typename Vector>`