having a mesh manipulator (only to provide normal quantization cache) was a bad idea, if we want to optimize vertex formats, lets optimize all and after loading

Author: devsh

include/nbl/asset/interchange/IAssetLoader.h

@@ -107,7 +107,6 @@ class NBL_API2 IAssetLoader : public virtual core::IReferenceCounted
 				decryptionKey(rhs.decryptionKey),
 				cacheFlags(rhs.cacheFlags),
 				loaderFlags(rhs.loaderFlags),
-				meshManipulatorOverride(rhs.meshManipulatorOverride),
 				logger(rhs.logger),
 				workingDirectory(rhs.workingDirectory)
 			{
@@ -117,7 +116,6 @@ class NBL_API2 IAssetLoader : public virtual core::IReferenceCounted
 			const uint8_t* decryptionKey;
 			E_CACHING_FLAGS cacheFlags;
 			E_LOADER_PARAMETER_FLAGS loaderFlags;				//!< Flags having an impact on extraordinary tasks during loading process
-			CPolygonGeometryManipulator* meshManipulatorOverride = nullptr;    //!< pointer used for specifying custom mesh manipulator to use, if nullptr - default mesh manipulator will be used
 			std::filesystem::path workingDirectory = "";
 			system::logger_opt_ptr logger;
 		};

src/nbl/asset/interchange/CSTLMeshFileLoader.cpp

@@ -8,7 +8,6 @@
 #ifdef _NBL_COMPILE_WITH_STL_LOADER_
 
 #include "nbl/asset/asset.h"
-#include "nbl/asset/utils/CQuantNormalCache.h"
 
 #include "nbl/asset/IAssetManager.h"
 
@@ -137,13 +136,6 @@ SAssetBundle CSTLMeshFileLoader::loadAsset(system::IFile* _file, const IAssetLoa
 		_override
 	};
 
-	if (_params.meshManipulatorOverride == nullptr)
-	{
-		_NBL_DEBUG_BREAK_IF(true);
-		assert(false);
-	}
-
-	CQuantNormalCache* const quantNormalCache = _params.meshManipulatorOverride->getQuantNormalCache();
 
 	const size_t filesize = context.inner.mainFile->getSize();
 	if (filesize < 6ull) // we need a header
@@ -276,8 +268,6 @@ SAssetBundle CSTLMeshFileLoader::loadAsset(system::IFile* _file, const IAssetLoa
 	const size_t vtxSize = hasColor ? (3 * sizeof(float) + 4 + 4) : (3 * sizeof(float) + 4);
 	auto vertexBuf = asset::ICPUBuffer::create({ vtxSize * positions.size() });
 
-	using quant_normal_t = CQuantNormalCache::value_type_t<EF_A2B10G10R10_SNORM_PACK32>;
-
 	quant_normal_t normal;
 	for (size_t i = 0u; i < positions.size(); ++i)
 	{