ci(webapp): use pinned biome version for checking player-project (#1386)

CBenoit · web-flow · commit a39dbb741e1c · 2025-06-18T11:34:06.000Z
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -423,13 +423,14 @@ jobs:
         with:
           npm_token: ${{ secrets.ARTIFACTORY_NPM_READ_TOKEN }}
 
-      - name: Install Biome
-        run: npm install -g @biomejs/biome
+      - name: Install NPM dependencies for webapp
+        working-directory: webapp/
+        run: npm install
 
       - name: Check
-        working-directory: webapp/player-project
-        run: biome check ./src
-      
+        working-directory: webapp/
+        run: npm run player:check
+
       - name: Install NPM dependencies for video player
         working-directory: webapp/video-player
         run: npm install
diff --git a/webapp/src/client/app/app-auth.interceptor.ts b/webapp/src/client/app/app-auth.interceptor.ts
@@ -1,9 +1,9 @@
-import { HttpErrorResponse, HttpEvent, HttpHandler, HttpInterceptor, HttpRequest } from '@angular/common/http';
+import { HttpErrorResponse, HttpHandler, HttpInterceptor, HttpRequest } from '@angular/common/http';
 import { Injectable } from '@angular/core';
 import { Router } from '@angular/router';
 import { AuthService } from '@shared/services/auth.service';
 import { NavigationService } from '@shared/services/navigation.service';
-import { Observable, throwError } from 'rxjs';
+import { throwError } from 'rxjs';
 import { catchError } from 'rxjs/operators';
 
 @Injectable()
@@ -26,7 +26,7 @@ export class AuthInterceptor implements HttpInterceptor {
       const currentUrl = new URL(window.location.href);
       const targetUrl = new URL(req.url);
       goToNext.push(currentUrl.hostname !== targetUrl.hostname);
-    } catch (e) {
+    } catch (_e) {
       // do nothing, the url is not valid, the req is for the same host
     }
 
diff --git a/webapp/src/client/app/modules/base/menu/app-menu.component.ts b/webapp/src/client/app/modules/base/menu/app-menu.component.ts
@@ -78,7 +78,7 @@ export class AppMenuComponent extends BaseComponent implements OnInit {
       (): void => {
         this.navigationService.navigateToRoot().then(noop);
       },
-      (url: string) => false,
+      (_url: string) => false,
       true,
     );
 
@@ -109,7 +109,7 @@ export class AppMenuComponent extends BaseComponent implements OnInit {
    * This function always returns zero, indicating "no change" in order.
    * KAH Dec 16 2023
    */
-  asIsOrder(a: KeyValue<string, RouterMenuItem>, b: KeyValue<string, RouterMenuItem>): number {
+  asIsOrder(_a: KeyValue<string, RouterMenuItem>, _b: KeyValue<string, RouterMenuItem>): number {
     return 1;
   }
 
diff --git a/webapp/src/client/app/modules/base/menu/menu-group-list-item/menu-group-list-item.component.ts b/webapp/src/client/app/modules/base/menu/menu-group-list-item/menu-group-list-item.component.ts
@@ -25,7 +25,7 @@ export class MenuGroupListItemComponent extends BaseComponent implements OnInit,
     this.onMenuGroupMouseLeave(); // Call this function to reset the icon at init
   }
 
-  onToggleMenuGroupList($event: MouseEvent): void {
+  onToggleMenuGroupList(_$event: MouseEvent): void {
     if (this.accordion) {
       this.isClosed = !this.isClosed;
       if (this.isClosed) {
diff --git a/webapp/src/client/app/modules/base/menu/menu-list-active-sessions/menu-list-active-sessions.component.ts b/webapp/src/client/app/modules/base/menu/menu-list-active-sessions/menu-list-active-sessions.component.ts
@@ -1,6 +1,6 @@
 import { Component, Input, OnInit } from '@angular/core';
 import { BaseComponent } from '@shared/bases/base.component';
-import { ConnectionSessionType, SessionType, WebSession } from '@shared/models/web-session.model';
+import { SessionType, WebSession } from '@shared/models/web-session.model';
 import { WebSessionService } from '@shared/services/web-session.service';
 import { takeUntil } from 'rxjs/operators';
 
diff --git a/webapp/src/client/app/modules/web-client/ard/web-client-ard.component.ts b/webapp/src/client/app/modules/web-client/ard/web-client-ard.component.ts
@@ -28,8 +28,6 @@ import { catchError, map, switchMap, takeUntil } from 'rxjs/operators';
 import '@devolutions/iron-remote-desktop/iron-remote-desktop.js';
 import { ardQualityMode, Backend, resolutionQuality, wheelSpeedFactor } from '@devolutions/iron-remote-desktop-vnc';
 import { DVL_ARD_ICON, DVL_WARNING_ICON, JET_ARD_URL } from '@gateway/app.constants';
-import { ArdQualityMode } from '@gateway/shared/enums/ard-quality-mode.enum';
-import { ResolutionQuality } from '@gateway/shared/enums/resolution-quality.enum';
 import { AnalyticService, ProtocolString } from '@gateway/shared/services/analytic.service';
 import { ExtractedHostnamePort } from '@shared/services/utils/string.service';
 import { v4 as uuidv4 } from 'uuid';
@@ -385,7 +383,7 @@ export class WebClientArdComponent extends WebClientBaseComponent implements OnI
     this.remoteClient.onSessionEvent(handler);
   }
 
-  private handleSessionStarted(event: SessionEvent): void {
+  private handleSessionStarted(_event: SessionEvent): void {
     this.handleIronRDPConnectStarted();
     this.initializeStatus();
   }
diff --git a/webapp/src/client/app/modules/web-client/form/form-components/ssh/ssh-form.component.ts b/webapp/src/client/app/modules/web-client/form/form-components/ssh/ssh-form.component.ts
@@ -1,7 +1,6 @@
 import { AfterViewInit, ChangeDetectorRef, Component, Injectable, Input, OnDestroy, OnInit } from '@angular/core';
 import { FormGroup } from '@angular/forms';
 import { SshAuthMode } from '@gateway/shared/enums/web-client-auth-mode.enum';
-import { SSHFormDataInput } from '@gateway/shared/interfaces/forms.interfaces';
 import { SshKeyService } from '@gateway/shared/services/ssh-key.service';
 import { WebFormService } from '@gateway/shared/services/web-form.service';
 import { BaseComponent } from '@shared/bases/base.component';
diff --git a/webapp/src/client/app/modules/web-client/form/form-controls/enable-cursor-control/enable-cursor-control.component.ts b/webapp/src/client/app/modules/web-client/form/form-controls/enable-cursor-control/enable-cursor-control.component.ts
@@ -2,7 +2,6 @@ import { Component, Input, OnInit } from '@angular/core';
 import { FormGroup } from '@angular/forms';
 
 import { BaseComponent } from '@shared/bases/base.component';
-import { ArdQualityMode } from '@shared/enums/ard-quality-mode.enum';
 import { WebFormService } from '@shared/services/web-form.service';
 
 @Component({
diff --git a/webapp/src/client/app/modules/web-client/form/form-controls/enable-display-configuration-control/enable-display-configuration-control.component.ts b/webapp/src/client/app/modules/web-client/form/form-controls/enable-display-configuration-control/enable-display-configuration-control.component.ts
@@ -2,7 +2,6 @@ import { Component, Input, OnInit } from '@angular/core';
 import { FormGroup } from '@angular/forms';
 
 import { BaseComponent } from '@shared/bases/base.component';
-import { ArdQualityMode } from '@shared/enums/ard-quality-mode.enum';
 import { WebFormService } from '@shared/services/web-form.service';
 
 @Component({
diff --git a/webapp/src/client/app/modules/web-client/form/form-controls/file-control/file-control.component.ts b/webapp/src/client/app/modules/web-client/form/form-controls/file-control/file-control.component.ts
@@ -1,4 +1,4 @@
-import { Component, ElementRef, Input, OnDestroy, OnInit, ViewChild } from '@angular/core';
+import { Component, Input, OnDestroy, OnInit } from '@angular/core';
 import { SshKeyService } from '@gateway/shared/services/ssh-key.service';
 import { WebFormService } from '@gateway/shared/services/web-form.service';
 import { ValidateFileResult } from '../../../../../shared/services/ssh-key.service';
diff --git a/webapp/src/client/app/modules/web-client/form/form-controls/kdc-url-control/kdc-url-control.component.ts b/webapp/src/client/app/modules/web-client/form/form-controls/kdc-url-control/kdc-url-control.component.ts
@@ -1,5 +1,5 @@
 import { Component, Input, OnInit } from '@angular/core';
-import { AbstractControl, FormControl, FormGroup, ValidatorFn } from '@angular/forms';
+import { AbstractControl, FormGroup, ValidatorFn } from '@angular/forms';
 
 import { BaseComponent } from '@shared/bases/base.component';
 import { WebFormService } from '@shared/services/web-form.service';
diff --git a/webapp/src/client/app/modules/web-client/form/form-controls/password-control/password-control.component.ts b/webapp/src/client/app/modules/web-client/form/form-controls/password-control/password-control.component.ts
@@ -1,5 +1,5 @@
 import { Component, Input, OnInit, SimpleChanges } from '@angular/core';
-import { AbstractControl, FormGroup, Validators } from '@angular/forms';
+import { FormGroup, Validators } from '@angular/forms';
 
 import { BaseComponent } from '@shared/bases/base.component';
 import { WebFormService } from '@shared/services/web-form.service';
diff --git a/webapp/src/client/app/modules/web-client/form/form-controls/resolution-quality-control/resolution-quality-control.component.ts b/webapp/src/client/app/modules/web-client/form/form-controls/resolution-quality-control/resolution-quality-control.component.ts
@@ -4,7 +4,6 @@ import { ResolutionQuality } from '@gateway/shared/enums/resolution-quality.enum
 import { BaseComponent } from '@shared/bases/base.component';
 import { WebFormService } from '@shared/services/web-form.service';
 import { SelectItem } from 'primeng/api';
-import { takeUntil } from 'rxjs/operators';
 
 @Component({
   selector: 'web-client-resolution-quality-control',
diff --git a/webapp/src/client/app/modules/web-client/form/form-controls/screen-size-control/screen-size-control.component.ts b/webapp/src/client/app/modules/web-client/form/form-controls/screen-size-control/screen-size-control.component.ts
@@ -1,5 +1,5 @@
 import { Component, Input, OnInit } from '@angular/core';
-import { AbstractControl, FormGroup } from '@angular/forms';
+import { FormGroup } from '@angular/forms';
 import { BaseComponent } from '@shared/bases/base.component';
 import { ScreenSize } from '@shared/enums/screen-size.enum';
 import { WebFormService } from '@shared/services/web-form.service';
diff --git a/webapp/src/client/app/modules/web-client/form/form-controls/username-control/username-control.component.ts b/webapp/src/client/app/modules/web-client/form/form-controls/username-control/username-control.component.ts
@@ -1,5 +1,5 @@
 import { Component, Input, OnInit, SimpleChanges } from '@angular/core';
-import { AbstractControl, FormGroup } from '@angular/forms';
+import { FormGroup } from '@angular/forms';
 
 import { BaseComponent } from '@shared/bases/base.component';
 import { WebFormService } from '@shared/services/web-form.service';
diff --git a/webapp/src/client/app/modules/web-client/form/web-client-form.component.ts b/webapp/src/client/app/modules/web-client/form/web-client-form.component.ts
@@ -8,15 +8,13 @@ import {
   Output,
   SimpleChanges,
 } from '@angular/core';
-import { AbstractControl, FormBuilder, FormGroup, Validators } from '@angular/forms';
+import { FormBuilder, FormGroup, Validators } from '@angular/forms';
 import { NetScanEntry, NetScanService } from '@gateway/shared/services/net-scan.services';
-import { BaseComponent } from '@shared/bases/base.component';
-import { ScreenSize } from '@shared/enums/screen-size.enum';
 import { Protocol, WebClientProtocol } from '@shared/enums/web-client-protocol.enum';
 import { AutoCompleteInput, HostnameObject } from '@shared/interfaces/forms.interfaces';
 import { SelectItemWithTooltip } from '@shared/interfaces/select-item-tooltip.interface';
 import { ComponentStatus } from '@shared/models/component-status.model';
-import { BaseSessionComponent, ConnectionSessionType, SessionType, WebSession } from '@shared/models/web-session.model';
+import { BaseSessionComponent, SessionType, WebSession } from '@shared/models/web-session.model';
 import { StorageService } from '@shared/services/utils/storage.service';
 import { UtilsService } from '@shared/services/utils.service';
 import { WebFormService } from '@shared/services/web-form.service';
diff --git a/webapp/src/client/app/modules/web-client/net-scan/net-scan.component.ts b/webapp/src/client/app/modules/web-client/net-scan/net-scan.component.ts
@@ -28,7 +28,7 @@ export class NetScanComponent implements AfterViewInit {
       next: (entry: NetScanEntry) => {
         this.services.push(entry);
       },
-      error: (e) => {
+      error: (_e) => {
         this.ended = true;
       },
       complete: () => {
diff --git a/webapp/src/client/app/modules/web-client/rdp/web-client-rdp.component.ts b/webapp/src/client/app/modules/web-client/rdp/web-client-rdp.component.ts
@@ -433,7 +433,7 @@ export class WebClientRdpComponent extends WebClientBaseComponent implements OnI
     this.remoteClient.onSessionEvent(handler);
   }
 
-  private handleSessionStarted(event: SessionEvent): void {
+  private handleSessionStarted(_event: SessionEvent): void {
     this.handleIronRDPConnectStarted();
     this.initializeStatus();
   }
diff --git a/webapp/src/client/app/modules/web-client/ssh/web-client-ssh.component.ts b/webapp/src/client/app/modules/web-client/ssh/web-client-ssh.component.ts
@@ -180,7 +180,7 @@ export class WebClientSshComponent extends WebClientBaseComponent implements Web
         passpharse: connectionParameters.privateKeyPassphrase ?? '',
         privateKey: connectionParameters.privateKey ?? '',
         password: connectionParameters.password ?? '',
-        onHostKeyReceived: (serverName, fingerprint) => {
+        onHostKeyReceived: (_serverName, _fingerprint) => {
           return Promise.resolve(true);
         },
       }),
diff --git a/webapp/src/client/app/modules/web-client/vnc/web-client-vnc.component.ts b/webapp/src/client/app/modules/web-client/vnc/web-client-vnc.component.ts
@@ -450,7 +450,7 @@ export class WebClientVncComponent extends WebClientBaseComponent implements OnI
     this.remoteClient.onSessionEvent(handler);
   }
 
-  private handleSessionStarted(event: SessionEvent): void {
+  private handleSessionStarted(_event: SessionEvent): void {
     this.handleIronVNCConnectStarted();
     this.initializeStatus();
   }
diff --git a/webapp/src/client/app/shared/components/dynamic-tab/dynamic-tab.component.ts b/webapp/src/client/app/shared/components/dynamic-tab/dynamic-tab.component.ts
@@ -2,7 +2,6 @@ import {
   AfterViewInit,
   ChangeDetectorRef,
   Component,
-  ComponentRef,
   EventEmitter,
   Input,
   OnDestroy,
@@ -20,7 +19,7 @@ import { SessionType, WebSession } from '@shared/models/web-session.model';
 import { ComponentListenerService } from '@shared/services/component-listener.service';
 import { DynamicComponentService } from '@shared/services/dynamic-component.service';
 import { WebSessionService } from '@shared/services/web-session.service';
-import { distinctUntilChanged, take, takeUntil, tap } from 'rxjs/operators';
+import { distinctUntilChanged, take, takeUntil } from 'rxjs/operators';
 
 @Component({
   selector: 'web-client-dynamic-tab',
diff --git a/webapp/src/client/app/shared/components/tab-view/tab-view.component.ts b/webapp/src/client/app/shared/components/tab-view/tab-view.component.ts
@@ -6,11 +6,10 @@ import {
   HostListener,
   OnDestroy,
   OnInit,
-  Type,
   ViewChild,
 } from '@angular/core';
 import { BaseComponent } from '@shared/bases/base.component';
-import { SessionDataTypeMap, SessionType, WebSession, WebSessionComponentType } from '@shared/models/web-session.model';
+import { SessionDataTypeMap, SessionType, WebSession } from '@shared/models/web-session.model';
 import { WebSessionService } from '@shared/services/web-session.service';
 import { TabView } from 'primeng/tabview';
 import { takeUntil } from 'rxjs/operators';
diff --git a/webapp/src/client/app/shared/guards/auth.guard.ts b/webapp/src/client/app/shared/guards/auth.guard.ts
@@ -3,7 +3,7 @@ import { ActivatedRouteSnapshot, Router, RouterStateSnapshot } from '@angular/ro
 
 import { AuthService } from '@shared/services/auth.service';
 
-export function authGuard(route: ActivatedRouteSnapshot, state: RouterStateSnapshot): boolean {
+export function authGuard(_route: ActivatedRouteSnapshot, _state: RouterStateSnapshot): boolean {
   const router: Router = inject(Router);
   const authService = inject(AuthService);
 
diff --git a/webapp/src/client/app/shared/models/web-session.model.ts b/webapp/src/client/app/shared/models/web-session.model.ts
@@ -1,4 +1,4 @@
-import { Component, ComponentRef, Type } from '@angular/core';
+import { ComponentRef, Type } from '@angular/core';
 import { WebClientArdComponent } from '@gateway/modules/web-client/ard/web-client-ard.component';
 import { WebClientFormComponent } from '@gateway/modules/web-client/form/web-client-form.component';
 import { WebClientRdpComponent } from '@gateway/modules/web-client/rdp/web-client-rdp.component';
diff --git a/webapp/src/client/app/shared/resolvers/wasm-init.resolver.ts b/webapp/src/client/app/shared/resolvers/wasm-init.resolver.ts
@@ -12,7 +12,7 @@ import { map } from 'rxjs/operators';
 export class WasmInitResolver implements Resolve<void> {
   constructor() {}
 
-  resolve(route: ActivatedRouteSnapshot, state: RouterStateSnapshot): Observable<void> {
+  resolve(_route: ActivatedRouteSnapshot, _state: RouterStateSnapshot): Observable<void> {
     return forkJoin([from(rdp_init('INFO')), from(vnc_init('INFO'))]).pipe(map(() => void 0));
   }
 }
diff --git a/webapp/src/client/app/shared/services/analytic.service.ts b/webapp/src/client/app/shared/services/analytic.service.ts
@@ -45,7 +45,7 @@ export class AnalyticService {
       return;
     }
     this.openedConnections.delete(connectionId.id);
-    const duration = new Date().getTime() - connection.startTime.getTime();
+    const duration = Date.now() - connection.startTime.getTime();
     const durationInSeconds = duration / 1000;
 
     this.sendEvent({
@@ -57,7 +57,7 @@ export class AnalyticService {
   sendCloseAllEvents(): void {
     this.openedConnections.forEach((connection, id) => {
       this.openedConnections.delete(id);
-      const duration = new Date().getTime() - connection.startTime.getTime();
+      const duration = Date.now() - connection.startTime.getTime();
       const durationInSeconds = duration / 1000;
 
       this.sendEvent({
diff --git a/webapp/src/client/app/shared/services/auth.service.ts b/webapp/src/client/app/shared/services/auth.service.ts
@@ -6,7 +6,6 @@ import { NavigationService } from '@shared/services/navigation.service';
 import { WebSessionService } from '@shared/services/web-session.service';
 import { BehaviorSubject, interval, Observable, of, Subscription, throwError } from 'rxjs';
 import { catchError, map, takeUntil, tap } from 'rxjs/operators';
-import { SessionType } from '../models/web-session.model';
 
 @Injectable({
   providedIn: 'root',
@@ -135,7 +134,7 @@ export class AuthService extends BaseComponent {
   }
 
   private storeToken(username: string, token: string): void {
-    const expirationTime: number = new Date().getTime() + AuthService.TOKEN_LIFESPAN;
+    const expirationTime: number = Date.now() + AuthService.TOKEN_LIFESPAN;
     const session: Session = new Session(username, token, new Date(expirationTime).toISOString());
     sessionStorage.setItem(AuthService.SESSION_STORAGE_KEY, JSON.stringify(session));
     this.sessionSubject.next(session);
@@ -174,7 +173,7 @@ export class AuthService extends BaseComponent {
       return false;
     }
 
-    const now: number = new Date().getTime();
+    const now: number = Date.now();
     const expiresTime: number = new Date(session.expires).getTime();
 
     return now <= expiresTime;
diff --git a/webapp/src/client/app/shared/services/dynamic-component.service.ts b/webapp/src/client/app/shared/services/dynamic-component.service.ts
@@ -1,5 +1,5 @@
-import { ComponentRef, Injectable, Type, ViewContainerRef } from '@angular/core';
-import { DataForSession, SessionType, WebSession } from '@shared/models/web-session.model';
+import { ComponentRef, Injectable, ViewContainerRef } from '@angular/core';
+import { SessionType, WebSession } from '@shared/models/web-session.model';
 
 @Injectable({
   providedIn: 'root',
diff --git a/webapp/src/client/app/shared/services/main-menu.service.ts b/webapp/src/client/app/shared/services/main-menu.service.ts
@@ -1,6 +1,6 @@
 import { Injectable } from '@angular/core';
 import { SessionType, WebSession } from '@shared/models/web-session.model';
-import { BehaviorSubject, Observable } from 'rxjs';
+import { BehaviorSubject } from 'rxjs';
 
 @Injectable()
 export class MainMenuService {
diff --git a/webapp/src/client/app/shared/services/web-client.service.ts b/webapp/src/client/app/shared/services/web-client.service.ts
@@ -12,7 +12,6 @@ import {
   TelnetConnectionParameters,
 } from '@shared/interfaces/connection-params.interfaces';
 import { DesktopSize } from '@shared/models/desktop-size';
-import { WebSession } from '@shared/models/web-session.model';
 import { ApiService } from '@shared/services/api.service';
 import { UtilsService } from '@shared/services/utils.service';
 import { Observable, of, throwError } from 'rxjs';
@@ -126,7 +125,7 @@ export class WebClientService extends BaseComponent {
       map((token) => {
         return { ...connectionParameters, token } as typeof connectionParameters;
       }),
-      catchError((err) => {
+      catchError((_err) => {
         return throwError(() => new Error('Failed to fetch protocol token'));
       }),
     );

Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,7 @@ export class MenuGroupListItemComponent extends BaseComponent implements OnInit,`
`25`	`25`	`this.onMenuGroupMouseLeave(); // Call this function to reset the icon at init`
`26`	`26`	`}`
`27`	`27`
`28`		`- onToggleMenuGroupList($event: MouseEvent): void {`
	`28`	`+ onToggleMenuGroupList(_$event: MouseEvent): void {`
`29`	`29`	`if (this.accordion) {`
`30`	`30`	`this.isClosed = !this.isClosed;`
`31`	`31`	`if (this.isClosed) {`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-import { Component, ElementRef, Input, OnDestroy, OnInit, ViewChild } from '@angular/core';`
	`1`	`+import { Component, Input, OnDestroy, OnInit } from '@angular/core';`
`2`	`2`	`import { SshKeyService } from '@gateway/shared/services/ssh-key.service';`
`3`	`3`	`import { WebFormService } from '@gateway/shared/services/web-form.service';`
`4`	`4`	`import { ValidateFileResult } from '../../../../../shared/services/ssh-key.service';`