feat(server): advertize Bitmap::desktopResizeFlag

elmarco · CBenoit · commit a0fccf8d1a3e · 2025-01-27T07:35:36.000-05:00
This makes freerdp keep the flag up and handle desktop
resize/deactivation-reactivation. It should be okay to advertize,
if the server doesn't resize anyway, I guess.

Signed-off-by: Marc-André Lureau &lt;marcandre.lureau@redhat.com&gt;
diff --git a/crates/ironrdp-server/src/capabilities.rs b/crates/ironrdp-server/src/capabilities.rs
@@ -28,7 +28,9 @@ fn bitmap_capabilities(size: &DesktopSize) -> capability_sets::Bitmap {
         pref_bits_per_pix: 32,
         desktop_width: size.width,
         desktop_height: size.height,
-        desktop_resize_flag: false,
+        // This makes freerdp keep the flag up and handle desktop resize/deactivation-reactivation.
+        // Likely okay to advertize if the server doesn't resize anyway.
+        desktop_resize_flag: true,
         drawing_flags: capability_sets::BitmapDrawingFlags::empty(),
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,9 @@ fn bitmap_capabilities(size: &DesktopSize) -> capability_sets::Bitmap {`
`28`	`28`	`pref_bits_per_pix: 32,`
`29`	`29`	`desktop_width: size.width,`
`30`	`30`	`desktop_height: size.height,`
`31`		`- desktop_resize_flag: false,`
	`31`	`+ // This makes freerdp keep the flag up and handle desktop resize/deactivation-reactivation.`
	`32`	`+ // Likely okay to advertize if the server doesn't resize anyway.`
	`33`	`+ desktop_resize_flag: true,`
`32`	`34`	`drawing_flags: capability_sets::BitmapDrawingFlags::empty(),`
`33`	`35`	`}`
`34`	`36`	`}`