Skip to content
This repository was archived by the owner on Jun 27, 2021. It is now read-only.

Commit 5908636

Browse files
authored
Upper/Lower case (#27)
* Upper/Lower case * up version to 0.1.8 * Release v0.1.8 Signed-off-by: Chase Sillevis <chase@sillevis.net>
1 parent 1ece8af commit 5908636

File tree

5 files changed

+24
-21
lines changed

5 files changed

+24
-21
lines changed

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ GOVERSION := 1.9.3
1919
PROJECT := $(CURRENT_DIR:$(GOPATH)/src/%=%)
2020
OWNER := $(notdir $(patsubst %/,%,$(dir $(PROJECT))))
2121
NAME := $(notdir $(PROJECT))
22-
VERSION := 0.1.7
22+
VERSION := 0.1.8
2323
EXTERNAL_TOOLS = \
2424
github.com/golang/dep/cmd/dep
2525

gsuite/resource_group.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ package gsuite
33
import (
44
"fmt"
55
"log"
6+
"strings"
67

78
"github.com/hashicorp/terraform/helper/schema"
89

@@ -64,7 +65,7 @@ func resourceGroupCreate(d *schema.ResourceData, meta interface{}) error {
6465
config := meta.(*Config)
6566

6667
group := &directory.Group{
67-
Email: d.Get("email").(string),
68+
Email: strings.ToLower(d.Get("email").(string)),
6869
}
6970

7071
if v, ok := d.GetOk("name"); ok {
@@ -101,7 +102,7 @@ func resourceGroupUpdate(d *schema.ResourceData, meta interface{}) error {
101102

102103
if d.HasChange("email") {
103104
log.Printf("[DEBUG] Updating group email: %s", d.Get("email").(string))
104-
group.Email = d.Get("email").(string)
105+
group.Email = strings.ToLower(d.Get("email").(string))
105106
}
106107

107108
if d.HasChange("name") {

gsuite/resource_group_member.go

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -73,8 +73,8 @@ func resourceGroupMemberCreate(d *schema.ResourceData, meta interface{}) error {
7373
group := d.Get("group").(string)
7474

7575
groupMember := &directory.Member{
76-
Role: d.Get("role").(string),
77-
Email: d.Get("email").(string),
76+
Role: strings.ToUpper(d.Get("role").(string)),
77+
Email: strings.ToLower(d.Get("email").(string)),
7878
}
7979

8080
var createdGroupMember *directory.Member
@@ -101,7 +101,7 @@ func resourceGroupMemberUpdate(d *schema.ResourceData, meta interface{}) error {
101101

102102
if d.HasChange("email") {
103103
log.Printf("[DEBUG] Updating groupMember email: %s", d.Get("email").(string))
104-
groupMember.Email = d.Get("email").(string)
104+
groupMember.Email = strings.ToLower(d.Get("email").(string))
105105
}
106106

107107
if len(nullFields) > 0 {
@@ -111,7 +111,7 @@ func resourceGroupMemberUpdate(d *schema.ResourceData, meta interface{}) error {
111111
var updatedGroupMember *directory.Member
112112
var err error
113113
err = retry(func() error {
114-
updatedGroupMember, err = config.directory.Members.Patch(d.Get("group").(string), d.Id(), groupMember).Do()
114+
updatedGroupMember, err = config.directory.Members.Patch(strings.ToLower(d.Get("group").(string)), d.Id(), groupMember).Do()
115115
return err
116116
})
117117

@@ -129,7 +129,7 @@ func resourceGroupMemberRead(d *schema.ResourceData, meta interface{}) error {
129129
var groupMember *directory.Member
130130
var err error
131131
err = retry(func() error {
132-
groupMember, err = config.directory.Members.Get(d.Get("group").(string), d.Id()).Do()
132+
groupMember, err = config.directory.Members.Get(strings.ToLower(d.Get("group").(string)), d.Id()).Do()
133133
return err
134134
})
135135

@@ -138,7 +138,7 @@ func resourceGroupMemberRead(d *schema.ResourceData, meta interface{}) error {
138138
}
139139

140140
d.SetId(groupMember.Id)
141-
d.Set("email", groupMember.Email)
141+
d.Set("email", strings.ToLower(groupMember.Email))
142142
d.Set("etag", groupMember.Etag)
143143
d.Set("kind", groupMember.Kind)
144144
d.Set("status", groupMember.Status)
@@ -152,7 +152,7 @@ func resourceGroupMemberDelete(d *schema.ResourceData, meta interface{}) error {
152152

153153
var err error
154154
err = retry(func() error {
155-
err = config.directory.Members.Delete(d.Get("group").(string), d.Id()).Do()
155+
err = config.directory.Members.Delete(strings.ToLower(d.Get("group").(string)), d.Id()).Do()
156156
return err
157157
})
158158
if err != nil {
@@ -175,7 +175,7 @@ func resourceGroupMemberImporter(d *schema.ResourceData, meta interface{}) ([]*s
175175
if len(s) < 2 {
176176
return nil, fmt.Errorf("Import via [group]:[member email] or [group]/[member email]!")
177177
}
178-
group, member := s[0], s[1]
178+
group, member := strings.ToLower(s[0]), strings.ToLower(s[1])
179179

180180
id, err := config.directory.Members.Get(group, member).Do()
181181

gsuite/resource_group_members.go

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ package gsuite
33
import (
44
"fmt"
55
"log"
6+
"strings"
67

78
"github.com/hashicorp/terraform/helper/schema"
89
directory "google.golang.org/api/admin/directory/v1"
@@ -47,7 +48,7 @@ func resourceGroupMembersRead(d *schema.ResourceData, meta interface{}) error {
4748
return err
4849
}
4950

50-
d.Set("group_email", groupEmail)
51+
d.Set("group_email", strings.ToLower(groupEmail))
5152
d.Set("member", membersToCfg(members))
5253
return nil
5354
}
@@ -118,7 +119,7 @@ func resourceMembers(d *schema.ResourceData) (members []map[string]interface{})
118119

119120
func createOrUpdateGroupMembers(d *schema.ResourceData, meta interface{}) (string, error) {
120121
config := meta.(*Config)
121-
groupEmail := d.Get("group_email").(string)
122+
groupEmail := strings.ToLower(d.Get("group_email").(string))
122123

123124
// Get members from config
124125
cfgMembers := resourceMembers(d)
@@ -168,8 +169,8 @@ func reconcileMembers(d *schema.ResourceData, cfgMembers, apiMembers []map[strin
168169
} else {
169170
// The member exists in the config and the API
170171
// If role has changed update, otherwise do nothing
171-
cfgRole = cfgMember["role"].(string)
172-
apiRole = apiMember["role"].(string)
172+
cfgRole = strings.ToUpper(cfgMember["role"].(string))
173+
apiRole = strings.ToUpper(apiMember["role"].(string))
173174
if cfgRole != apiRole {
174175
groupMember := &directory.Member{
175176
Role: cfgRole,
@@ -183,8 +184,8 @@ func reconcileMembers(d *schema.ResourceData, cfgMembers, apiMembers []map[strin
183184
var err error
184185
err = retry(func() error {
185186
updatedGroupMember, err = config.directory.Members.Patch(
186-
d.Get("group_email").(string),
187-
cfgMember["email"].(string),
187+
strings.ToLower(d.Get("group_email").(string)),
188+
strings.ToLower(cfgMember["email"].(string)),
188189
groupMember).Do()
189190
return err
190191
})
@@ -239,8 +240,8 @@ func getApiMembers(groupEmail string, config *Config) ([]*directory.Member, erro
239240

240241
func upsertMember(email, groupEmail, role string, config *Config) error {
241242
groupMember := &directory.Member{
242-
Role: role,
243-
Email: email,
243+
Role: strings.ToUpper(role),
244+
Email: strings.ToLower(email),
244245
}
245246

246247
// Check if the email address belongs to a user, or to a group
@@ -367,7 +368,7 @@ func resourceGroupMembersImporter(d *schema.ResourceData, meta interface{}) ([]*
367368
var group *directory.Group
368369
var err error
369370
err = retry(func() error {
370-
group, err = config.directory.Groups.Get(d.Id()).Do()
371+
group, err = config.directory.Groups.Get(strings.ToLower(d.Id())).Do()
371372
return err
372373
})
373374

gsuite/resource_user.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ package gsuite
33
import (
44
"fmt"
55
"log"
6+
"strings"
67

78
"github.com/hashicorp/terraform/helper/schema"
89

@@ -289,7 +290,7 @@ func resourceUserCreate(d *schema.ResourceData, meta interface{}) error {
289290
}
290291
if v, ok := d.GetOk("primary_email"); ok {
291292
log.Printf("[DEBUG] Setting %s: %s", "primary_email", v.(string))
292-
user.PrimaryEmail = v.(string)
293+
user.PrimaryEmail = strings.ToLower(v.(string))
293294
}
294295
if v, ok := d.GetOk("password"); ok {
295296
log.Printf("[DEBUG] Setting %s: %s", "password", v.(string))

0 commit comments

Comments
 (0)