refactor: address cargo check warnings and apply cargo fmt (#26)

* refactor: apply cargo fix

* refactor: apply cargo fmt

* refactor: remove or suppress unused

* refactor(ext_deps): remove redundant return

Author: RogueOneEcho

src/command/self_update.rs

@@ -1,7 +1,7 @@
 use crate::github::api::GithubApi;
 use crate::updater::constants::{GH_REPO, GH_USER};
 use crate::updater::release;
-use crate::updater::release::{ReleaseVersion, ReleaseVersionCompareResult};
+use crate::updater::release::ReleaseVersionCompareResult;
 use crate::{ERROR, INFO, SUCCESS};
 use console::Term;
 use futures::StreamExt;

src/config/config.rs

@@ -1,6 +1,5 @@
 use crate::config::constants::{
-    CONFIG_FILE_NAME, CONFIG_PATH, HOME_ENV, PROJECT_NAME, WINDOWS_APPDATA_ENV,
-    WINDOWS_HOMEDRIVE_ENV, WINDOWS_HOMEPATH_ENV, WINDOWS_USERPROFILE_ENV, XDG_CONFIG_ENV,
+    CONFIG_FILE_NAME, CONFIG_PATH, HOME_ENV, PROJECT_NAME, WINDOWS_APPDATA_ENV, XDG_CONFIG_ENV,
 };
 use crate::config::models::RedOxideConfig;
 use crate::redacted::models::ReleaseType::{Flac, Mp3320, Mp3V0};

src/config/constants.rs

@@ -1,4 +1,5 @@
 pub const CONFIG_FILE_NAME: &str = "red_oxide.config.json";
+
 pub const PROJECT_NAME: &str = "red_oxide";
 
 pub const CONFIG_PATH: &str = ".config";
@@ -8,6 +9,3 @@ pub const XDG_CONFIG_ENV: &str = "XDG_CONFIG_HOME";
 pub const HOME_ENV: &str = "HOME";
 
 pub const WINDOWS_APPDATA_ENV: &str = "APPDATA";
-pub const WINDOWS_USERPROFILE_ENV: &str = "USERPROFILE";
-pub const WINDOWS_HOMEDRIVE_ENV: &str = "HOMEDRIVE";
-pub const WINDOWS_HOMEPATH_ENV: &str = "HOMEPATH";

src/ext_deps/util.rs

@@ -1,41 +1,41 @@
 // Windows
 #[cfg(target_os = "windows")]
 pub fn get_flac_executable() -> String {
-    return "flac.exe".to_string()
+    "flac.exe".to_string()
 }
 
 #[cfg(target_os = "windows")]
 pub fn get_sox_executable() -> String {
-    return "sox.exe".to_string()
+    "sox.exe".to_string()
 }
 
 #[cfg(target_os = "windows")]
-pub fn get_lame_executable() -> String{
-    return "lame.exe".to_string()
+pub fn get_lame_executable() -> String {
+    "lame.exe".to_string()
 }
 
 #[cfg(target_os = "windows")]
 pub fn get_imdl_executable_name() -> String {
-    return "imdl.exe".to_string()
+    "imdl.exe".to_string()
 }
 
 // Linux or Mac
 #[cfg(not(target_os = "windows"))]
 pub fn get_flac_executable() -> String {
-    return "flac".to_string()
+    "flac".to_string()
 }
 
 #[cfg(not(target_os = "windows"))]
 pub fn get_sox_executable() -> String {
-    return "sox".to_string()
+    "sox".to_string()
 }
 
 #[cfg(not(target_os = "windows"))]
 pub fn get_lame_executable() -> String {
-    return "lame".to_string()
+    "lame".to_string()
 }
 
 #[cfg(not(target_os = "windows"))]
 pub fn get_imdl_executable_name() -> String {
-    return "imdl".to_string()
-}
+    "imdl".to_string()
+}

src/fs/util.rs

@@ -27,28 +27,3 @@ pub async fn get_all_files_with_extension(
 
     return Ok(files);
 }
-
-#[async_recursion]
-pub async fn count_files_with_extension(
-    dir_path: &PathBuf,
-    extension: &str,
-) -> Result<u64, anyhow::Error> {
-    let mut dir = fs::read_dir(dir_path).await?;
-    let mut count = 0;
-
-    while let Some(entry) = dir.next_entry().await? {
-        let path = entry.path();
-
-        if path.is_dir() {
-            count += count_files_with_extension(&path, extension).await?;
-        } else {
-            let file_name = path.file_name().unwrap().to_str().unwrap();
-
-            if file_name.ends_with(extension) {
-                count += 1;
-            }
-        }
-    }
-
-    return Ok(count);
-}

src/redacted/api/client.rs

@@ -49,6 +49,7 @@ impl RedactedApi {
             .await;
     }
 
+    #[allow(dead_code)]
     pub async fn get_torrent_info(
         &mut self,
         torrent_id: i64,

src/tags/util.rs

@@ -59,7 +59,7 @@ pub fn validate_tags_of_file(path: PathBuf, media: &Media) -> anyhow::Result<(bo
         return Ok((false, false));
     }
 
-    let (track_number, total_tracks) = tag.track();
+    let (track_number, _total_tracks) = tag.track();
 
     if track_number.is_none() {
         return Ok((false, media == &Vinyl));