Skip to content

Replace ConstantInterpolation by SmoothedConstantInterpolation #2244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
SouthEndMusic opened this issue Apr 16, 2025 · 0 comments · May be fixed by #2285
Open

Replace ConstantInterpolation by SmoothedConstantInterpolation #2244

SouthEndMusic opened this issue Apr 16, 2025 · 0 comments · May be fixed by #2285
Labels
core Issues related to the computational core in Julia dependencies Pull requests that update a dependency file performance Relates to runtime performance or convergence

Comments

@SouthEndMusic
Copy link
Collaborator

For continuous variables like forcing which we now interpolate with ConstantInterpolation, we can replace the interpolation by SmoothedConstantInterpolation.

At the time of writing SmoothedConstantInterpolation has not been merged yet upstream, see SciML/DataInterpolations.jl#367.

Things to note:

  • SmoothedConstantInterpolation cannot be used for forcing that comes in via the BMI
  • A decision has to be made for the value of the smoothing parameter d_max.
@SouthEndMusic SouthEndMusic added core Issues related to the computational core in Julia dependencies Pull requests that update a dependency file performance Relates to runtime performance or convergence labels Apr 16, 2025
@github-project-automation github-project-automation bot moved this to To do in Ribasim Apr 16, 2025
@SouthEndMusic SouthEndMusic linked a pull request May 22, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core Issues related to the computational core in Julia dependencies Pull requests that update a dependency file performance Relates to runtime performance or convergence
Projects
Ribasim
Status: To do
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Configurable FlowBoundary interpolation Deltares/Ribasim
1 participant
@SouthEndMusic