sla: parse finding.date implicitly (#12301)

* sla: parse finding.date implicitly

* add comment

* move import

* add unit test

Author: valentijnscholten

dojo/models.py

@@ -10,6 +10,7 @@
 from pathlib import Path
 from uuid import uuid4
 
+import dateutil
 import hyperlink
 import tagulous.admin
 from auditlog.registry import auditlog
@@ -2682,6 +2683,9 @@ def save(self, dedupe_option=True, rules_option=True, product_grading_option=Tru
 
         from dojo.finding import helper as finding_helper
 
+        # if not isinstance(self.date, (datetime, date)):
+        #     raise ValidationError(_("The 'date' field must be a valid date or datetime object."))
+
         if not user:
             from dojo.utils import get_current_user
             user = get_current_user()
@@ -3053,9 +3057,14 @@ def set_sla_expiration_date(self):
         if not system_settings.enable_finding_sla:
             return
 
+        # some parsers provide date as a `str` instead of a `date` in which case we need to parse it #12299 on GitHub
+        sla_start_date = self.get_sla_start_date()
+        if sla_start_date and isinstance(sla_start_date, str):
+            sla_start_date = dateutil.parser.parse(sla_start_date).date()
+
         sla_period, enforce_period = self.get_sla_period()
         if sla_period is not None and enforce_period:
-            self.sla_expiration_date = self.get_sla_start_date() + relativedelta(days=sla_period)
+            self.sla_expiration_date = sla_start_date + relativedelta(days=sla_period)
         else:
             self.sla_expiration_date = None
 

unittests/test_sla_calculations.py

@@ -1,6 +1,7 @@
 import logging
 from unittest.mock import patch
 
+import django
 from dateutil.relativedelta import relativedelta
 from django.utils import timezone
 
@@ -153,3 +154,29 @@ def test_mitigated_outside_sla(self):
             self.assertTrue("Out of SLA" in finding_sla(finding))
             self.assertTrue("15 days past" in finding_sla(finding))
             self.assertTrue(">15<" in finding_sla(finding))
+
+    # test implicit parsing of finding.date (GitHub #12299)
+    def test_finding_date_formats(self):
+        with self.subTest(i=0):
+            # date set to now shouldn't result in an error
+            finding = Finding(test=Test.objects.get(id=89), title="Test Finding 1", severity="High")
+            finding.date = timezone.now()
+            finding.save()
+
+        with self.subTest(i=1):
+            # date set to simple date string shouldn't result in an error
+            finding = Finding(test=Test.objects.get(id=89), title="Test Finding 2", severity="High")
+            finding.date = "2025-04-23"
+            finding.save()
+
+        with self.subTest(i=2):
+            # date set to ISO date string shouldn't result in an error
+            finding = Finding(test=Test.objects.get(id=89), title="Test Finding 3", severity="High")
+            finding.date = "2025-04-23T12:00:00Z"[:10]
+            finding.save()
+
+        with self.subTest(i=3) and self.assertRaises(django.core.exceptions.ValidationError):
+            # date set to ISO datetime string will result in a Django Error, not an error in our code
+            finding = Finding(test=Test.objects.get(id=89), title="Test Finding 3", severity="High")
+            finding.date = "2025-04-23T12:00:00+02:00"
+            finding.save()