Ruff: Add and fix PLW0108 (#11641)

Co-authored-by: Cody Maffucci <46459665+Maffooch@users.noreply.github.com>

Author: kiblik

dojo/finding/helper.py

@@ -450,7 +450,7 @@ def reset_duplicate_before_delete(dupe):
 
 
 def reset_duplicates_before_delete(qs):
-    mass_model_updater(Finding, qs, lambda f: reset_duplicate_before_delete(f), fields=["duplicate", "duplicate_finding"])
+    mass_model_updater(Finding, qs, reset_duplicate_before_delete, fields=["duplicate", "duplicate_finding"])
 
 
 def set_new_original(finding, new_original):

dojo/management/commands/dedupe.py

@@ -67,7 +67,7 @@ def handle(self, *args, **options):
 
             # only prefetch here for hash_code calculation
             finds = findings.prefetch_related("endpoints", "test__test_type")
-            mass_model_updater(Finding, finds, lambda f: generate_hash_code(f), fields=["hash_code"], order="asc", log_prefix="hash_code computation ")
+            mass_model_updater(Finding, finds, generate_hash_code, fields=["hash_code"], order="asc", log_prefix="hash_code computation ")
 
             logger.info("######## Done Updating Hashcodes########")
 
@@ -76,7 +76,7 @@ def handle(self, *args, **options):
             if get_system_setting("enable_deduplication"):
                 logger.info("######## Start deduplicating (%s) ########", ("foreground" if dedupe_sync else "background"))
                 if dedupe_sync:
-                    mass_model_updater(Finding, findings, lambda f: do_dedupe_finding(f), fields=None, order="desc", page_size=100, log_prefix="deduplicating ")
+                    mass_model_updater(Finding, findings, do_dedupe_finding, fields=None, order="desc", page_size=100, log_prefix="deduplicating ")
                 else:
                     # async tasks only need the id
                     mass_model_updater(Finding, findings.only("id"), lambda f: do_dedupe_finding_task(f.id), fields=None, order="desc", log_prefix="deduplicating ")

dojo/management/commands/migrate_cve.py

@@ -38,7 +38,7 @@ def handle(self, *args, **options):
         mass_model_updater(
             Finding,
             findings,
-            lambda f: create_vulnerability_id(f),
+            create_vulnerability_id,
             fields=None,
             page_size=100,
             log_prefix="creating vulnerability ids: ",
@@ -49,7 +49,7 @@ def handle(self, *args, **options):
         mass_model_updater(
             Finding_Template,
             finding_templates,
-            lambda f: create_vulnerability_id_template(f),
+            create_vulnerability_id_template,
             fields=None,
             page_size=100,
             log_prefix="creating vulnerability ids: ",

dojo/pipeline.py

@@ -176,7 +176,7 @@ def update_product_access(backend, uid, user=None, social=None, *args, **kwargs)
 
 def sanitize_username(username):
     allowed_chars_regex = re.compile(r"[\w@.+_-]")
-    allowed_chars = filter(lambda char: allowed_chars_regex.match(char), list(username))
+    allowed_chars = filter(allowed_chars_regex.match, list(username))
     return "".join(allowed_chars)
 
 

ruff.toml

@@ -76,7 +76,7 @@ select = [
    "PLC01", "PLC0205", "PLC0208", "PLC0414", "PLC18", "PLC24", "PLC3",
    "PLE",
    "PLR01", "PLR0203", "PLR0206", "PLR0915", "PLR1716", "PLR172", "PLR1733", "PLR1736",
-   "PLW0120", "PLW0127", "PLW0129", "PLW013", "PLW017", "PLW02", "PLW04", "PLW07", "PLW1", "PLW2", "PLW3",
+   "PLW0108", "PLW0120", "PLW0127", "PLW0129", "PLW013", "PLW017", "PLW02", "PLW04", "PLW07", "PLW1", "PLW2", "PLW3",
    "TRY003", "TRY004", "TRY2", "TRY300", "TRY401",
    "FLY",
    "NPY",