Skip to content

Commit a18fbcd

Browse files
authored
Fix Finding_Text (#12628)
1 parent e174325 commit a18fbcd

File tree

5 files changed

+34
-5
lines changed

5 files changed

+34
-5
lines changed

dojo/jira_link/helper.py

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -362,6 +362,14 @@ def get_epic_name_field_name(jira_instance):
362362
return "customfield_" + str(jira_instance.epic_name_id)
363363

364364

365+
def get_jira_finding_text(jira_instance):
366+
if jira_instance and jira_instance.finding_text:
367+
return jira_instance.finding_text
368+
369+
logger.debug("finding_text not found in Jira instance")
370+
return None
371+
372+
365373
def has_jira_issue(obj):
366374
return get_jira_issue(obj) is not None
367375

@@ -627,12 +635,11 @@ def jira_summary(obj):
627635
return summary.replace("\r", "").replace("\n", "")[:255]
628636

629637

630-
def jira_description(obj):
638+
def jira_description(obj, **kwargs):
631639
template = get_jira_issue_template(obj)
632640

633641
logger.debug("rendering description for jira from: %s", template)
634642

635-
kwargs = {}
636643
if isinstance(obj, Finding):
637644
kwargs["finding"] = obj
638645
elif isinstance(obj, Finding_Group):
@@ -840,7 +847,7 @@ def failure_to_add_message(message: str, exception: Exception, _: Any) -> bool:
840847
project_key=jira_project.project_key,
841848
issuetype_name=jira_instance.default_issue_type,
842849
summary=jira_summary(obj),
843-
description=jira_description(obj),
850+
description=jira_description(obj, finding_text=get_jira_finding_text(jira_instance)),
844851
component_name=jira_project.component,
845852
custom_fields=jira_project.custom_fields,
846853
labels=labels,
@@ -968,7 +975,7 @@ def failure_to_update_message(message: str, exception: Exception, obj: Any) -> b
968975
project_key=jira_project.project_key,
969976
issuetype_name=jira_instance.default_issue_type,
970977
summary=jira_summary(obj),
971-
description=jira_description(obj),
978+
description=jira_description(obj, finding_text=get_jira_finding_text(jira_instance)),
972979
component_name=jira_project.component if not issue.fields.components else None,
973980
labels=labels + issue.fields.labels,
974981
environment=jira_environment(obj),

dojo/templates/issue-trackers/jira_full/jira-description.tpl

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -94,4 +94,10 @@
9494
{{ finding.references|safe }}
9595
{% endif %}
9696

97+
{% if finding_text %}
98+
*Finding Text*:
99+
{{ finding_text|safe }}
100+
{% endif %}
101+
102+
97103
*Reporter:* [{{ finding.reporter|full_name}} ({{ finding.reporter.email }})|mailto:{{ finding.reporter.email }}]

dojo/templates/issue-trackers/jira_full/jira-finding-group-description.tpl

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -88,5 +88,11 @@ h3. [{{ finding.title|jiraencode}}|{{ finding_url|full_url }}]
8888
{{ finding.references|safe }}
8989
{% endif %}
9090

91+
{% if finding_text %}
92+
*Finding Text*:
93+
{{ finding_text|safe }}
94+
{% endif %}
95+
96+
9197
*Reporter:* [{{ finding.reporter|full_name}} ({{ finding.reporter.email }})|mailto:{{ finding.reporter.email }}]
9298
{% endfor %}

dojo/templates/issue-trackers/jira_limited/jira-description.tpl

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,4 +9,9 @@
99

1010
*Product/Engagement/Test:* [{{ finding.test.engagement.product.name }}|{{ product_url|full_url }}] / [{{ finding.test.engagement.name }}|{{ engagement_url|full_url }}] / [{{ finding.test }}|{{ test_url|full_url }}]
1111

12-
*Reporter:* [{{ finding.reporter|full_name}} ({{ finding.reporter.email }})|mailto:{{ finding.reporter.email }}]
12+
*Reporter:* [{{ finding.reporter|full_name}} ({{ finding.reporter.email }})|mailto:{{ finding.reporter.email }}]
13+
14+
{% if finding_text %}
15+
*Finding Text*:
16+
{{ finding_text|safe }}
17+
{% endif %}

dojo/templates/issue-trackers/jira_limited/jira-finding-group-description.tpl

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,3 +25,8 @@ Findings:
2525
{% if finding_group.test.engagement.commit_hash %}
2626
*Commit hash:* {{ finding_group.test.engagement.commit_hash }}
2727
{% endif %}
28+
29+
{% if finding_text %}
30+
*Finding Text*:
31+
{{ finding_text|safe }}
32+
{% endif %}

0 commit comments

Comments
 (0)