Remove makemigrations from scripts (#11638)

* remove automatic make migrations

* remove automatic make migrations

* restore unit-tests.sh

Author: valentijnscholten

docker/entrypoint-initializer.sh

@@ -16,7 +16,7 @@ initialize_data()
     python3 manage.py initialize_permissions
 }
 
-create_announcement_banner() 
+create_announcement_banner()
 {
 # Load the announcement banner
 if [ -z "$DD_CREATE_CLOUD_BANNER" ]; then
@@ -103,8 +103,26 @@ then
   exit 47
 fi
 
-echo "Making migrations"
-python3 manage.py makemigrations dojo
+
+python3 manage.py makemigrations --no-input --check --dry-run --verbosity 3 || {
+    cat <<-EOF
+
+********************************************************************************
+
+You made changes to the models without creating a DB migration for them.
+
+**NEVER** change existing migrations, create a new one.
+
+If you're not familiar with migrations in Django, please read the
+great documentation thoroughly:
+https://docs.djangoproject.com/en/5.0/topics/migrations/
+
+********************************************************************************
+
+EOF
+    exit 1
+}
+
 echo "Migrating"
 python3 manage.py migrate
 
@@ -139,7 +157,7 @@ fi
 if [ -z "${ADMIN_EXISTS}" ]
 then
   . /entrypoint-first-boot.sh
-    
+
   create_announcement_banner
   initialize_data
 fi

docker/entrypoint-unit-tests-devDocker.sh

@@ -18,7 +18,25 @@ unset DD_CELERY_BROKER_URL
 
 wait_for_database_to_be_reachable
 
-python3 manage.py makemigrations dojo
+python3 manage.py makemigrations --no-input --check --dry-run --verbosity 3 || {
+    cat <<-EOF
+
+********************************************************************************
+
+You made changes to the models without creating a DB migration for them.
+
+**NEVER** change existing migrations, create a new one.
+
+If you're not familiar with migrations in Django, please read the
+great documentation thoroughly:
+https://docs.djangoproject.com/en/5.0/topics/migrations/
+
+********************************************************************************
+
+EOF
+    exit 1
+}
+
 python3 manage.py migrate
 
 # do the check with Django stack
@@ -56,10 +74,10 @@ echo "------------------------------------------------------------"
 
 # Removing parallel and shuffle for now to maintain stability
 python3 manage.py test unittests -v 3 --keepdb --no-input --exclude-tag="non-parallel" || {
-    exit 1; 
+    exit 1;
 }
 python3 manage.py test unittests -v 3 --keepdb --no-input --tag="non-parallel" || {
-    exit 1; 
+    exit 1;
 }
 
 # you can select a single file to "test" unit tests

docker/entrypoint-unit-tests.sh

@@ -64,7 +64,7 @@ You made changes to the models without creating a DB migration for them.
 
 If you're not familiar with migrations in Django, please read the
 great documentation thoroughly:
-https://docs.djangoproject.com/en/1.11/topics/migrations/
+https://docs.djangoproject.com/en/5.0/topics/migrations/
 
 ********************************************************************************
 
@@ -82,8 +82,8 @@ echo "------------------------------------------------------------"
 
 # Removing parallel and shuffle for now to maintain stability
 python3 manage.py test unittests -v 3 --keepdb --no-input --exclude-tag="non-parallel" || {
-    exit 1; 
+    exit 1;
 }
 python3 manage.py test unittests -v 3 --keepdb --no-input --tag="non-parallel" || {
-    exit 1; 
+    exit 1;
 }

docker/unit-tests.sh

@@ -65,6 +65,12 @@ For changes that require additional settings, you can now use local_settings.py
 ## Python3 Version
 For compatibility reasons, the code in dev branch should be python3.11 compliant.
 
+## Database migrations
+When changes are made to the database model, a database migration is needed. This migration can be generated using something like
+`docker compose exec uwsgi bash -c "python manage.py makemigrations"`.
+This will result in a new file in the `dojo/db_migrations` folder that can be committed to `git`
+When making downstream database model changes in your fork of Defect Dojo please be aware of the risks of getting out of sync with our upstream migrations.
+It requiers proper knowledge of [Django Migrations](https://docs.djangoproject.com/en/5.0/topics/migrations/) to reconcile the migrations before you can upgrade to a newer version of Defect Dojo.
 
 ## Submitting Pull Requests