Ruff: Add and autofix B009 (#11950)

Author: kiblik

dojo/forms.py

@@ -321,7 +321,7 @@ class ProductForm(forms.ModelForm):
     def __init__(self, *args, **kwargs):
         super().__init__(*args, **kwargs)
         self.fields["prod_type"].queryset = get_authorized_product_types(Permissions.Product_Type_Add_Product)
-        if prod_type_id := getattr(kwargs.get("instance", Product()), "prod_type_id"):  # we are editing existing instance
+        if prod_type_id := kwargs.get("instance", Product()).prod_type_id:  # we are editing existing instance
             self.fields["prod_type"].queryset |= Product_Type.objects.filter(pk=prod_type_id)  # even if user does not have permission for any other ProdType we need to add at least assign ProdType to make form submittable (otherwise empty list was here which generated invalid form)
 
         # if this product has findings being asynchronously updated, disable the sla config field

dojo/notifications/helper.py

@@ -807,7 +807,7 @@ def _process_notifications(
         if alert_only:
             logger.debug("sending alert only")
 
-        if "alert" in getattr(notifications, event, getattr(notifications, "other")):
+        if "alert" in getattr(notifications, event, notifications.other):
             logger.debug(f"Sending Alert to {notifications.user}")
             self._get_manager_instance("alert").send_alert_notification(
                 event,
@@ -821,7 +821,7 @@ def _process_notifications(
             if self.system_settings.enable_slack_notifications and "slack" in getattr(
                 notifications,
                 event,
-                getattr(notifications, "other"),
+                notifications.other,
             ):
                 logger.debug("Sending Slack Notification")
                 self._get_manager_instance("slack").send_slack_notification(
@@ -833,7 +833,7 @@ def _process_notifications(
             if self.system_settings.enable_msteams_notifications and "msteams" in getattr(
                 notifications,
                 event,
-                getattr(notifications, "other"),
+                notifications.other,
             ):
                 logger.debug("Sending MSTeams Notification")
                 self._get_manager_instance("msteams").send_msteams_notification(
@@ -845,7 +845,7 @@ def _process_notifications(
             if self.system_settings.enable_mail_notifications and "mail" in getattr(
                 notifications,
                 event,
-                getattr(notifications, "other"),
+                notifications.other,
             ):
                 logger.debug("Sending Mail Notification")
                 self._get_manager_instance("mail").send_mail_notification(
@@ -857,7 +857,7 @@ def _process_notifications(
             if self.system_settings.enable_webhooks_notifications and "webhooks" in getattr(
                 notifications,
                 event,
-                getattr(notifications, "other"),
+                notifications.other,
             ):
                 logger.debug("Sending Webhooks Notification")
                 self._get_manager_instance("webhooks").send_webhooks_notification(

dojo/tools/tenable/xml_format.py

@@ -46,7 +46,7 @@ def safely_get_element_text(self, element):
         if element is None:
             return None
         if hasattr(element, "text"):
-            element_text = getattr(element, "text")
+            element_text = element.text
             if element_text is None:
                 return None
             if isinstance(element_text, str):

ruff.toml

@@ -85,6 +85,7 @@ select = [
    "FURB",
    "DOC202", "DOC403", "DOC502",
    "RUF",
+   "B009",
    "B010",
    "B033",
    "B905",