Skip to content

Commit 395fff4

Browse files
committed
fix to assertions
1 parent 59fa30d commit 395fff4

File tree

2 files changed

+22
-15
lines changed

2 files changed

+22
-15
lines changed

unittests/tools/test_wizcli_iac_parser.py

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -50,29 +50,29 @@ def test_multiple_findings(self):
5050
# Test first finding
5151
finding = findings[0]
5252
self.assertEqual(
53-
"Apk Add Using Local Cache Path - FROM={{registry.gitlab.com/evilorg.com/infra/images/go-lang-1.18-alpine3.17:latest as builder}}.{{RUN apk add --update make git musl-dev gcc}}",
53+
"Bucket usage logs should be enabled - google_storage_bucket[elastic-snapshots]",
5454
finding.title,
5555
)
56-
self.assertEqual("Info", finding.severity)
57-
self.assertEqual("Dockerfile", finding.file_path)
58-
self.assertEqual(8, finding.line)
56+
self.assertEqual("Low", finding.severity)
57+
self.assertEqual("states/dev/storage.tf", finding.file_path)
58+
self.assertEqual(1, finding.line)
5959
self.assertIn(
60-
"**Rule**: Apk Add Using Local Cache Path (ID: `4ac84116-456f-4d60-9e12-187607266faf`)\n"
61-
"**Severity**: Info\n"
62-
"**Resource**: `FROM={{registry.gitlab.com/evilorg.com/infra/images/go-lang-1.18-alpine3.17:latest as builder}}.{{RUN apk add --update make git musl-dev gcc}}`\n"
63-
"**File**: `Dockerfile`\n"
64-
"**Line**: 8\n"
65-
"**Code Snippet**: ```\nRUN apk add --update make git musl-dev gcc\n```\n"
60+
"**Rule**: Bucket usage logs should be enabled (ID: `bd9e69dd-93a1-4122-900a-992135c62572`)\n"
61+
"**Severity**: Low\n"
62+
"**Resource**: `google_storage_bucket[elastic-snapshots]`\n"
63+
"**File**: `states/dev/storage.tf`\n"
64+
"**Line**: 1\n"
65+
'**Code Snippet**: ```\nresource "google_storage_bucket" "elastic-snapshots" {\n```\n'
6666
"\n**Finding Details**:\n"
67-
"- **Expected**: 'RUN' should not contain 'apk add' command without '--no-cache' switch\n"
68-
"- **Found**: 'RUN' contains 'apk add' command without '--no-cache' switch\n"
69-
"- **File Type**: DOCKERFILE",
67+
"- **Expected**: 'logging' should be set\n"
68+
"- **Found**: 'logging' is undefined\n"
69+
"- **File Type**: TERRAFORM",
7070
finding.description,
7171
)
7272
self.assertTrue(finding.static_finding)
7373
self.assertFalse(finding.dynamic_finding)
7474
self.assertTrue(finding.active)
75-
self.assertEqual("4ac84116-456f-4d60-9e12-187607266faf", finding.vuln_id_from_tool)
75+
self.assertEqual("bd9e69dd-93a1-4122-900a-992135c62572", finding.vuln_id_from_tool)
7676

7777
# Test second finding
7878
finding = findings[1]

unittests/tools/test_wizcli_img_parser.py

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,14 @@ def test_multiple_findings(self):
5050
"**Severity**: Medium\n"
5151
"**OS Package**: `curl`\n"
5252
"**Version**: `7.64.0-r5`\n"
53-
"**Source**: https://security.alpinelinux.org/vuln/CVE-2023-38039",
53+
"**Fixed Version**: N/A\n"
54+
"**Source**: https://security.alpinelinux.org/vuln/CVE-2023-38039\n"
55+
"**CVSS Score (from Wiz)**: 7.5\n"
56+
"**Has Exploit (Known)**: True\n"
57+
"**In CISA KEV**: False\n\n"
58+
"**Ignored Policies**:\n"
59+
"- test Default vulnerabilities policy (ID: 9c6726d0-1ada-4541-b6d6-3da5ca1124f9)\n"
60+
"- test Default vulnerabilities policy ( Updated ) (ID: 9bf73b16-99e7-4a54-af1e-dcfa1436a8f2)",
5461
finding.description,
5562
)
5663
self.assertEqual("CVE-2023-38039", finding.cve)

0 commit comments

Comments
 (0)