Skip to content

Commit 28eb058

Browse files
littlesvenssonlittlesvensson
authored
Added labels for checkbox column headers (#11819)
1 parent 30a5f9c commit 28eb058

File tree

2 files changed

+30
-30
lines changed

2 files changed

+30
-30
lines changed

‎dojo/templates/dojo/endpoints.html

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -70,25 +70,25 @@ <h3 class="has-filters">
7070
class="tablesorter-bootstrap table table-condensed table-striped table-hover">
7171
<tr>
7272
{% if not product_tab or product_tab and product_tab.product|has_object_permission:"Endpoint_Edit" %}
73-
<th class="centered" title="Select all visible endpoint." id="bulk_edit">
73+
<th class="centered" title="Select all visible endpoints." aria-label="Select all visible endpoints." id="bulk_edit" scope="col">
7474
<form class="inline-form centered" action="#">
75-
<input type="checkbox" title="Select All" name="select_all" id="select_all"></input>
75+
<input aria-label="Select all visible endpoints checkbox" type="checkbox" title="Select All" name="select_all" id="select_all"></input>
7676
</form>
7777
</th>
7878
{% endif %}
7979
{% if host_view %}
8080
{% comment %} The display field is translated in the function. No need to translate here as well{% endcomment %}
81-
<th>{% dojo_sort request 'Host' 'host' %}</th>
81+
<th scope="col">{% dojo_sort request 'Host' 'host' %}</th>
8282
{% else %}
8383
{% comment %} The display field is translated in the function. No need to translate here as well{% endcomment %}
84-
<th>{% dojo_sort request 'Endpoint' 'endpoint' %}</th>
84+
<th scope="col">{% dojo_sort request 'Endpoint' 'endpoint' %}</th>
8585
{% endif %}
8686
{% if not product_tab %}
8787
{% comment %} The display field is translated in the function. No need to translate here as well{% endcomment %}
88-
<th>{% dojo_sort request 'Product' 'product' 'asc' %}</th>
88+
<th scope="col">{% dojo_sort request 'Product' 'product' 'asc' %}</th>
8989
{% endif %}
90-
<th class="text-center" nowrap="nowrap">Active (Verified) Findings</th>
91-
<th>Status</th>
90+
<th class="text-center" nowrap="nowrap" scope="col">Active (Verified) Findings</th>
91+
<th scope="col">Status</th>
9292
</tr>
9393

9494
{% for e in endpoints %}

‎dojo/templates/dojo/findings_list_snippet.html

Lines changed: 23 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -273,17 +273,17 @@ <h3 class="has-filters">
273273
<tr>
274274
{% block header %}
275275
{% if not product_tab or product_tab and product_tab.product|has_object_permission:"Finding_Edit" %}
276-
<th class="centered" title="Select all visible findings.">
276+
<th class="centered" title="Select all visible findings." scope="col" aria-label="Select all visible findings">
277277
<div class="dropdown">
278278
<button class="btn btn-primary dropdown-toggle"
279279
type="button"
280280
id="dropdownMenu1"
281281
data-toggle="dropdown"
282282
aria-haspopup="true"
283283
aria-expanded="true"
284-
aria-label="Select all findings dropdown">
284+
aria-label="Select findings by severity dropdown">
285285
<form class="inline-form" action="#">
286-
<input type="checkbox" name="select_all" id="select_all" aria-label="select-all"/>
286+
<input type="checkbox" name="select_all" id="select_all" aria-label="select all findings checkbox"/>
287287
</form>
288288
<span class="caret"></span>
289289
</button>
@@ -317,26 +317,26 @@ <h3 class="has-filters">
317317
</th>
318318
{% endif %}
319319
<th></th>
320-
<th class="nowrap centered severity-sort">
320+
<th class="nowrap centered severity-sort" scope="col">
321321
{% trans "Severity" %}
322322
</th>
323-
<th class="nowrap">
323+
<th class="nowrap" scope="col">
324324
{% comment %} The display field is translated in the function. No need to translate here as well{% endcomment %}
325325
{% dojo_sort request 'Name' 'title' %}
326326
</th>
327-
<th>
327+
<th scope="col">
328328
{% trans "CWE" %}
329329
</th>
330-
<th>
330+
<th scope="col">
331331
{% trans "Vulnerability Id" %}
332332
</th>
333-
<th>
333+
<th scope="col">
334334
{% trans "EPSS Score" %}
335335
</th>
336-
<th>
336+
<th scope="col">
337337
{% trans "EPSS Percentile" %}
338338
</th>
339-
<th class="nowrap">
339+
<th class="nowrap" scope="col">
340340
{% if filter_name == 'Closed' %}
341341
{% comment %} The display field is translated in the function. No need to translate here as well{% endcomment %}
342342
{% dojo_sort request 'Closed Date' 'mitigated' %}
@@ -345,55 +345,55 @@ <h3 class="has-filters">
345345
{% dojo_sort request 'Date' 'date' %}
346346
{% endif %}
347347
</th>
348-
<th class="nowrap">
348+
<th class="nowrap" scope="col">
349349
{% trans "Age" %}
350350
</th>
351351
{% if system_settings.enable_finding_sla %}
352-
<th>
352+
<th scope="col">
353353
{% trans "SLA" %}
354354
</th>
355355
{% endif %}
356-
<th>
356+
<th scope="col">
357357
{% trans "Reporter" %}
358358
</th>
359-
<th>
359+
<th scope="col">
360360
{% trans "Found By" %}
361361
</th>
362-
<th>
362+
<th scope="col">
363363
{% trans "Status" %}
364364
</th>
365365
{% if system_settings.enable_jira %}
366366
{% if jira_project and product_tab or not product_tab %}
367-
<th>
367+
<th scope="col">
368368
{% trans "Jira" %}
369369
</th>
370-
<th>
370+
<th scope="col">
371371
{% trans "JIRA Age" %}
372372
</th>
373-
<th>
373+
<th scope="col">
374374
{% trans "JIRA Change" %}
375375
</th>
376376
{% endif %}
377377
{% endif %}
378378
{% if 'is_finding_groups_enabled'|system_setting_enabled %}
379-
<th>
379+
<th scope="col">
380380
{% trans "Group" %}
381381
</th>
382382
{% endif %}
383383
{% if show_product_column and product_tab is None %}
384-
<th class="nowrap">
384+
<th class="nowrap" scope="col">
385385
{% comment %} The display field is translated in the function. No need to translate here as well{% endcomment %}
386386
{% dojo_sort request 'Product' 'test__engagement__product__name' %}
387387
</th>
388388
{% endif %}
389-
<th>
389+
<th scope="col">
390390
{% trans "Service" %}
391391
</th>
392-
<th>
392+
<th scope="col">
393393
{% trans "Planned Remediation" %}
394394
</th>
395395
{% if filter_name != 'Closed' %}
396-
<th>
396+
<th scope="col">
397397
{% trans "Reviewers" %}
398398
</th>
399399
{% endif %}

0 commit comments

Comments
 (0)