Skip to content

Commit 19bab59

Browse files
remove defusedxml in favor of lxml (#9840)
* update to docs * fix
1 parent afa58cf commit 19bab59

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

docs/content/en/contributing/how-to-write-a-parser.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -142,6 +142,12 @@ Very bad example:
142142
finding.unsaved_endpoints = [endpoint]
143143
```
144144

145+
### Use the right libraries to parse information
146+
Various file formats are handled through libraries. In order to keep DefectDojo slim and also don't extend the attack surface, keep the number of libraries used minimal and take other parsers as an example.
147+
148+
#### defusedXML in favour of lxml
149+
As xml is by default an unsecure format, the information parsed from various xml output has to be parsed in a secure way. Within an evaluation, we determined that defusedXML is the library which we will use in the future to parse xml files in parsers as this library is rated more secure. Thus, we will only accept PRs with the defusedxml library.
150+
145151
### Not all attributes are mandatory
146152

147153
Parsers may have many fields, out of which many of them may be optional.

0 commit comments

Comments
 (0)