Replies: 3 comments
-
In case it wasn't clear, from the user perspective, this would mean if your vacuum isn't supported you have to check a box ini the HA configuration GUI to enable equivalence testing, and the select a model you think is "close". Then if it doesn't work, the idea is you'd get some logs messages you could submit to the issue tracker on this repo which would give people like a hint as to what to fix. By contrast today asking a dev to support a new model... well without API information it's all just a complete guess, and could be dangerously wrong. |
Beta Was this translation helpful? Give feedback.
-
This would be a vast improvement over the current process to try and get our devices working again. It's sad to see there's been no other feedback on this proposal so far. |
Beta Was this translation helpful? Give feedback.
-
I don't know how to add it as HA has some guidelines and adding your proposal would not comply with them. Different models create different entities and dynamically changing/adding/removing entities is a mess for the user and also something we should avoid. Adding such a option in the config flow is not allowed for core integrations. (For sure I will not create a custom component for this feature) Also, from a maintainer's perspective, your idea is not great as the fallback devices before removing were creating a warning log entry for more than 2 years, and only a few users gave me feedback. By eliminating the fallback, I was able to add more than 30 models in a single week. Before that only 10 models were supported properly. Thanks for your proposal but for now I will reject it as it would make maintaining this integration harder |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
-
@edenhaus have you considered a "model equivalence testing" switch and drop down in the HA config? After checking a box (that they understand this is experimental) the user could be presented with a list of model numbers and names (e.g. "1vxt52 - X1 Omni") allowing them to select something similar with a warning that this is not guaranteed to work and they can expect ZERO support without the log messages.
If we coupled that with log messages that have copy/paste information for the issue tracker, for example: "using model ABC as XYZ, there was a failure executing 123, please copy and paste this text into [Insert link to a new issue template]". The UI during configuration could even tell them to read the logs, and that they'll need to file issues.
This would:
I admit my skills aren't really up to adding that as a feature right now, mostly because I don't know the integration UI code at all.
Overall, I think the changes are:
Beta Was this translation helpful? Give feedback.
All reactions