test_util: Implement test for get_combobox_index_by_value (#533)

* test_util: Implement test for `get_combobox_index_by_value`

* test_util: Improve handling of QApplication

* test_ctmods: Improve handling of QApplication

---------

Co-authored-by: DavidoTek <54072917+DavidoTek@users.noreply.github.com>

Author: sonic2kk

tests/test_ctmods.py

@@ -14,7 +14,7 @@ def test_ctmod_loader() -> None:
     """
     Test loading of ctmods using CtLoader.
     """
-    QApplication()
+    app = QApplication()
 
     dummy_main_window = DummyMainWindow({})
 
@@ -29,3 +29,5 @@ def test_ctmod_loader() -> None:
 
     # Ensure that no advanced mode ctmods are loaded when advanced_mode is False
     assert(all(["advmode" not in ctmod.CT_LAUNCHERS for ctmod in ct_loader.get_ctmods(launcher=None, advanced_mode=False)]))
+
+    QApplication.shutdown(app)

tests/test_util.py

@@ -303,3 +303,26 @@ def test_compat_tool_available(compat_tool_name: str, ctobjs: list[dict[str, str
     result: bool = compat_tool_available(compat_tool_name, ctobjs)
 
     assert result == expected
+
+
+@pytest.mark.parametrize(
+    'combobox_values, value, expected_index', [
+        pytest.param(['a', 'b', 'c', 'd', 'e'], 'c', 2, id = 'Simple list'),
+        pytest.param(['Steam', 'Lutris',' Heroic'], 'Lutris', 1, id = 'List of Launcher Names'),
+        pytest.param(['GE-Proton', 'Proton-tkg', 'SteamTinkerLaunch'], 'SteamTinkerLaunch', 2, id = 'List of Compatibility Tool names'),
+    ]
+)
+def test_get_combobox_index_by_value(combobox_values: list[str], value: str, expected_index: int) -> None:
+
+    app = QApplication()
+
+    combobox: QComboBox = QComboBox()
+
+    combobox.addItems(combobox_values)
+
+    result: int = get_combobox_index_by_value(combobox, value)
+
+    assert combobox_values[result] == value
+    assert result == expected_index
+
+    QApplication.shutdown(app)