vkd3d-proton: Refactor to use download_file (#526)

Author: sonic2kk

pupgui2/resources/ctmods/ctmod_vkd3dproton.py

@@ -6,8 +6,11 @@
 import requests
 
 from PySide6.QtCore import QObject, QCoreApplication, Signal, Property
+from PySide6.QtWidgets import QMessageBox
+
 
 from pupgui2.datastructures import Launcher
+from pupgui2.networkutil import download_file
 from pupgui2.util import extract_tar, extract_tar_zst, get_launcher_from_installdir
 from pupgui2.util import build_headers_with_authorization, fetch_project_release_data, fetch_project_releases
 
@@ -24,6 +27,7 @@ class CtInstaller(QObject):
 
     p_download_progress_percent = 0
     download_progress_percent = Signal(int)
+    message_box_message = Signal((str, str, QMessageBox.Icon))
 
     def __init__(self, main_window = None):
         super(CtInstaller, self).__init__()
@@ -48,35 +52,29 @@ def __set_download_progress_percent(self, value : int):
         self.p_download_progress_percent = value
         self.download_progress_percent.emit(value)
 
-    def __download(self, url, destination):
+    def __download(self, url: str, destination: str) -> bool:
         """
         Download files from url to destination
         Return Type: bool
         """
+        
         try:
-            file = self.rs.get(url, stream=True)
-        except OSError:
-            return False
+            return download_file(
+                url=url,
+                destination=os.path.expanduser(destination),
+                progress_callback=self.__set_download_progress_percent,
+                download_cancelled=self.download_canceled,
+            )
+        except Exception as e:
+            print(f"Failed to download tool {CT_NAME} - Reason: {e}")
+
+            self.message_box_message.emit(
+                self.tr("Download Error!"),
+                self.tr("Failed to download tool '{CT_NAME}'!\n\nReason: {EXCEPTION}".format(CT_NAME=CT_NAME, EXCEPTION=e)),
+                QMessageBox.Icon.Warning
+            )
 
-        self.__set_download_progress_percent(1) # 1 download started
-        f_size = int(file.headers.get('content-length'))
-        c_count = int(f_size / self.BUFFER_SIZE)
-        c_current = 1
-        destination = os.path.expanduser(destination)
-        os.makedirs(os.path.dirname(destination), exist_ok=True)
-        with open(destination, 'wb') as dest:
-            for chunk in file.iter_content(chunk_size=self.BUFFER_SIZE):
-                if self.download_canceled:
-                    self.download_canceled = False
-                    self.__set_download_progress_percent(-2) # -2 download canceled
-                    return False
-                if chunk:
-                    dest.write(chunk)
-                    dest.flush()
-                self.__set_download_progress_percent(int(min(c_current / c_count * 98.0, 98.0))) # 1-98, 100 after extract
-                c_current += 1
-        self.__set_download_progress_percent(99) # 99 download complete
-        return True
+            return False
 
     def __fetch_github_data(self, tag):
         """