Incorrect line number in "no such constant" error

[erkyrath]

In this example:

[ Main; func(); ];

Object obj
  with before [;
	Frotz: return 1;    ! line 5
  ];

[ func;
	return Frotz;    ! line 9
];

Verb 'frotz' * -> Frotz;
[ FrotzSub; ];

...we get this error:

line 5: Error: No such constant as "Frotz"

The error is correct but the line number is not. Line 5 is a correct use of the ##Frotz action constant. It's line 9 that's wrong.

This only seems to occur when a switch-style use of the action constant (without ##) occurs before the erroneous symbol use. If I change the before property to

  with before [;
	if (sw__var == ##Frotz) return 1;
  ];

...then the error is correctly reported.

[erkyrath]

The quick analysis is that we encounter the symbol in parse_routine(), line 509. At this point we don't know it's an action so we add it as an undefined symbol.

We then enter the switch_clause_made = TRUE stanza, which puts the token back and reparses it ( parse_switch_spec(AO, switch_label, TRUE)). Putting the freshly-defined token back erases it from the symbol table, but then the parse_switch_spec() call re-encounters and redefines it.

Possibly we just need to tweak the get_next_token() call (inside the if (action_switch) stanza).