Skip to content

Commit 819f968

Browse files
authored
Merge pull request #34 from DataRecce/chore/restructure-the-js-structure
[Chore] Update the js project structure
2 parents bac5fc3 + b36c7c4 commit 819f968

22 files changed

+30
-37
lines changed

js/app/page.tsx

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,10 @@
11
"use client";
22

3-
import DiffView from "@/components/DiffView";
4-
import LineageView from "@/components/lineagediff/LineageView";
3+
import QueryView from "@/components/query/QueryView";
4+
import LineageView from "@/components/lineage/LineageView";
55
import { Tabs, TabList, Tab, TabPanels, TabPanel } from "@chakra-ui/react";
66
import { useLayoutEffect } from "react";
7-
import * as amplitude from '@amplitude/analytics-browser';
8-
9-
7+
import * as amplitude from "@amplitude/analytics-browser";
108

119
function getCookie(key: string) {
1210
var b = document.cookie.match("(^|;)\\s*" + key + "\\s*=\\s*([^;]+)");
@@ -20,7 +18,7 @@ export default function Home() {
2018
try {
2119
// Initialize Amplitude
2220
amplitude.init(process.env.AMPLITUDE_API_KEY, userId, {
23-
defaultTracking: true,
21+
defaultTracking: true,
2422
});
2523
} catch (e) {
2624
console.error(e);
@@ -40,7 +38,7 @@ export default function Home() {
4038
<LineageView />
4139
</TabPanel>
4240
<TabPanel p={0}>
43-
<DiffView />
41+
<QueryView />
4442
</TabPanel>
4543
</TabPanels>
4644
</Tabs>

js/src/components/lineagediff/GraphEdge.tsx renamed to js/src/components/lineage/GraphEdge.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
import { BaseEdge, EdgeProps, getBezierPath } from "reactflow";
2-
import { LineageGraphEdge } from "./lineagediff";
2+
import { LineageGraphEdge } from "./lineage";
33
import { getIconForChangeStatus } from "./styles";
44

5-
import "./lineagediff.css";
5+
import "./styles.css";
66

77
interface GraphEdgeProps extends EdgeProps<LineageGraphEdge> {}
88

js/src/components/lineagediff/GraphNode.tsx renamed to js/src/components/lineage/GraphNode.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,10 @@ import { Box, Flex, Icon, Text, Tooltip } from "@chakra-ui/react";
22
import React from "react";
33

44
import { Handle, NodeProps, Position, useStore } from "reactflow";
5-
import { LineageGraphNode } from "./lineagediff";
5+
import { LineageGraphNode } from "./lineage";
66
import { getIconForChangeStatus, getIconForResourceType } from "./styles";
77

8-
import "./lineagediff.css";
8+
import "./styles.css";
99

1010
interface GraphNodeProps extends NodeProps<LineageGraphNode> {}
1111

js/src/components/lineagediff/LineageView.tsx renamed to js/src/components/lineage/LineageView.tsx

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
1-
import { PUBLIC_API_URL } from "@/const";
1+
import { PUBLIC_API_URL } from "@/lib/const";
22
import {
33
LineageGraph,
44
buildLineageGraph,
55
highlightPath,
66
toReactflow,
7-
} from "./lineagediff";
7+
} from "./lineage";
88
import { Box, Flex, Icon, Tooltip, useDisclosure } from "@chakra-ui/react";
99
import axios, { AxiosError } from "axios";
1010
import React, { useCallback, useEffect, useState } from "react";
@@ -17,9 +17,7 @@ import ReactFlow, {
1717
MiniMap,
1818
Panel,
1919
Background,
20-
BackgroundVariant,
2120
ReactFlowProvider,
22-
useReactFlow,
2321
} from "reactflow";
2422
import dagre from "dagre";
2523
import "reactflow/dist/style.css";

js/src/components/lineagediff/NodeView.tsx renamed to js/src/components/lineage/NodeView.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@ import {
1010
Tabs,
1111
VStack,
1212
} from "@chakra-ui/react";
13-
import { LineageGraphNode, NodeData } from "./lineagediff";
14-
import { SchemaView } from "../schemadiff/SchemaView";
13+
import { LineageGraphNode } from "./lineage";
14+
import { SchemaView } from "../schema/SchemaView";
1515

1616
interface NodeViewProps {
1717
node: LineageGraphNode;

js/src/components/lineagediff/lineagediff.test.ts renamed to js/src/components/lineage/lineage.test.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,14 @@
11
import {
22
LineageData,
3-
LineageGraph,
43
LineageGraphEdge,
54
LineageGraphNode,
65
buildLineageGraph,
76
highlightPath,
87
toReactflow,
9-
} from "./lineagediff";
8+
} from "./lineage";
109
import { Node, Edge } from "reactflow";
1110

1211
import { find } from "lodash";
13-
import { queryDiff } from "../../querydiff";
1412

1513
test("lineage diff", () => {
1614
const base = {

js/src/components/lineagediff/lineagediff.ts renamed to js/src/components/lineage/lineage.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
import _ from "lodash";
2-
import "@/styles/diff.css";
32
import { Node, Edge, Position } from "reactflow";
43
import { getNeighborSet } from "./graph";
54

js/src/components/DiffView.tsx renamed to js/src/components/query/QueryView.tsx

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2,24 +2,24 @@ import "react-data-grid/lib/styles.css";
22
import React, { useState, useEffect, useCallback, useMemo } from "react";
33
import DataGrid, { ColumnOrColumnGroup } from "react-data-grid";
44
import axios, { AxiosError } from "axios";
5-
import { DataFrame, queryDiff } from "@/querydiff";
6-
import { PUBLIC_API_URL } from "@/const";
5+
import { DataFrame, queryDiff } from "@/components/query/query";
6+
import { PUBLIC_API_URL } from "../../lib/const";
77
import { Box, Button, Flex, Textarea } from "@chakra-ui/react";
88

9-
interface DiffViewDataGridProps {
9+
interface QueryViewDataGridProps {
1010
loading: boolean;
1111
error?: string;
1212
errorStep?: string;
1313
columns: any;
1414
rows: any;
1515
}
16-
const DiffViewDataGrid = ({
16+
const QueryViewDataGrid = ({
1717
loading,
1818
error,
1919
errorStep,
2020
columns,
2121
rows,
22-
}: DiffViewDataGridProps) => {
22+
}: QueryViewDataGridProps) => {
2323
if (loading) {
2424
return <>Loading...</>;
2525
}
@@ -47,7 +47,7 @@ const DiffViewDataGrid = ({
4747
);
4848
};
4949

50-
const DiffView = () => {
50+
const QueryView = () => {
5151
const [query, setQuery] = useState('select * from {{ ref("mymodel") }}');
5252

5353
const [loading, setLoading] = useState(false);
@@ -144,7 +144,7 @@ const DiffView = () => {
144144
style={{ width: "100%" }}
145145
/>
146146
<Box backgroundColor="gray.100" height="50vh">
147-
<DiffViewDataGrid
147+
<QueryViewDataGrid
148148
loading={loading}
149149
error={error}
150150
errorStep={errorStep}
@@ -156,4 +156,4 @@ const DiffView = () => {
156156
);
157157
};
158158

159-
export default DiffView;
159+
export default QueryView;

js/src/querydiff.test.ts renamed to js/src/components/query/query.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { queryDiff } from "./querydiff";
1+
import { queryDiff } from "./query";
22

33
test("query diff", () => {
44
const base = {

js/src/querydiff.tsx renamed to js/src/components/query/query.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { ColumnOrColumnGroup, textEditor } from "react-data-grid";
22
import _ from "lodash";
3-
import "./styles/diff.css";
3+
import "./styles.css";
44
import { Box, Flex, Icon } from "@chakra-ui/react";
55
import { VscClose, VscKey } from "react-icons/vsc";
66

File renamed without changes.

js/src/components/schemadiff/SchemaView.tsx renamed to js/src/components/schema/SchemaView.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { useMemo } from "react";
2-
import { NodeColumnData } from "../lineagediff/lineagediff";
3-
import { mergeColumns, toDataGrid } from "./schemadiff";
2+
import { NodeColumnData } from "../lineage/lineage";
3+
import { mergeColumns, toDataGrid } from "./schema";
44
import "react-data-grid/lib/styles.css";
55
import DataGrid from "react-data-grid";
66

js/src/components/schemadiff/schemadiff.test.ts renamed to js/src/components/schema/schema.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
import { NodeData } from "../lineagediff/lineagediff";
2-
import { mergeColumns } from "./schemadiff";
1+
import { NodeData } from "../lineage/lineage";
2+
import { mergeColumns } from "./schema";
33

44
function _schema(columns: { [key: string]: string }): NodeData["columns"] {
55
const result: ReturnType<typeof _schema> = {};

js/src/components/schemadiff/schemadiff.tsx renamed to js/src/components/schema/schema.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
import { mergeKeysWithStatus } from "@/mergeKeys";
2-
import { NodeData } from "../lineagediff/lineagediff";
1+
import { mergeKeysWithStatus } from "@/lib/mergeKeys";
2+
import { NodeData } from "../lineage/lineage";
33
import { Column, ColumnOrColumnGroup, RenderCellProps } from "react-data-grid";
44

55
import "./style.css";
File renamed without changes.
File renamed without changes.
File renamed without changes.

0 commit comments

Comments
 (0)