Skip to content

Commit 68c4481

Browse files
authored
Merge pull request #755 from DataRecce/feature/drc-1350-in-cll-dont-hightlight-no-impacted-model-if-the-model-is-not
[Enhancement] Dont highlight the model if it is not in the impact radius
2 parents cf7ec2c + 9bbd9ba commit 68c4481

File tree

2 files changed

+3
-16
lines changed

2 files changed

+3
-16
lines changed

js/src/components/lineage/GraphColumnNode.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ export function GraphColumnNode(nodeProps: GrapeColumnNodeProps) {
7878
width="280px"
7979
height="16px"
8080
padding="0px 10px"
81-
border="1px solid lightgray"
81+
border="1px solid gray"
8282
backgroundColor={isFocus ? "#f0f0f0" : "inherit"}
8383
_hover={{
8484
backgroundColor: isFocus ? "#f0f0f0" : "#f0f0f0",
@@ -89,7 +89,7 @@ export function GraphColumnNode(nodeProps: GrapeColumnNodeProps) {
8989
onMouseLeave={() => {
9090
setIsHovered(false);
9191
}}>
92-
<Flex fontSize="10px" color="gray" width="100%" gap="3px" alignItems="center">
92+
<Flex fontSize="11px" color="gray" width="100%" gap="3px" alignItems="center">
9393
{changeStatus && (
9494
<Icon
9595
boxSize="12px"

js/src/components/lineage/LineageView.tsx

Lines changed: 1 addition & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -319,19 +319,7 @@ export function PrivateLineageView(
319319
}
320320

321321
if (viewOptions.column_level_lineage) {
322-
const nodesContainsColumns = nodeColumnSetMap
323-
? new Set(
324-
Object.entries(nodeColumnSetMap)
325-
.filter(([_, columnSet]) => {
326-
return columnSet.size > 0;
327-
})
328-
.map(([nodeId, _]) => {
329-
return nodeId;
330-
}),
331-
)
332-
: new Set<string>();
333-
const nodesInCLL = cllNodeIds ?? new Set<string>();
334-
return union(nodesContainsColumns, nodesInCLL);
322+
return cllNodeIds ?? new Set<string>();
335323
}
336324

337325
if (focusedNode) {
@@ -354,7 +342,6 @@ export function PrivateLineageView(
354342
lineageGraph,
355343
selectMode,
356344
viewOptions.column_level_lineage,
357-
nodeColumnSetMap,
358345
focusedNode,
359346
isModelsChanged,
360347
multiNodeAction.actionState.actions,

0 commit comments

Comments
 (0)