Add support for Node 23 (#175)

* Add support for Node 23

* Use comma for skips

* Update package-lock.json

* Add extra permissions to package-size

* update ASAN suppressions

* Add node 22 benchmark

* Switch to c++20

---------

Co-authored-by: Nicolas Savoire <nicolas.savoire@datadoghq.com>

Author: szegedi

.github/workflows/build.yml

@@ -10,7 +10,7 @@ jobs:
   asan:
     strategy:
       matrix:
-        version: [16, 18, 20, 22]
+        version: [16, 18, 20, 22, 23]
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v3
@@ -23,7 +23,7 @@ jobs:
   valgrind:
     strategy:
       matrix:
-        version: [16, 18, 20, 22]
+        version: [16, 18, 20, 22, 23]
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v3
@@ -41,7 +41,7 @@ jobs:
       package-manager: 'npm' # npm or yarn
       cache: true # enable caching of dependencies based on lockfile
       min-node-version: 16
-      skip: 'linux-arm linux-ia32' # skip building for these platforms
+      skip: 'linux-arm,linux-ia32' # skip building for these platforms
 
   dev_publish:
     needs: build

.github/workflows/package-size.yml

@@ -12,6 +12,8 @@ concurrency:
 jobs:
   package-size-report:
     runs-on: ubuntu-latest
+    permissions:
+      pull-requests: write
     steps:
       - uses: actions/checkout@v2
       - name: Setup Node.js

.github/workflows/release.yml

@@ -13,7 +13,7 @@ jobs:
       package-manager: 'npm' # npm or yarn
       cache: true # enable caching of dependencies based on lockfile
       min-node-version: 16
-      skip: 'linux-arm linux-ia32' # skip building for these platforms
+      skip: 'linux-arm,linux-ia32' # skip building for these platforms
 
   publish:
     needs: build

.gitlab/benchmarks.yml

@@ -32,6 +32,7 @@ benchmarks:
       - MAJOR_NODE_VERSION: 16
       - MAJOR_NODE_VERSION: 18
       - MAJOR_NODE_VERSION: 20
+      - MAJOR_NODE_VERSION: 22
   artifacts:
     name: "reports"
     paths:

binding.gyp

@@ -62,18 +62,18 @@
                         'VCCLCompilerTool': {
                             'AdditionalOptions': [
                                 '/Zc:__cplusplus',
-                                '-std:c++17',
+                                '-std:c++20',
                             ],
-                        },                        
+                        },
                     },
                 },
             ],
             ["OS == 'linux'",
                 {
                 "cflags+":
                     ["-Wno-deprecated-declarations", "-Werror"],
-                "cflags_cc!": ["-std=gnu++14", "-std=gnu++1y"],
-                "cflags_cc": ["-std=gnu++17"],
+                "cflags_cc!": ["-std=gnu++14", "-std=gnu++1y", "-std=gnu++20" ],
+                "cflags_cc": ["-std=gnu++2a"],
                 }
             ],
             ["OS == 'mac'",
@@ -82,7 +82,7 @@
                     'OTHER_CFLAGS+': [
                         "-Wno-deprecated-declarations",
                         "-Werror",
-                        '-std=gnu++17',
+                        '-std=gnu++20',
                         ],
                     },
                 }

package-lock.json

@@ -26,7 +26,7 @@
     "test:js-tsan": "LD_PRELOAD=`gcc -print-file-name=libtsan.so` mocha out/test/test-*.js",
     "test:js-valgrind": "valgrind --leak-check=full mocha out/test/test-*.js",
     "test:js": "nyc mocha -r source-map-support/register out/test/test-*.js",
-    "test": "npm run test:js && npm run test:cpp"
+    "test": "npm run test:js"
   },
   "author": {
     "name": "Google Inc."
@@ -55,7 +55,7 @@
     "gts": "^4.0.1",
     "js-green-licenses": "^4.0.0",
     "mocha": "^10.2.0",
-    "nan": "^2.19.0",
+    "nan": "^2.22.0",
     "nyc": "^15.1.0",
     "sinon": "^15.2.0",
     "source-map-support": "^0.5.21",

package.json

@@ -1 +1 @@
-leak:PKCS5_PBKDF2_HMAC
+leak:CRYPTO_zalloc