Add support for node 22 (#169)

* Test on node 22

* Test improvements

* Update nan to 2.19.0 for Node 22

* Fix wall profiler test for node 22 on MacOS

With node 22, many deopt events are generated by `setContext` call in
`fn0`.
On MacOS, `v8::TimeTicks::Now` has a resolution of ~42us because
`mach_absolute_time` ticks (a tick is ~42ns) conversion to microseconds
is done in such a way that drops the 3 least significant digits.
This two facts lead to samples having identical timestamps, and
incorrectly matched contexts.
Workaround here just ensures that after deopt event caused by `setContext`,
no sample in `fn1` is immediately taken.

* Fix eslint warning

---------

Co-authored-by: Attila Szegedi <attila.szegedi@datadoghq.com>

Author: nsavoire

.github/workflows/build.yml

@@ -10,7 +10,7 @@ jobs:
   asan:
     strategy:
       matrix:
-        version: [14, 16, 18, 20, 21]
+        version: [14, 16, 18, 20, 22]
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v3
@@ -23,7 +23,7 @@ jobs:
   valgrind:
     strategy:
       matrix:
-        version: [14, 16, 18, 20, 21]
+        version: [14, 16, 18, 20, 22]
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v3

package-lock.json

@@ -55,7 +55,7 @@
     "gts": "^4.0.1",
     "js-green-licenses": "^4.0.0",
     "mocha": "^10.2.0",
-    "nan": "^2.18.0",
+    "nan": "^2.19.0",
     "nyc": "^15.1.0",
     "sinon": "^15.2.0",
     "source-map-support": "^0.5.21",

package.json

@@ -1229,8 +1229,8 @@ export const labelEncodingProfile = {
 
 const {hasOwnProperty} = Object.prototype;
 
-// eslint-disable-next-line @typescript-eslint/no-explicit-any
 export function getAndVerifyPresence(
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any
   list: any[],
   id: number,
   zeroIndex = false

ts/test/profiles-for-tests.ts

@@ -141,7 +141,7 @@ describe('Time Profiler', () => {
             labels[key] = value;
             if (
               enableEndPoint &&
-              key === 'local root span id' &&
+              key === rootSpanIdLabel &&
               value === rootSpanId
             ) {
               labels[endPointLabel] = endPoint;
@@ -164,6 +164,17 @@ describe('Time Profiler', () => {
         const start = hrtime.bigint();
         while (hrtime.bigint() - start < intervalNanos);
         time.setContext(undefined);
+        // With node 22, many deopt events are generated by `setContext` call above.
+        // On MacOS, `v8::TimeTicks::Now` has a resolution of ~42us because
+        // `mach_absolute_time` ticks (a tick is ~42ns) conversion to microseconds
+        // is done in such a way that drops the 3 least significant digits
+        // (https://github.com/nodejs/node/blob/v22.x/deps/v8/src/base/platform/time.cc#L745-L746).
+        // This two facts lead to samples having identical timestamps, and
+        // incorrectly matched contexts.
+        // Workaround here just ensures that after deopt event caused by `setContext`,
+        // no sample in `fn1` is immediately taken.
+        const start2 = hrtime.bigint();
+        while (hrtime.bigint() - start2 < intervalNanos);
       }
 
       function fn1() {
@@ -192,11 +203,12 @@ describe('Time Profiler', () => {
       function validateProfile(profile: Profile) {
         // Get string table indices for strings we're interested in
         const stringTable = profile.stringTable;
-        const [loopIdx, fn0Idx, fn1Idx, fn2Idx] = [
+        const [loopIdx, fn0Idx, fn1Idx, fn2Idx, hrtimeBigIntIdx] = [
           'loop',
           'fn0',
           'fn1',
           'fn2',
+          'hrtimeBigInt',
         ].map(x => stringTable.dedup(x));
 
         function getString(n: number | bigint): string {
@@ -219,7 +231,9 @@ describe('Time Profiler', () => {
         }
 
         function labelStr(label: Label) {
-          return label ? stringTable.strings[idx(label.str) + 1] : 'undefined';
+          return label
+            ? `${getString(label.key)}=${getString(label.str)}`
+            : 'undefined';
         }
 
         function getLabels(labels: Label[]) {
@@ -234,19 +248,25 @@ describe('Time Profiler', () => {
         let fn1ObservedWithLabel1 = false;
         let fn2ObservedWithoutLabels = false;
         profile.sample.forEach(sample => {
-          const locIdx = idx(sample.locationId[0]);
-          const loc = profile.location[locIdx];
-          const fnIdx = idx(loc.line[0].functionId);
-          const fn = profile.function[fnIdx];
-          const fnName = fn.name;
+          let fnName;
+          for (const locationId of sample.locationId) {
+            const locIdx = idx(locationId);
+            const loc = profile.location[locIdx];
+            const fnIdx = idx(loc.line[0].functionId);
+            const fn = profile.function[fnIdx];
+            fnName = fn.name;
+            if (fnName !== hrtimeBigIntIdx) {
+              break;
+            }
+          }
           const labels = sample.label;
 
           switch (fnName) {
             case loopIdx:
               if (enableEndPoint) {
                 assert(
                   labels.length < 4,
-                  'loop can have at most one label and one endpoint'
+                  'loop can have at most two labels and one endpoint'
                 );
                 labels.forEach(label => {
                   assert(
@@ -271,7 +291,12 @@ describe('Time Profiler', () => {
 
               break;
             case fn0Idx:
-              assert(labels.length < 2, 'fn0 can have at most one label');
+              assert(
+                labels.length < 2,
+                `fn0 can have at most one label, instead got: ${labels.map(
+                  labelStr
+                )}`
+              );
               labels.forEach(label => {
                 if (labelIs(label, 'label', 'value0')) {
                   fn0ObservedWithLabel0 = true;